Received-SPF: pass (google.com: domain of linux-kernel+bounces-36154-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 23 Jan 2024 22:42:22 +0000
From: Mark Brown <broonie@kernel.org>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>, arnd@arndb.de,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, alim.akhtar@samsung.com,
	linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org,
	andre.draszik@linaro.org, peter.griffin@linaro.org,
	semen.protsenko@linaro.org, kernel-team@android.com,
	willmcvicker@google.com
Subject: Re: [PATCH 05/21] spi: s3c64xx: explicitly include <linux/bits.h>
Message-ID: <6cfc5715-a4b8-41b4-ad82-95f9519301d0@sirena.org.uk>
References: <20240123153421.715951-1-tudor.ambarus@linaro.org>
 <20240123153421.715951-6-tudor.ambarus@linaro.org>
 <kmijvv53j67l6lgndgrybj6iaup6pyrvzklkre6th4rcnrsrqo@ie5ji4nutbcd>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="CdYcJZPEcogqNf8N"
Content-Disposition: inline
In-Reply-To: <kmijvv53j67l6lgndgrybj6iaup6pyrvzklkre6th4rcnrsrqo@ie5ji4nutbcd>


--CdYcJZPEcogqNf8N
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jan 23, 2024 at 11:28:31PM +0100, Andi Shyti wrote:
> On Tue, Jan 23, 2024 at 03:34:04PM +0000, Tudor Ambarus wrote:

> > +#include <linux/bits.h>

> I don't see why this should be included. Are there cases when
> not having bits.h produces any compilation error?

It is good practice to directly include all headers used, it avoids
implicit dependencies and spurious breakage if someone rearranges
headers and causes the implicit include to vanish.

--CdYcJZPEcogqNf8N
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmWwQKkACgkQJNaLcl1U
h9CGdwf/WB+c1bNFLr9Mw/Bud7/dT7qG4Xs2wsTPTbTW9o1Ygf6DSRdeMNf22+i5
Bk3vgNREsSMYemyPugTQEP7T+dURYDU4LmwwL2YpEjoC/KfqoLxw+3SitZ8RLJS3
me3TNi5biT1j6qZlItY70x76X6REQ4jDs6odxfxvqLlApxp2mb4XXkNT96Oanfx4
uHbNrYgjnDsdNj8HQkdTF52OAtXAzQFhqmArmbXlJwNyS9e6rEsAa5leZY1cibPA
MNHfbJy1hH1PReX7xPuYEKBGBZTUskdW9wICJHcdz6m2Gp6+48lxibDLUdqk0Ex1
ERfpukg31HlmJpbbbD4p3jHSuglE+A==
=dKfr
-----END PGP SIGNATURE-----

--CdYcJZPEcogqNf8N--