Received-SPF: pass (google.com: domain of linux-kernel+bounces-36202-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240123000604.1211486-1-irogers@google.com>
In-Reply-To: <20240123000604.1211486-1-irogers@google.com>
From: Namhyung Kim <namhyung@kernel.org>
Date: Tue, 23 Jan 2024 15:59:56 -0800
Message-ID: <CAM9d7cg2Sr5wjR7Nu8pwmdWzErRT4R5V=VnUnnZhw0w=06Resw@mail.gmail.com>
Subject: Re: [PATCH v1 0/5] Fixes for 6.8 PR1
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, 
	Arnaldo Carvalho de Melo <acme@kernel.org>, Mark Rutland <mark.rutland@arm.com>, 
	Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, 
	Adrian Hunter <adrian.hunter@intel.com>, Ravi Bangoria <ravi.bangoria@amd.com>, 
	Ross Zwisler <zwisler@chromium.org>, Athira Rajeev <atrajeev@linux.vnet.ibm.com>, 
	Shirisha G <shirisha@linux.ibm.com>, Kajol Jain <kjain@linux.ibm.com>, 
	Kan Liang <kan.liang@linux.intel.com>, linux-perf-users@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Ian,

On Mon, Jan 22, 2024 at 4:06=E2=80=AFPM Ian Rogers <irogers@google.com> wro=
te:
>
> Discovered some testing issues around perf list, perf script and perf
> daemon based on Linux 6.8-rc1. Some of the issues were discovered in
> the context of an Alderlake system.
>
> Ian Rogers (5):
>   perf list: Switch error message to pr_err
>   perf list: Add output file option
>   perf test: Workaround debug output in list test
>   perf test: Fix script test for python being disabled
>   perf test: Make daemon signal test less racy

Acked-by: Namhyung Kim <namhyung@kernel.org>

I only have a nitpick on patch 5.

Thanks,
Namhyung

>
>  tools/perf/Documentation/perf-list.txt |   4 +
>  tools/perf/builtin-list.c              | 211 +++++++++++++++----------
>  tools/perf/tests/shell/daemon.sh       |  34 ++--
>  tools/perf/tests/shell/list.sh         |  21 ++-
>  tools/perf/tests/shell/script.sh       |   3 +-
>  tools/perf/util/print-events.c         |   2 +-
>  6 files changed, 177 insertions(+), 98 deletions(-)
>
> --
> 2.43.0.429.g432eaa2c6b-goog
>