Received-SPF: pass (google.com: domain of linux-kernel+bounces-36205-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 23 Jan 2024 16:06:37 -0800
From: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
To: Breno Leitao <leitao@debian.org>
Cc: mingo@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Josh Poimboeuf <jpoimboe@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] x86/bugs: Add a separate config for missing
 mitigation
Message-ID: <20240124000637.jtb6djjzqvdfi4rg@windy>
References: <20240118173213.2008115-1-leitao@debian.org>
 <20240118173213.2008115-3-leitao@debian.org>
 <20240122205821.m5dsyi4sc2ghoavd@desk>
 <Za/Vy2l1VwyI4DKH@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Za/Vy2l1VwyI4DKH@gmail.com>

On Tue, Jan 23, 2024 at 07:05:47AM -0800, Breno Leitao wrote:
> On Mon, Jan 22, 2024 at 12:58:21PM -0800, Pawan Gupta wrote:
> > On Thu, Jan 18, 2024 at 09:32:12AM -0800, Breno Leitao wrote:
> > > +config MITIGATION_RETBLEED
> > > +	bool "Mitigate RETBleed hardware bug"
> > > +	depends on CPU_SUP_INTEL || (CPU_SUP_AMD && MITIGATION_UNRET_ENTRY)
> > 
> > Atleast on Intel CPUs, Retbleed mitigation is meaningless without
> > spectre-v2 being mitigated, shouldn't this depend on MITIGATION_SPECTRE_V2?
> 
> I suppose it is the same for AMD, right?

AMD's retbleed problem and mitigation is a bit different, it has to do
with Branch Type Confusion(BTC). I am not sure if it is possible to
mitigate it without spectre-v2 mitigation. Someone from AMD should be
able to clarify. Looking at the code it appears the dependency is on
CONFIG_CPU_UNRET_ENTRY or CONFIG_CPU_IBPB_ENTRY being set:

retbleed_select_mitigation()
{
..
         case RETBLEED_CMD_AUTO:
                 if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD ||
                     boot_cpu_data.x86_vendor == X86_VENDOR_HYGON) {
                         if (IS_ENABLED(CONFIG_CPU_UNRET_ENTRY))
                                 retbleed_mitigation = RETBLEED_MITIGATION_UNRET;
                         else if (IS_ENABLED(CONFIG_CPU_IBPB_ENTRY) && boot_cpu_has(X86_FEATURE_IBPB))
                                 retbleed_mitigation = RETBLEED_MITIGATION_IBPB;
                 }

> So, I suppose it should be something as:
> 
> 	depends on (MITIGATION_SPECTRE_V2 && (CPU_SUP_INTEL || (CPU_SUP_AMD && MITIGATION_UNRET_ENTRY))
> 
> Is this better?
> 
> Thanks!