Received-SPF: pass (google.com: domain of linux-kernel+bounces-36254-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <724284f0-b387-4b81-9043-f73df6c9f697@collabora.com>
Date: Wed, 24 Jan 2024 03:03:55 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 0/3] Add support for RK3588 HDMI/DP Combo PHY
Content-Language: en-US
To: Andy Yan <andy.yan@rock-chips.com>, Vinod Koul <vkoul@kernel.org>,
 Kishon Vijay Abraham I <kishon@kernel.org>, Rob Herring
 <robh+dt@kernel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
 Heiko Stuebner <heiko@sntech.de>, Philipp Zabel <p.zabel@pengutronix.de>,
 Johan Jonker <jbx6244@gmail.com>,
 Sebastian Reichel <sebastian.reichel@collabora.com>,
 Sascha Hauer <s.hauer@pengutronix.de>, Algea Cao <algea.cao@rock-chips.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org,
 linux-kernel@vger.kernel.org, kernel@collabora.com
References: <20240119193806.1030214-1-cristian.ciocaltea@collabora.com>
 <417281cd-23b1-4948-8c5a-b9820dff65aa@collabora.com>
 <a7e5304a-1cfd-4f38-8708-bfca30f0ef7f@rock-chips.com>
From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
In-Reply-To: <a7e5304a-1cfd-4f38-8708-bfca30f0ef7f@rock-chips.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 1/22/24 12:10, Andy Yan wrote:
> Hi Cristian:
> 
> On 1/20/24 07:41, Cristian Ciocaltea wrote:
>> On 1/19/24 21:38, Cristian Ciocaltea wrote:
>>> Add driver and bindings to support the Rockchip HDMI/eDP TX Combo PHY
>>> found on RK3588 SoC.
>>>
>>> The PHY is based on a Samsung IP block and supports HDMI 2.1 TMDS, FRL
>>> and eDP links.
>>>
>>> The HDMI link has been tested on Rock 5B and EVB1 boards.
>>
>> I missed to highlight there is no eDP support provided by the current
>> implementation.  Downstream kernel has a separate driver for that and at
>> the moment I don't have the hardware to wire this up.
>>
>> Will include this statement in v2.
> 
> The PHY is used for HDMI and eDP on rk3588, and should used be exclusively.
> so I think should s/DP/eDP/ in  all description.

Right, will make this consistent.

Thanks,
Cristian