Received-SPF: pass (google.com: domain of linux-kernel+bounces-36317-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
To: Colin Ian King <colin.i.king@gmail.com>
Cc: Sathya Prakash <sathya.prakash@broadcom.com>,
        Sreekanth Reddy
 <sreekanth.reddy@broadcom.com>,
        Suganath Prabu Subramani
 <suganath-prabu.subramani@broadcom.com>,
        MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] scsi: message: fusion: remove redundant pointer hd
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1bk9bxxng.fsf@ca-mkp.ca.oracle.com>
References: <20240118122039.2541425-1-colin.i.king@gmail.com>
Date: Tue, 23 Jan 2024 21:39:38 -0500
In-Reply-To: <20240118122039.2541425-1-colin.i.king@gmail.com> (Colin Ian
	King's message of "Thu, 18 Jan 2024 12:20:39 +0000")
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?B2GdwRAHEbQiW2x+e115h77kQ3tBPtRDzH2AMvSLn8dTcX4WJAA15J3l5nU5?=
 =?us-ascii?Q?lgh2zbuBcPKIf4y6I3ZjDcIp1V/06CTQKAmUI1mbBhjwYmFUivyI9Y7HVN2N?=
 =?us-ascii?Q?9IMMdRwYOeVBlj8YK6u9IIoOfR04kW7XSJiPSaQk2+ZJtaQTLWWO2FHg3Hvk?=
 =?us-ascii?Q?tL561OOe6408YUQACCfkw5sZMtw8JGzI1vE+j/EqVh0OuWEEGw84InAkM89o?=
 =?us-ascii?Q?/uzy2i/Hj8ZqUdPo66xIIJBzyaL06kupfWrDhOnfyNkSJ5vjXIib5h5XNuXk?=
 =?us-ascii?Q?ELcLyShD5j5HSG/s5DMbk5iN/PIHTxjciijZKcziJ+AQ9v5MlCasgIA/tymh?=
 =?us-ascii?Q?nSAfmRwknMr2rL5DMXcAxtd5qcPhV/jLHSGrT9xhq+HzyeSKUvx/rGD4+dcu?=
 =?us-ascii?Q?RBHpZUf6czJGtnvGlszcg3Y2n29RtF4yNTZ1cYnN76mSQgloowWJRMMQ9f3S?=
 =?us-ascii?Q?Zj4Sob3UYgAaQ9b82M2bwIBJzvLx/GdQIS1dZ7NiVzucatejKZKD7hMJQX2h?=
 =?us-ascii?Q?sSRsZw5YQTBFsAPnAoxL6mgcMdSrjB/U/h5h9pc1Amevo+qzie0c8j8Pcp0T?=
 =?us-ascii?Q?dDr1js5doJs2AqgUiwtgv7B6qc7d9OaEmr2qsy70mrRF6i0TwszR4Z9edKOh?=
 =?us-ascii?Q?FCeX+zErUEw41VEaEkAh6CHQhxTfkCCrTcwReXABvEpYvOJ2uMYmgq/beVxd?=
 =?us-ascii?Q?7ZAXPosKqLKxwkGpZgVEcIozx+FoGKwqE+Kw/vMKhk8x1zyC7gOR2hAOmImx?=
 =?us-ascii?Q?jQW80meNjm2ddWA8PN/2aYXkxo3MlRfLIWxqK9aZwmJjeiEpjayrxgXFY4SU?=
 =?us-ascii?Q?Lpwnn4GtRf/fjiNNIeTI/crGkT6ss7U1AMcfkjwbxUFQMrVrYiSF4zEJnHte?=
 =?us-ascii?Q?8mX7bZksQk8XdKgyPaYQXoXpyzp28VyaCQhq8HtGTvZxhWAh8zG3tA1jmuwy?=
 =?us-ascii?Q?rLuBQ4jRse2pj3sfa2zOn52qdXmmLnHVicoyzBfy8aM7/UUnkL+vlMjsji7C?=
 =?us-ascii?Q?X4jiU+hoHNpwVguMfn9T2IiPzufqw602zDbWtqMSAYHCwMCwjR0Zbil5h0uL?=
 =?us-ascii?Q?eBt8QnV/0gw9SpFmNZqUMqUPc3GW6vl8hMKlyDVBATRv/nouRPwn0QxXlagY?=
 =?us-ascii?Q?gRrI+UbL6gcP17VxdWL9yOaY1kLuKmzDLZcH1ALFKcliZgqtBrsJm3jS566H?=
 =?us-ascii?Q?0RhsBdrdqf6maM0VsGNau310yDLs7sIyHPxR+rpAUMOBwtvJjgBLpcnh/deM?=
 =?us-ascii?Q?SxdGF41/5y/KUzR6IiYHDHoDOWZ8Ve55JMILTjrrqUfy7VQmrkEGJcUq8F3u?=
 =?us-ascii?Q?LuNc8YzADieCCo14PQ+qZ/HIgIG07CW8bQ+fH0Yf+uFZUlEe12NYME3kJ9uK?=
 =?us-ascii?Q?TD8Fn22DJImARA3Zm5DnK2TrlPnpbPuxfqm5fcbVy0HA40CP/OAYsU7CBR6C?=
 =?us-ascii?Q?vMagOdZ5qCiNsY9JiIriqy129qolJHtr9Cgl9qpXwXgGAlPA2hqt7UgevD+g?=
 =?us-ascii?Q?ehta/XDwtXEABTztL5Zo17vV6b5cGrnieOzRPNOo9uGMPWWTnT35KzY8FubH?=
 =?us-ascii?Q?ldxRYxnRqoOzgg2+pSv69EXMZbqxVcy0gSkOEkNJz23oh8kfut6dV0MGVjvl?=
 =?us-ascii?Q?Uw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	p5iiiPVq9eZDBsH4CivdhTqEl71QvAG+BgFlIccMZ90LouS4oLIUjdlpdbrYFq3tzqXQSVRXN4DiaFvCenM93IMwvQWuap7Z+X2HYxZIF8fNdAgIPkAgaxHRO7bfa+b1FgtQK6VfiVig8290AjICDAo6Md+sRm/knDf7epqvaMICcflIuQMU4leZkgtRT4eeoP0SyUAKBAzQopONFB2AyehLBluo8bKBQXcqcskVWAVGA+vuiDQaeFthi9jkCYDKDOwLkuXh8GbURU1jCx7IH7Xku0Df1X2p69lCop2F88kX2osgBKDcUhaARJdoYY8DnOaQtYfC/wUv8VKg+PQ3rvGGFjc7tHrd0tLTIlYv4nKh6jPL4KnFb7DLfI7hKr82eWRytK7bkmCjpOJPLFubbqCoXzmtYSszreuNDl5I9xXejDoGB1keuqv/odjB5HiAMWEh4fPCli+E/kd5sX1di1+IgFOx1tI41lyxWcTUPLhYde9KgKEhmqLrOcTF01cMjflGawsYBpqtslgxAnOeiKcpWOmd7RPptNQJ9zbZkq2c4XOtWdnbQjQHqVcasEJlHJYtaFeiH4YqMOmSOAZ1h8wFoVQgaZWz6OgTgZKHP7Y=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26f95c84-995a-4d2c-201d-08dc1c85b69a
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2024 02:39:40.1011
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UAdopHKt0XYQbrlWy4KYv3BroDt8IkgJdDXQLsXjfjEzeQvspUynGS/7fT1unb32jRoZvxoitVurMKkV3xJkyzzmBf+OIuu/NnBTQrRMJqE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7741
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-23_15,2024-01-23_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0
 mlxlogscore=985 mlxscore=0 phishscore=0 adultscore=0 spamscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2401240018
X-Proofpoint-ORIG-GUID: VIeUJEecwmxhkuebiQhrOmw4OmqPqs8x
X-Proofpoint-GUID: VIeUJEecwmxhkuebiQhrOmw4OmqPqs8x


Colin,

> The pointer hd is being assigned a value that is not being read later.
> The variable is redundant and can be removed.

Applied to 6.9/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering