Received-SPF: pass (google.com: domain of linux-kernel+bounces-36319-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
To: Tyrel Datwyler <turtle.in.the.kernel@gmail.com>
Cc: Kees Cook <keescook@chromium.org>, Justin Stitt
 <justinstitt@google.com>,
        Michael Cyr <mikecyr@linux.ibm.com>,
        "James
 E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen"
 <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2] scsi: ibmvscsi_tgt: replace deprecated strncpy with
 strscpy
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq15xzjxxjr.fsf@ca-mkp.ca.oracle.com>
References: <20231212-strncpy-drivers-scsi-ibmvscsi_tgt-ibmvscsi_tgt-c-v2-1-bdb9a7cd96c8@google.com>
	<202312121321.E15E09BF@keescook>
	<9f246fbc-b2e4-4585-912d-a5a00ac8cd04@gmail.com>
Date: Tue, 23 Jan 2024 21:41:56 -0500
In-Reply-To: <9f246fbc-b2e4-4585-912d-a5a00ac8cd04@gmail.com> (Tyrel
	Datwyler's message of "Thu, 18 Jan 2024 12:21:04 -0800")
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?jX0RnB/VkA/Hy9LQKd46HAONKmdLCJ0/LqOWz9l6L3wW3E72Nx6n5M4nxhl9?=
 =?us-ascii?Q?G1ID6FTvaeTokajZ65Fjn6hw8oAB0kixxBmGWoaDomorvHPLQV9Q9KHVaQ47?=
 =?us-ascii?Q?fzow3Bnn2WU9uObeImy5CcrtC6tMhxNS/CWd/LyK1PEMOJdPCLXqG6Jo2jUH?=
 =?us-ascii?Q?N0UjK2DyqSlDmbX04aHgd273acBcX6+RK7to6idNm8bJ2GinpdPBWXQNW5A0?=
 =?us-ascii?Q?oXO+Sz/1zl5/Zvd5QX9Eb1Q42jWMp/Bsg5GfeEmZ6WKAqBu6V2b5VCZ0Xb3U?=
 =?us-ascii?Q?cWFMVHOhlCWC1moKlpSXR315ceqS2+Cm3YYnbeRzTTQfW15hLF1YKW7ZvPaT?=
 =?us-ascii?Q?dhf7VH4MhNGCGp6+phDtuInFmpFWXBVARaaGlYNj57XIsAkD9MEjK/0znoPX?=
 =?us-ascii?Q?lWwOGmDzntckGa64q12xnUrH3PcoOa3Vyts2an3XDAvLlh/sZdOl+nMvJoRb?=
 =?us-ascii?Q?4B5hbW1E9cwyVWo6spGvok5JV/PA7r3poNDvaQadhCn4RahzNDEhoAWqzDpg?=
 =?us-ascii?Q?xAKBP5w+LTsEXln0jAnHqpYbeScE7KztVgA2jNLdIikP5E2M2KA0g0hm2qZW?=
 =?us-ascii?Q?6IaBOhSh/5JdFKQCs38tV5Uam2pUPRdzlzCKPPx7zb7TGIKzJCS3z588P7Mv?=
 =?us-ascii?Q?BZFtUGvTZMJQUHTsqqKxa7n4EfIiIj2CVoVWywwaS5YbqMiTahi1G7jgFnkD?=
 =?us-ascii?Q?THMhngK6OimYtpPpC8tusiox0DC/Pb8E9250QRLu3W3p9wW8wvCJpLO4JZpD?=
 =?us-ascii?Q?uJD1ievVS8YMnElgh2hCeHIGwqPLeH4xWfGK4WLwkmXDMttdkBrVZkNScltx?=
 =?us-ascii?Q?gbD+zpcEa5nfAoJQkGV1D5LncIGhcvYT14XJjkBhmz/M7/nOt65Dh19eD2yy?=
 =?us-ascii?Q?qYdziZC+bkn1tkd13SgotgCaVgudOTxeTL0WhhZHaGAq0zBpF7Lyo8XsPq4L?=
 =?us-ascii?Q?th3MBynFe8HppSEllByue3+v7/VW2MidzsMH6Z14ru7pLKKh/y70JoZ6NU22?=
 =?us-ascii?Q?Etu8qARqLIWbnpIdlqgrbXIupUzrLmXWRQUrtuZtJih8AgydpSqxUL6RkR/z?=
 =?us-ascii?Q?Lestts6VHxvPmNaDPocX4SkZxyEEjpaqx3b6fsx0gryPXYUl/gVLxfGfQrjE?=
 =?us-ascii?Q?dOscMsSamt3N2x2M0zcnQEAoA9QU8zrf1U41oQPjFK/eUJ79vIbNJozwqH43?=
 =?us-ascii?Q?cJmaqsLipBagyn0CFqq3oO7vm37QEug5oaD4DS9knk5tBfRqaZg8D0KzP2KV?=
 =?us-ascii?Q?pwylCL7w76O9swL/UNQEHXyKgLaTGGq6hNJFV9ctv5kQQ0nQuaiLcs1pJ2Ox?=
 =?us-ascii?Q?ZY8CC1IdgKWI3yM/VZf2B/xLK+sCqVh3OqRHN0pIFLqusX4Fj0hkUlnvXMHJ?=
 =?us-ascii?Q?Stcvw5+6wV7ZpuEnWqpmhQhRv9xPwMwIQse2fmsgjtEfJH3GgYCBNN6zj8h8?=
 =?us-ascii?Q?kQcIojUTEx5A0TgI97/+EkEmHgAQspBUKn7ReOcF4LO4uxTM/5f4z0TGzOqU?=
 =?us-ascii?Q?QvZ7HvcGPWB8OtDJAdGZKDwRWiAiblTvft+/Wkc8BY2FOQNlvpgUdPHMb1/q?=
 =?us-ascii?Q?CZI8CqdGJ6wk4CG75TGIeefly806mQPHUkHh+Odb6Y7+MnJZnqoAnbcz82I6?=
 =?us-ascii?Q?bQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	ZXhOoX7AYRaBXdA7HqG4OK3NcXaj49iTyrGoOisFN4m/22XPhbB9cYQqO9SVJcwS/BJ+wE1RzW06fx3+DC17KmJQs2uUJxnXohnqb1Pqse/1VQv/b+dnr8/JIIEgDOKdJOhbiyKtdw5uUxnQeKtzjucl7rhbVY/Q/F7vHG5V/HGzO+erCWHzI2llNu2kYwtY5HO3CPuJVsVbiFE2lad+J2IscCGl87rF+vDQSQ0cBsAOlp4D/ir0zGU5TqYIbLgSYg7pUw6zWA+dwHWhNF8YtkIZafgH6qCElZJc+Es9YgckGYbFcCcSPL9FnHau5SUvEseds8jybGHgfXqDYczQa1zrhcWbAnUeg7bULRGO1VnBIMkDq9MONV2qGYG+TWaLYkosBR9dWJ8hC722JrxThd8IfthgM7n2uo1+dk14HSrdY1G44QfdUVrOSntk64X5BUYMYWvX0iw0h4QvnJcEyo4eL9i0ECs93F2dy4sU/RIm97IswGbDdBAdsAHLYp5z5BoDxJFk0KLrOy+Cs9E9qgDXz++T6zafx06P45Dz8GXVVmaymE0RRBi2YG1XSIRUrSOKya9u/P/8FarrwfrPj1ZaGyuPni9hEPzqBofBZA8=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4dd6b085-86f4-4108-1353-08dc1c860932
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2024 02:41:58.6631
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: flqJCVtkc3oHw8LvuIKU3j2mpdySXu9vJAd1wKdf5peSCYjYFCG49YS4v4EvJnJbXcfX99YSchPXgV/TZPNsbWy5eH9lstLNbAbFmClc5l8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7741
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-23_15,2024-01-23_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=738
 malwarescore=0 mlxscore=0 phishscore=0 bulkscore=0 suspectscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2401240018
X-Proofpoint-ORIG-GUID: NMJNXUzQCUNKsyVXKu-618RArduSQLCH
X-Proofpoint-GUID: NMJNXUzQCUNKsyVXKu-618RArduSQLCH


Tyrel,

> To reaffirm the assumption, as I mentioned in my response to v1 these are
> intended to be handled as C strings.
>
> Acked-by: Tyrel Datwyler <tyreld@linux.ibm.com>

Applied to 6.9/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering