Received-SPF: pass (google.com: domain of linux-kernel+bounces-36379-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Ratheesh Kannoth <rkannoth@marvell.com>
To: Simon Horman <horms@kernel.org>,
        Subbaraya Sundeep Bhatta
	<sbhatta@marvell.com>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sunil Kovvuri
 Goutham <sgoutham@marvell.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org"
	<kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        Geethasowjanya
 Akula <gakula@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        Suman
 Ghosh <sumang@marvell.com>
Subject: RE: [EXT] Re: [PATCH net] octeontx2-af: Initialize bitmap arrays.
Thread-Topic: [EXT] Re: [PATCH net] octeontx2-af: Initialize bitmap arrays.
Thread-Index: AQHaTbrXg+zTduWcbkyHpGKMW10e/rDntVQAgACO+HA=
Date: Wed, 24 Jan 2024 03:01:15 +0000
Message-ID: 
 <MWHPR1801MB1918ADCA9FD3FAFAF9CC68B3D37B2@MWHPR1801MB1918.namprd18.prod.outlook.com>
References: <20240123051245.3801246-1-rkannoth@marvell.com>
 <20240123181716.GP254773@kernel.org>
In-Reply-To: <20240123181716.GP254773@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?VB8cFZM1+uMvXkpgWldX0Vo5fHhgSXZraXYr0jkkN51aA+6sUR16bsqWzW5P?=
 =?us-ascii?Q?2ulo3Di0NvSREOlioQyxOAxRdC0jKVwIsXUlxGD4Dgnjb3xn81Ik/sm1GSYe?=
 =?us-ascii?Q?A4+KTf6Mhh1DDICfPy6Ka52PVVHd0BNdHXiZzYoTu7fMb54ZFpqHGVlJsn+D?=
 =?us-ascii?Q?w4iBFuXkIcgZjgs96wpjaVeKOMkQ0CPDQgCRUpl1dq68ji93oUyU7BFM3XpQ?=
 =?us-ascii?Q?yzIqNf0h1gKMol4Ug0XNmcJqEW2VGDDG0/Wj/DXU0TlLI84Y7sKVZCFeww+N?=
 =?us-ascii?Q?Yyv03ZiwvNb085y2nPrYQPger7VEkZJyzoLjt0g10JB9Y42vtHqpvUTzKAkE?=
 =?us-ascii?Q?MUhAiIWxGMZ9v4sc8w9MliC/1vKO3fKlOZUj2NvrZXcOKTDsiD/35RlAdCUp?=
 =?us-ascii?Q?D4cbXDOMnn6KhYZJ15EAMqVzrbPU4zpydwgh+8+nGOTE7leOagLJCnMBxlo4?=
 =?us-ascii?Q?N8cfQh1XfabCn4Kc9DwLaiWSHD2rgOA813eq/hnE4ackuLj+QtThfg0rg/7W?=
 =?us-ascii?Q?0y3xWtf1sczIIN+03mpLB6kzxlvtl/5Z2TRMiiuap5vyJ+JWep5jD+NI1Sts?=
 =?us-ascii?Q?BAYTQM6Bj8myok6F1C9bejTCe9kjFH37qEa2fwQSq3I1wL+XHGVNjnTonP7/?=
 =?us-ascii?Q?adpguC9sbxrhWeNKCe4kS5cQBKH/52F95Rm6eiWw1a1927iI3ieRnnIutLmY?=
 =?us-ascii?Q?9Cl/mXLK0OZKo3IuonLE2de01iNS1RChYL8dPX0hHaai+cgHADNIdWfon3KF?=
 =?us-ascii?Q?cym7ztIBh+OONv85ZToapWY3e5gIlnGd0I38jaKLF1jPkNj/15ebQeppy6FK?=
 =?us-ascii?Q?NQZcoVCU9N3YDXp3PlMbEGWAlSbNrK3p8aRS2z1BYa+EaDFWBtOfeska16Qv?=
 =?us-ascii?Q?Ewmq3ZWSpKbjmPexDnl8zoOTRb2wDFQbtZ3/YmarieLQ/nZfb926xaKCMgz0?=
 =?us-ascii?Q?AqP71IKNyoW0Vn5VT42qM2hO5Pyak/emuv9yXXa1gw87oBcsiJHuJho0tPkq?=
 =?us-ascii?Q?IF1hFpQsL6Hw2F3NvKTDQ407hYtELljcih9uB7/ZIouG0/lq/AXgtTDsBC1x?=
 =?us-ascii?Q?y5U5PE839ifHsIzmxpy9gx4iPMSW0nQJg4Xe9kK4IPE1/EGl/ObpXLLSCVJk?=
 =?us-ascii?Q?erJYQiaVANRJ4oECmYPrMbSzE+k/YZHddxu9r3UO8efQ/8R3gprhHgEf6bHE?=
 =?us-ascii?Q?wxaiDJWjzj9lr5aaioz6fdrDIbIifPHzfXz8UeN0VKeuXX1GONNafH9TCyYF?=
 =?us-ascii?Q?0rvijrzET//Oq1mDursl5OEz+cKH8wsuPnq6UYoLY1Ya9kf/DdXr9KDXSm67?=
 =?us-ascii?Q?rAmrioIG7RUhYNGzl3plaUyfL0t5E7lnUWId8bdOcGq4d31Tay4VNZWbzsxM?=
 =?us-ascii?Q?ziOUgf01nwXaEtj2zUjo4sbyhQWpFeW87bLfNSuz/mhLvFP0GXiZbxldRMnr?=
 =?us-ascii?Q?5509XcTK7SLu7BNw5tdDuO7xcU++V9c9BbKLaMlj5NtTcz7b+ir2SOklUwf/?=
 =?us-ascii?Q?JRpe2n7zi49xlcj+CuFYzvXkxRuqRYQ0eVKqUPENhekVaFED/8GYFFkhfwDH?=
 =?us-ascii?Q?0BNByf5NKvUPlVTYIeaoh0BLOp9JMDEiVUm57s1n?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1801MB1918.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ab672f14-72b0-489d-ab6e-08dc1c88bb07
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2024 03:01:15.8492
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: g2nUasbsAPB+mGZSFLsZ/Wd/xiM71WpBQFopq8XMU/UPk/TMgloM6sQEVeih+x0/VjjVrV6KM9+TppLbrZkJhg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR18MB3465
X-Proofpoint-ORIG-GUID: F9ZuK6UNrBQqQkBkjJJOPwifMRC3xIKf
X-Proofpoint-GUID: F9ZuK6UNrBQqQkBkjJJOPwifMRC3xIKf
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-23_15,2024-01-23_02,2023-05-22_02

> From: Simon Horman <horms@kernel.org>
> Subject: [EXT] Re: [PATCH net] octeontx2-af: Initialize bitmap arrays.
>=20
> Hi Ratheesh,
>=20
> I assume that the reason that the cited commit moved away from devm_
> allocations was to allow more natural management of the resources
> independently of the life cycle of the driver instance. Or in other words=
, the
> need to free the bitmaps in npc_mcam_rsrcs_deinit() probably indicates th=
at
> devm_ allocations of them aren't giving us anything.
>=20
> So, perhaps kcalloc() is more appropriate than devm_kcalloc() ?
This was a comment from @Subbaraya Sundeep Bhatta during our internal revie=
w. =20
Could you please help with below questions/doubts ?
1. why devm_kfree() API  is available if it is done independently=20
2. I could see instances of devm_kfree() usage in current kernel where it d=
oes explicit calls.

-Ratheesh