Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp868777rdb; Tue, 23 Jan 2024 19:03:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IFjeMfSUvGxsuBu6WpE+pZUlozIFkquJCdXWi/1U/pY3T7MA0TWjZffkSlbCLRYE5wOgOWj X-Received: by 2002:a05:6402:950:b0:55a:5044:545b with SMTP id h16-20020a056402095000b0055a5044545bmr1345795edz.25.1706065410572; Tue, 23 Jan 2024 19:03:30 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706065410; cv=pass; d=google.com; s=arc-20160816; b=ihaO5B78PN68y2WAOPfo7mtW5vFUHSru31nJ7wZRFDV6c0yZ31ZMYeJho9JO7Ac3XW z3dHh8+eigBULG2y9Grqqe+Z+vmG+YQM7/YsUwlTOzOlNd/XRVtBczS/H4zpFax3NxAz XH5qfDWxL5vBcY7Fpv490/eJgbi6nQqUXBclEKYClN6bdS0JTyWZnL3Qk/CWNT1CXgCa oecuOIRlb//2V7PSoMhVs3K/sWOxhHjVk6Ry+9my2EQMhaRwA/d9VcYxlh1OOU82e8F0 Rxv21mouTtL37+6CL7fyit/D5sJ0zHoKkwhiOAgiO/iz1zbKx87TQS1f5O7o2xSMLGkI CCMw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=4UbNeOfbfl3MG8nSF1LqnyRnaVfgigwOC+AsCYPZ+QE=; fh=Bj5pSgLuh9CAxoBM13Q7/8aPO/25uCiaPokR63tIoP8=; b=RiROf7yxKeAOFVIlGSaWQw4+3wvNq/Lt1EzjKtSsjG6wWwq7AiX1SFVJJIb54Vq866 Eaa9PhGNu0VRQDjPNpqhGS2KZ8ko6O7oWob07KV2n6nH7+lZVXaAvjMypojO9pKt6OMi ts1LHE2nt+ZVyWDdtVOuSD2wfzQlJzHOHRfELXPs3XXi8Y18AE80oDP++z7nrSH5a8bJ AtjYoMnZeJPyGn9YN7oDSMqFE2954/aCzLH45gL+YP3DRSi666E+J1iX1cIxezuwLQA1 jMqaY7IshudXd9O1IB5lc6vFA2j/G4MLKWJ+39q4M/dpsiPekQ5SpPzE9WZrqCXYZbCA i+AA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-11-20 header.b="F/Qezq09"; arc=pass (i=1 spf=pass spfdomain=oracle.com dkim=pass dkdomain=oracle.com dmarc=pass fromdomain=oracle.com); spf=pass (google.com: domain of linux-kernel+bounces-36378-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-36378-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id p28-20020a056402501c00b00557f62bb415si13169580eda.30.2024.01.23.19.03.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 19:03:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-36378-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-11-20 header.b="F/Qezq09"; arc=pass (i=1 spf=pass spfdomain=oracle.com dkim=pass dkdomain=oracle.com dmarc=pass fromdomain=oracle.com); spf=pass (google.com: domain of linux-kernel+bounces-36378-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-36378-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 3BD481F2BBCF for ; Wed, 24 Jan 2024 03:02:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 47537B643; Wed, 24 Jan 2024 03:01:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="F/Qezq09" Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 358FB6105; Wed, 24 Jan 2024 03:01:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.165.32 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706065266; cv=none; b=NrZPueAHefzBCJizZqM2jKES68rsxNyewzH5MwAYS17ScQKdxVqbtQjXXTdxTU9ygjsgpk4J6Q+oKqNmDTHzDJhvkoA6fTrjYUHomCQqDyXfq4D0bzS2fI6wwsjgXZlutCzcYgryFdw9XZpH37/0buYgDJ/MzCeH3k4pDSgM1O8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706065266; c=relaxed/simple; bh=jpttwKn0WE/dCDrLSVB1q4DtvmtjrDz7OA1oWnWVZ8s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fMASHr4vqlfRDv/V8Q9wlk/y+zWqhPMSUGxcFcetxtWKT2rL5JyNQGDuU8bo0V/bfm5mLoty6J4SHlaEVZRAW4FMzFaLIkFG2kIYCcbCyWcbK6Lv7Qed7S9xTNsneGIuNDQkJ+AIKpwK3k97MgQpRaBnYbp2m3mjsJyWdTPa078= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=F/Qezq09; arc=none smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 40O2xTFS018021; Wed, 24 Jan 2024 03:00:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2023-11-20; bh=4UbNeOfbfl3MG8nSF1LqnyRnaVfgigwOC+AsCYPZ+QE=; b=F/Qezq09BxPS77h7XlSUHhQVJxto/9g/ZhOQTmvb5egvMnLmbMEKryrp4Z9ferd+acBL /CsBXHaoejTmY01eXDk3oNc7RusPcxx8hokNQHu2t5JGN/d3y5FcrLFqasflpMqjJpLz FhgtdpcAQu8Zzhx15JATS5ftU/+o1y2HJghN+xZ2hibf2SJeWZ0ekjalrBb9JK7sCqZ1 XP8KuYqeZxDW+Sfdi+orVGzakqgfUtYxn50/WjXVrDLtYX3F1VJ1Phg9LWSK47qMeWlB fcDSsB6upRG1rS8ZeGPxvlg7IHMGhLkfLxlu29JzvwjWZ47DxxhgkaogJmdIvUibwtVJ SQ== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3vr7anqxhd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Jan 2024 03:00:55 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 40O16JZd040785; Wed, 24 Jan 2024 03:00:55 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3vs3168jks-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Jan 2024 03:00:55 +0000 Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 40O30rRu012869; Wed, 24 Jan 2024 03:00:54 GMT Received: from ca-mkp2.ca.oracle.com.com (mpeterse-ol9.allregionaliads.osdevelopmeniad.oraclevcn.com [100.100.251.135]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 3vs3168jht-2; Wed, 24 Jan 2024 03:00:54 +0000 From: "Martin K. Petersen" To: haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, jejb@linux.ibm.com, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-scsi@vger.kernel.org, mhkelley58@gmail.com Cc: "Martin K . Petersen" Subject: Re: [PATCH 1/1] scsi: storvsc: Fix ring buffer size calculation Date: Tue, 23 Jan 2024 22:00:43 -0500 Message-ID: <170606516777.594851.3500343804163840490.b4-ty@oracle.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20240122170956.496436-1-mhklinux@outlook.com> References: <20240122170956.496436-1-mhklinux@outlook.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-23_15,2024-01-23_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=823 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401240021 X-Proofpoint-GUID: rlJhMIxorxUyBSG_xJbRGYVcRwLhc2uL X-Proofpoint-ORIG-GUID: rlJhMIxorxUyBSG_xJbRGYVcRwLhc2uL On Mon, 22 Jan 2024 09:09:56 -0800, mhkelley58@gmail.com wrote: > Current code uses the specified ring buffer size (either the default of > 128 Kbytes or a module parameter specified value) to encompass the one page > ring buffer header plus the actual ring itself. When the page size is > 4K, carving off one page for the header isn't significant. But when the > page size is 64K on ARM64, only half of the default 128 Kbytes is left > for the actual ring. While this doesn't break anything, the smaller > ring size could be a performance bottleneck. > > [...] Applied to 6.8/scsi-fixes, thanks! [1/1] scsi: storvsc: Fix ring buffer size calculation https://git.kernel.org/mkp/scsi/c/f4469f385835 -- Martin K. Petersen Oracle Linux Engineering