Received-SPF: pass (google.com: domain of linux-kernel+bounces-36408-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Elizabeth Figura <zfigura@codeweavers.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org,
 linux-api@vger.kernel.org, wine-devel@winehq.org,
 =?ISO-8859-1?Q?Andr=E9?= Almeida <andrealmeid@igalia.com>,
 Wolfram Sang <wsa@kernel.org>, Arkadiusz Hiler <ahiler@codeweavers.com>,
 Peter Zijlstra <peterz@infradead.org>
Subject:
 Re: [RFC PATCH 2/9] ntsync: Reserve a minor device number and ioctl range.
Date: Tue, 23 Jan 2024 21:43:09 -0600
Message-ID: <1875326.tdWV9SEqCh@terabithia>
In-Reply-To: <2024012356-dove-duke-f7f6@gregkh>
References:
 <20240124004028.16826-1-zfigura@codeweavers.com>
 <20240124004028.16826-3-zfigura@codeweavers.com>
 <2024012356-dove-duke-f7f6@gregkh>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On Tuesday, 23 January 2024 18:54:02 CST Greg Kroah-Hartman wrote:
> On Tue, Jan 23, 2024 at 06:40:21PM -0600, Elizabeth Figura wrote:
> > Signed-off-by: Elizabeth Figura <zfigura@codeweavers.com>
> > ---
> 
> Note, we can't take patches without any changelog text, and you don't
> want us to :)
> 
> >  Documentation/admin-guide/devices.txt              | 3 ++-
> >  Documentation/userspace-api/ioctl/ioctl-number.rst | 2 ++
> >  drivers/misc/ntsync.c                              | 3 ++-
> >  include/linux/miscdevice.h                         | 1 +
> >  4 files changed, 7 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/admin-guide/devices.txt
> > b/Documentation/admin-guide/devices.txt index 94c98be1329a..041404397ee5
> > 100644
> > --- a/Documentation/admin-guide/devices.txt
> > +++ b/Documentation/admin-guide/devices.txt
> > @@ -376,8 +376,9 @@
> > 
> >  		240 = /dev/userio	Serio driver testing device
> >  		241 = /dev/vhost-vsock	Host kernel driver for virtio 
vsock
> >  		242 = /dev/rfkill	Turning off radio transmissions 
(rfkill)
> > 
> > +		243 = /dev/ntsync	NT synchronization primitive 
device
> > 
> > -		243-254			Reserved for local use
> > +		244-254			Reserved for local use
> 
> Why do you need a fixed minor number?  Can't your userspace handle
> dynamic numbers?  What systems require a static value?

I believe I added this because it's necessary for MODULE_ALIAS (and, more 
broadly, because I was following the example of vaguely comparable devices 
like /dev/loop-control). I suppose I could instead just remove MODULE_ALIAS 
(or even remove the ability to compile ntsync as a module entirely).

It's a bit difficult to figure out what's the preferred way to organize things 
like this (there not being a lot of precedent for this kind of driver) so I'd 
appreciate any direction.

--Zeb