Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761518AbXLQFF3 (ORCPT ); Mon, 17 Dec 2007 00:05:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751777AbXLQFFW (ORCPT ); Mon, 17 Dec 2007 00:05:22 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:48052 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750711AbXLQFFV (ORCPT ); Mon, 17 Dec 2007 00:05:21 -0500 Date: Mon, 17 Dec 2007 05:05:12 +0000 From: Al Viro To: Paul Mundt , Andrew Morton , linux-kernel@vger.kernel.org, Ingo Molnar Subject: Re: div64: Rework 64-bit type safety checks in do_div(). Message-ID: <20071217050512.GY8181@ftp.linux.org.uk> References: <20071217014805.GA15156@linux-sh.org> <20071216190418.8acc64d1.akpm@linux-foundation.org> <20071217032019.GA15449@linux-sh.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071217032019.GA15449@linux-sh.org> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 776 Lines: 15 On Mon, Dec 17, 2007 at 12:20:19PM +0900, Paul Mundt wrote: > (Adding Ingo to CC regarding kernel/lockdep_proc.c..) > That seems to be an accurate asessment, yes. If do_div(s64, ...) is buggy > behaviour, then the current check is fine, and the callsites should be > corrected. Though if there's code in-tree that relies on s64 do_div, that seems > to be a more problematic issue. It is a bug and the only existing callers that manage to work are those that make sure that signed value is positive. Still asking for trouble... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/