Received-SPF: pass (google.com: domain of linux-kernel+bounces-36470-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <d32d17ed-87b5-4032-b310-f387cea72837@arinc9.com>
Date: Wed, 24 Jan 2024 08:30:11 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next] net: dsa: remove OF-based MDIO bus registration
 from DSA core
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>,
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
 Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
 Luiz Angelo Daros de Luca <luizluca@gmail.com>, mithat.guner@xeront.com,
 erkin.bozoglu@xeront.com, =?UTF-8?Q?Alvin_=C5=A0ipraga?=
 <ALSI@bang-olufsen.dk>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240122053348.6589-1-arinc.unal@arinc9.com>
 <20240122053348.6589-1-arinc.unal@arinc9.com>
 <20240123154431.gwhufnatxjppnm64@skbuf>
Content-Language: en-US
From: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= <arinc.unal@arinc9.com>
In-Reply-To: <20240123154431.gwhufnatxjppnm64@skbuf>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 23.01.2024 18:44, Vladimir Oltean wrote:
> On Mon, Jan 22, 2024 at 08:33:48AM +0300, Arınç ÜNAL wrote:
>> These subdrivers which control switches [with MDIO bus] probed on OF, will
>> lose the ability to register the MDIO bus OF-based:
>>
>> drivers/net/dsa/b53/b53_common.c
>> drivers/net/dsa/lan9303-core.c
>> drivers/net/dsa/realtek/realtek-mdio.c
>> drivers/net/dsa/vitesse-vsc73xx-core.c
>>
>> These subdrivers let the DSA core driver register the bus:
>> - ds->ops->phy_read() and ds->ops->phy_write() are present.
>> - ds->user_mii_bus is not populated.
>>
>> The commit fe7324b93222 ("net: dsa: OF-ware slave_mii_bus") which brought
>> OF-based MDIO bus registration on the DSA core driver is reasonably recent
>> and, in this time frame, there have been no device trees in the Linux
>> repository that started describing the MDIO bus, or dt-bindings defining
>> the MDIO bus for the switches these subdrivers control. So I don't expect
>> any devices to be affected.
> 
> IIUC, Luiz made the original patch for the realtek switches. Shouldn't
> we wait until realtek registers ds->user_mii_bus on its own, before
> reverting? Otherwise, you're basically saying that Luiz made the DSA
> core patch without needing it.

My findings point to that. Luiz made the patch to optionally register the
MDIO bus of the MDIO controlled Realtek switches OF-based. So it's not
necessary to wait.

Arınç