Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp994362rdb; Wed, 24 Jan 2024 01:12:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IES9Xoe5bMud4AEI1RXsuKccuBuoqMlW0t1IW3TLu71bAo6PisWF19xlMNHjlYIltHrSww6 X-Received: by 2002:a05:6808:b2c:b0:3bb:edfd:42db with SMTP id t12-20020a0568080b2c00b003bbedfd42dbmr1192520oij.63.1706087569118; Wed, 24 Jan 2024 01:12:49 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706087569; cv=pass; d=google.com; s=arc-20160816; b=DAeersAc/3uTWEo0IPzdOhb2uhA0hhRJ7Fyj0fm/fVc2ggiTKeE2WPqGzh48YBYhd3 cYKzX/w0VqCkVkP3YgKplEtQhzi5ZGJYdh9Yt1LGWGQTPKQhLebbvSfdOiOYJqKkOhls 3Rnch7qba0N+6fbh7ZgAutPIFkvUFHkHOUoVX9sTtmvsKHElaMQJOE1TNAgrn4UCKzc0 TNVsME/6dJMdQA81uQXK3X1xAeI+MIfe76v2SoNOkXZnC8ZTgE5a1wXIKN/VvOfBtnfE GxgsZWa0slQAK8AGMfwlPLQ0CcWJakBdWnJvD9hx5hHjvXfFvL0giyFNyKlQH71DS6Bj xFHA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=qDGWWvngYrXMHFwGpStoErGRJgClfXa6zjwKTrnmtoY=; fh=66282be9R2J53NCKflo8JYF0XuA3A+P9Vie+cVc8X2A=; b=mJWEZuK94HQmtrOJFMnPLeA6j3MBscC9zOFNf7Qb4xFRAHtqUJekP6i7fR/eQmLdG3 DGr0rjzGJjTiW6OVtMAvQzjdQya5usUlfD88kQeD+2VONlNrvFTiKJ6hiZfIWTX9876q HFp0uWOGUW3jvPv8Gl1vgyocsBhRSsJ7+yTVH/KJCaR2dOPf9SEkEN0C286o+8YqJTwU PXbNzLc06NcCf7AABtP0RWsPo/maebD4pIMmTXttj3P0fDak0csanCD6H00P9M6K5T7/ DAbGRW2+iF/TPFS6Rxn1jX+sqwUXREAprkZkBATKYh7kmCENDVShZQ9UCtwCVC0OMrNz 4fxw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=OWjdUa2N; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-36682-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-36682-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id vw4-20020a05620a564400b00783b5f9e194si572250qkn.106.2024.01.24.01.12.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 01:12:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-36682-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=OWjdUa2N; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-36682-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-36682-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id CAE4C1C21F4E for ; Wed, 24 Jan 2024 09:12:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7563917BD8; Wed, 24 Jan 2024 09:12:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="OWjdUa2N" Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68E6217BB5 for ; Wed, 24 Jan 2024 09:12:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706087559; cv=none; b=ObWkbUt2m/uKGOCROjLKUGwlJTFv7Pz+Ed3SkbJsP5ElxxJqih6FTrjPH9GMbB5rZG0z3ulpAAhxDl9QHyw7U7U7ndm8X3mNZBF+94fi3z8+rS9ZO9DcoqcM4owW5iI+pi+30EllPx3Y+QItLv526Yw3twaOCCIv2oUw8Xu9xPU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706087559; c=relaxed/simple; bh=sg2x6RglKOa/ZHOjgcmXB6to1BOsPavab2cnbypTlek=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=bmdXOSCVNzW3J4MMp1rEWPZ/UhElb12dN8fvOE/mS0MZiNRr3Uut4PX9ZNDSknL+0L7WZ0RYznAJWEBDTt8cmUP+bIOEEp5swna8+TyGEreTITlIPMCVI+ZHHCPgH9a9XtZQ+uE8pbcqI1n9FGmhk1MHvCqXFrgKBnK2bTNgbkU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=OWjdUa2N; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-51008c86ecbso1790657e87.2 for ; Wed, 24 Jan 2024 01:12:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706087555; x=1706692355; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qDGWWvngYrXMHFwGpStoErGRJgClfXa6zjwKTrnmtoY=; b=OWjdUa2NIhXeHySf7Qo3s8I5abVSICUB85/n9bqnTNODGNQGCSRu9LQUSfZxCuci9A +u6v4QLNnMzf2CvM2wLCx5E3LnIPHcf5bx2oQ2Hbo2PykI0/TYt8TEdwjvvyTAb1zGdM MYbJDI7IRElZf8UbDaAL4G4to9r8sfMg7nQMsmq7BsqHsgwx2fVjN9PulhSVOZuJtcqS bnRka8WonoiEE3K/Uu+aa99a/3qvJHnU9KrubvDQSFkY69q/w/cPkFxI9X/EBwPM1aTW BzGagcYs/yWELYCmbKG7ofY1Cewcyer9IMlK6Tyb/drzp8+Kbd6/l1XkSjxq37H+FDsa t2IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706087555; x=1706692355; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qDGWWvngYrXMHFwGpStoErGRJgClfXa6zjwKTrnmtoY=; b=h5S+zAMJFpDnyY9BsEE4fOAYu6XLuzKb4OIjHKmS3B1oDhdBuJmaOGnbInQ+h/SHLI Z5PykSfWMQ6b0TWfkeBbpehUM9cteDKDnp4WN1WUdYUEzW2V8Y/Jp4cxf4gL8YbgdiLS w+b28ie5SsIfhLQU5igalmoTLmNkyUCTNsvlmwvi0k12cGDx5X2HicSBjram/KhDqbvC 4U4edX08klgExTImfaKE5x1GweH6eH6FMruVF/HRr6oU+nsgcB7e4b+xjecfFvoORs32 OcO9kqU8UROhrGUZt6hNnJ97BOsrGpbRoYE56R+V/AtEcr8DHLQ2bu3yETboW2waPzl2 y84A== X-Gm-Message-State: AOJu0Yx081xrEddHuxN4+USLvNEljJFUmfZ3UOrmGY8bDKftS+NmfILA aZE6kYVlThx634ry7/fGNe1xhXeucPbvkYmm/E+zAJmGeV/BSONqani2wRWcMDtKAu0P2LIX4z9 hqo7luVcsA8TXIwctdlp6QD2e4UtmOIyKZjnX X-Received: by 2002:ac2:5384:0:b0:50f:732:c4d5 with SMTP id g4-20020ac25384000000b0050f0732c4d5mr2849591lfh.64.1706087555324; Wed, 24 Jan 2024 01:12:35 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <202401221624.cb53a8ca-oliver.sang@intel.com> In-Reply-To: From: Yosry Ahmed Date: Wed, 24 Jan 2024 01:11:59 -0800 Message-ID: Subject: Re: [linus:master] [mm] 8d59d2214c: vm-scalability.throughput -36.6% regression To: Oliver Sang Cc: oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Andrew Morton , Johannes Weiner , Domenico Cerasuolo , Shakeel Butt , Chris Li , Greg Thelen , Ivan Babrou , Michal Hocko , Michal Koutny , Muchun Song , Roman Gushchin , Tejun Heo , Waiman Long , Wei Xu , cgroups@vger.kernel.org, linux-mm@kvack.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jan 24, 2024 at 12:26=E2=80=AFAM Oliver Sang wrote: > > hi, Yosry Ahmed, > > On Mon, Jan 22, 2024 at 11:42:04PM -0800, Yosry Ahmed wrote: > > > > Oliver, would you be able to test if the attached patch helps? It's > > > > based on 8d59d2214c236. > > > > > > the patch failed to compile: > > > > > > build_errors: > > > - "mm/memcontrol.c:731:38: error: 'x' undeclared (first use in this= function)" > > > > Apologizes, apparently I sent the patch with some pending diff in my > > tree that I hadn't committed. Please find a fixed patch attached. > > the regression disappears after applying the patch. > > Tested-by: kernel test robot Awesome! Thanks for testing. I will formalize the patch and send it out for review.