Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp1009695rdb; Wed, 24 Jan 2024 01:52:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IE8sL8CWm/Xh5eniqBAPUeiTUgNodvT5xnMlbIpz5Gqb70NW4c8+9FCxyhZ65UYjWIwH+vp X-Received: by 2002:a17:90a:3949:b0:290:38f2:8a05 with SMTP id n9-20020a17090a394900b0029038f28a05mr1301802pjf.5.1706089939904; Wed, 24 Jan 2024 01:52:19 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706089939; cv=pass; d=google.com; s=arc-20160816; b=HWPf4Gv4vVRWFZ25Q+oOvEuMr5k4NbAIEPed3QUSBSa6dDaDHRg5I/9qFLbcq5D3IT P6qyCtSlhJNeMCu9CGLM2uCSLGHOjGROjVegLKiu99WSde5o8ggf5Qg3CUXArMFhxi3d fB0M5U4xrT+neCfnbzWFAI5Ie/FXBnnxfZ1RYh0kFbxYowg1XjJf+XjlUHNancMutjkr 41KzFh2mrkAiV18tHhEzSyxGGQZ7BioD66gyZw5y/tTyYT32T4Zby4tG4B7UoOvgYpvx YUf3OmT2RrqNrffEfI2FNXozyYUZnn8ZMCXN7ECO3WuzKMFa1lV84bo/VHY0RjX6IW/S xZEg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:references:in-reply-to:subject:cc:to:dkim-signature :dkim-signature:from; bh=8ChCn7BnUC2Ra2qH1XEh6xfcFp4o5YyhARENMBZPK1s=; fh=9r9dEnw/3HBXWR7ip5o6X+YCKdU88ZZ1yWf67g3Wh14=; b=iKG75kKt6thBpmFc+Wg7UIpcUPEi0cvJHRofX+AwrpWhTKGvmYR2YTAI9o4OADy3sl rA2DnQbOFJdZnKl+AXs5UsTSrw80XatL8+mRS537j7uHUuIBlYgsxv0r61/cHuT3qT+7 AkEeZ5Qib5xyikdb9nQfas24v+v8trSXl+JLUQUGnO38MME1BuMzmDZlo57SxgIu4YtK 9bCZ2VFEfblBIv7yfJ3IAamZpLLTyslpX6T58O7krRna+Rbbihza6B2RUc3QOq3+bHJw eDVonl5H4oytByrrBcKgHdXpBfTKbxWZSdoYCgcd9ho96NnnaBaHh0ZwBhLFsxUwAQkG TKAw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=uOem8iJx; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-36739-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-36739-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id jh14-20020a170903328e00b001d70c1137absi10607818plb.510.2024.01.24.01.52.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 01:52:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-36739-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=uOem8iJx; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-36739-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-36739-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id ED39028717C for ; Wed, 24 Jan 2024 09:47:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C1D1A18040; Wed, 24 Jan 2024 09:47:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="uOem8iJx"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="HOzolg7d" Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86CAF175AB; Wed, 24 Jan 2024 09:47:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706089640; cv=none; b=o9uHEWcbH7nV31wjhhIbJsClO9/l1D3tB/uMeenvoVfyyvbiJhjqVgPdvtFYcpJ2W7vhszOA8r/zu66EsjBJE5N3wPrwIu+b66rA/ocIkaU5ZYro2a0xH1MMhMO9z29/D7hEJiPqSD3VXAtutljv+E8Y8P/JAHS1hxgJxuXKKDg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706089640; c=relaxed/simple; bh=8ChCn7BnUC2Ra2qH1XEh6xfcFp4o5YyhARENMBZPK1s=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=dzLQccLnFXrjzXgq0A4HDcpmHM84T6HQCruH7uzTAr8lK9IaVj1bPPBRFbmCMQTPV7InFegyusROIM7QQo5QguzqWwbVRWMdWGlyNAS4pzqyqHtTH/4W+g695n52h6UZPeBgsDVFcCto3LNHboycvp3NwJcctqfRj2hyijWdZXk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=uOem8iJx; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=HOzolg7d; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1706089636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8ChCn7BnUC2Ra2qH1XEh6xfcFp4o5YyhARENMBZPK1s=; b=uOem8iJxhr+RJ+vL+x7ujlYNCrsCKwZl0FUe6Jzi0qCfUt5PU9gWQ2sd+ivORtnOh2ios/ H1yGHwAcRgk/Cd+j4DfMFq+PsfGloLn2IDLgo9iwP8RvS2/AwhxjYOsaQlczLzNhy1zJBq U3RQ+EaOR3erZuPx+Qg02bG7W+cB1R88GjpoULb1RZ6Q0Egk5pl1wRuM5OXLvMxG8MDL4t L8nAfFJt37oKwL1XpA94eGJyvzUMMV9n1AK+X8m6sxDdE4UnvAEm7hkzt25TGfuOM9NBFH u9M1FV+wbNCJlK4bCflsJApVZEBpqgs5IXNRjYvln5aZ2c96wcHPiFuwBPBOnw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1706089636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8ChCn7BnUC2Ra2qH1XEh6xfcFp4o5YyhARENMBZPK1s=; b=HOzolg7djKXwbPIRObqTQzCtNM0iLjCuPQlOcYuIhJ6pKTCM057teONezZNSTEc2kSMciU rasfiXI3DlmGVyAA== To: Junxiao Chang , bigeasy@linutronix.de, tglx@linutronix.de, rostedt@goodmis.org, linux-kernel@vger.kernel.org Cc: hao3.li@intel.com, lili.li@intel.com, jianfeng.gao@intel.com, linux-rt-users@vger.kernel.org Subject: Re: [PATCH 1/2] printk: nbcon: move locked_port flag to struct uart_port In-Reply-To: <20240123054033.183114-2-junxiao.chang@intel.com> References: <20240123054033.183114-1-junxiao.chang@intel.com> <20240123054033.183114-2-junxiao.chang@intel.com> Date: Wed, 24 Jan 2024 10:53:10 +0106 Message-ID: <87le8f9i75.fsf@jogness.linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On 2024-01-23, Junxiao Chang wrote: > Console pointer in uart_port might be shared among multiple uart > ports. I still want to investigate why the pointer is shared. This sounds sloppy or dangerous. > Flag port locked by nbcon should be saved in uart_port > structure instead of in console structure. If it turns out that the pointer sharing is necessary, this patch will fix the reported problem. Reviewed-by: John Ogness