Received-SPF: pass (google.com: domain of linux-kernel+bounces-36756-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240118121542.748351-1-maobibo@loongson.cn> <20240118121542.748351-3-maobibo@loongson.cn>
In-Reply-To: <20240118121542.748351-3-maobibo@loongson.cn>
From: Huacai Chen <chenhuacai@kernel.org>
Date: Wed, 24 Jan 2024 17:56:18 +0800
Message-ID: <CAAhV-H45A4m-imDh8UZqXJ3WXduMyubbd1ze-EgZtqqbfjHt1g@mail.gmail.com>
Subject: Re: [PATCH v3 2/3] irqchip/loongson-eiointc: Refine irq affinity
 setting during resume
To: Bibo Mao <maobibo@loongson.cn>
Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>, Thomas Gleixner <tglx@linutronix.de>, 
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Sergey Shtylyov <s.shtylyov@omp.ru>, lvjianmin@loongson.cn
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

I can give an Acked-by if these lines are also removed in our internal repo=
.

Huacai

On Thu, Jan 18, 2024 at 8:15=E2=80=AFPM Bibo Mao <maobibo@loongson.cn> wrot=
e:
>
> During suspend and resume, CPUs except CPU0 are hot-unpluged and IRQs
> are migrated to CPU0. So it is not necessary to restore irq affinity for
> eiointc irq controller when system resumes. This patch removes the piece
> of code about irq affinity restoring in function eiointc_resume.
>
> Signed-off-by: Bibo Mao <maobibo@loongson.cn>
> ---
>  drivers/irqchip/irq-loongson-eiointc.c | 16 ----------------
>  1 file changed, 16 deletions(-)
>
> diff --git a/drivers/irqchip/irq-loongson-eiointc.c b/drivers/irqchip/irq=
-loongson-eiointc.c
> index 6143adb1b73b..86f4faad0695 100644
> --- a/drivers/irqchip/irq-loongson-eiointc.c
> +++ b/drivers/irqchip/irq-loongson-eiointc.c
> @@ -315,23 +315,7 @@ static int eiointc_suspend(void)
>
>  static void eiointc_resume(void)
>  {
> -       int i, j;
> -       struct irq_desc *desc;
> -       struct irq_data *irq_data;
> -
>         eiointc_router_init(0);
> -
> -       for (i =3D 0; i < nr_pics; i++) {
> -               for (j =3D 0; j < eiointc_priv[0]->vec_count; j++) {
> -                       desc =3D irq_resolve_mapping(eiointc_priv[i]->eio=
intc_domain, j);
> -                       if (desc && desc->handle_irq && desc->handle_irq =
!=3D handle_bad_irq) {
> -                               raw_spin_lock(&desc->lock);
> -                               irq_data =3D irq_domain_get_irq_data(eioi=
ntc_priv[i]->eiointc_domain, irq_desc_get_irq(desc));
> -                               eiointc_set_irq_affinity(irq_data, irq_da=
ta->common->affinity, 0);
> -                               raw_spin_unlock(&desc->lock);
> -                       }
> -               }
> -       }
>  }
>
>  static struct syscore_ops eiointc_syscore_ops =3D {
> --
> 2.39.3
>