Received-SPF: pass (google.com: domain of linux-kernel+bounces-36810-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Ratheesh Kannoth <rkannoth@marvell.com>
To: Simon Horman <horms@kernel.org>
CC: Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com"
	<edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        Geethasowjanya Akula
	<gakula@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        Suman Ghosh
	<sumang@marvell.com>
Subject: RE: [EXT] Re: [PATCH net] octeontx2-af: Initialize bitmap arrays.
Thread-Topic: [EXT] Re: [PATCH net] octeontx2-af: Initialize bitmap arrays.
Thread-Index: AQHaTbrXg+zTduWcbkyHpGKMW10e/rDntVQAgACO+HCAAIMFgIAAAFaw
Date: Wed, 24 Jan 2024 10:43:26 +0000
Message-ID: 
 <MWHPR1801MB191860047DEE03672DC642E3D37B2@MWHPR1801MB1918.namprd18.prod.outlook.com>
References: <20240123051245.3801246-1-rkannoth@marvell.com>
 <20240123181716.GP254773@kernel.org>
 <MWHPR1801MB1918ADCA9FD3FAFAF9CC68B3D37B2@MWHPR1801MB1918.namprd18.prod.outlook.com>
 <20240124103755.GY254773@kernel.org>
In-Reply-To: <20240124103755.GY254773@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?GhhU+yHeKoSACY+fwFmEixUKwSOLI/DvDf9PqerV/2oD+Hu9eLUyAFci9yQn?=
 =?us-ascii?Q?lvUAWyae+0eiHPhvM9FxzP5+pLOdb/YOV9OSyAkSq8WbW61F7hZ3AHb0MCMq?=
 =?us-ascii?Q?nFk/3UlsWRJHyHmP74POGrbZwMECW3LOjmn7GMWwfc2PFD26rhhfxDyrzlBR?=
 =?us-ascii?Q?IvidjfGC2cOx1jgj/9fjGnrysCGlQXreh8e1v23jlfMENgkC3pVmg8YKVdCe?=
 =?us-ascii?Q?KWJASIK86qsMLogL2ReiL9aKydiuALGTQj5m183J80gBwckQghgLk8RbAVDE?=
 =?us-ascii?Q?cGFLEDlUBNEQ2xDlK0wgQ1M+2DuecwQp38dkXGXlUFTgR8Af9RXrgmwuurqX?=
 =?us-ascii?Q?xz8VRlv15+7Hx2zrQbv96Pia+l54n1055io+bP1sGErFWUlH3fNwSgKVIlQ9?=
 =?us-ascii?Q?GKzFEMDXdLlAfCGWFUa8vvKamh2lPFbN2ihBAGdWqVwcbc4PZYXTK8oE4OtP?=
 =?us-ascii?Q?3rVpDxL0Vn4hZfcvdQg28VmPhFVD2ghOw3aFvGIkxJDtIN4uA5t9ggUZUhgE?=
 =?us-ascii?Q?U9R+NSvf80ORzT/dUIMlLe0Tr28AUHVxlrOCPJ3d+Q+qoSL1i3LGUhWh/3Rq?=
 =?us-ascii?Q?7VcwisTdoKpa4scJ2wfc+9vrCdDsQhTac9Ui+X6QDGZPqEIYsxbDpw2a+lVe?=
 =?us-ascii?Q?W3mD1fOOa34xlunwkQWC4RdXD/ZBjqBWroiSK++P77OLZlW3T4aDnd5X3qOV?=
 =?us-ascii?Q?gM12lzleu5NtKNujLp8tlgJLfR90Ie55Q0LA5rovi0HrRntG39Y/4/sx1TxH?=
 =?us-ascii?Q?GGnyi75/xGKNYUwSazOKeAxsbcFR/mXS5aa7rsdc0my6cJiY91pTlDQYAB9q?=
 =?us-ascii?Q?bgh3dCocyk/1DWJMT7+U86xishgsjxxkg9Armleu6zcykpMmf4Q381i7+Zqu?=
 =?us-ascii?Q?K0OmzvM2W8WjIXokXUKAndbFN/9Koi+wyd3q5+pjGm2Wd7n62v+0C5sIvb+6?=
 =?us-ascii?Q?SeMa8eEcyIsNj/1n6EUI2yuCeslAt1EFr2SeSU4BKaskHLONQxzO/yxGEPI4?=
 =?us-ascii?Q?BKjz0o73Tf5a1WJrVoEcJ+Fxj4QOGbKlzuRL7zIYNQATb70P1bqUt54MiPmx?=
 =?us-ascii?Q?gP59YRENC8pd6rf+NtuVVwSO4FCjl2z6NHOSIz9qSy9nwQiIjAzljNE8qCVA?=
 =?us-ascii?Q?CMZNWlRcm/4kdBxSzPkMHMrFtQk1TKgT4PQv/SVze2/bgm3nZccVYTQxIEic?=
 =?us-ascii?Q?2tiHdGzmAKe+FxjKxjbGQM8NCFcTVl455kgzwlQPkQSCmS+0cJg7tRuMCUuP?=
 =?us-ascii?Q?DqJ+yBJ/aTUJkVUuNjS3U6A961XzktnMKdSxqRwvmwOgHv1YVx7aj/Ohk34i?=
 =?us-ascii?Q?mBnLZQuOoZkIgwBfnjboCyK8KhgoOqERaYNqLBJieQ5KOyqaqrKn215oXTZ3?=
 =?us-ascii?Q?LVktYDw2H7gsL3nQhC5Kucs4cplpSZ48shoKafWktN5vD+NEMh8uHPVq/gCc?=
 =?us-ascii?Q?tJb97ItXeGtFApxEDIK5SaYEOGZi15e1jO3SoItuAFaS9z4GiqwkrKfEozQv?=
 =?us-ascii?Q?MEoXFGBfVL1DVdlWAlPG5UpjySSdZkdYKpIzbMCVAg8BaPhsIPjlaKXy8kOB?=
 =?us-ascii?Q?H0ByZxbtROlEeGoRxypNaoUX1bHjfWxiQFuwQX4c?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1801MB1918.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a1efab2-b370-4cf2-e911-08dc1cc94baa
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2024 10:43:26.2867
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: k378VnyiE+el/ui8ep992bpAdgxtSMh79Ksc1fycJJ0H35Q6kQNv+qMLPpPJOnQ7IjRS7HA+ScKC0g2GCNb/7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR18MB5530
X-Proofpoint-ORIG-GUID: -vEhtn1g_cJWO6BxizMwxFQwDTkT2daq
X-Proofpoint-GUID: -vEhtn1g_cJWO6BxizMwxFQwDTkT2daq
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-24_04,2024-01-24_01,2023-05-22_02

> From: Simon Horman <horms@kernel.org>
> Subject: Re: [EXT] Re: [PATCH net] octeontx2-af: Initialize bitmap arrays=
.
>=20
> I think the question is: if the devm_kfree() calls are removed, then is t=
he
> lifecycle of the objects in question managed correctly?
If lifecycle of the objects are managed correctly without devm_kfree(), why=
 this API is=20
Provided and exported in kernel ?

>=20
> > 2. I could see instances of devm_kfree() usage in current kernel where =
it
> does explicit calls.
>=20
> Sure. But in this case the use of devm_* doesn't seem to be adding anythi=
ng
> if the memory is _always_ freed by explicit calls to devm_kfree().
I got it.  I would like to keep the diff minimal (rather than deleting line=
s diff). would this be okay ?