Received-SPF: pass (google.com: domain of linux-kernel+bounces-36908-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <71426744-7223-448c-bd5b-ff786c5f8e65@gmx.net>
Date: Wed, 24 Jan 2024 12:48:21 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3] pwm: imx27: workaround of the pwm output bug
Content-Language: en-US
To: Francesco Dolcini <francesco@dolcini.it>, pratikmanvar09@gmail.com,
 u.kleine-koenig@pengutronix.de
Cc: festevam@gmail.com, jun.li@nxp.com, kernel@pengutronix.de,
 linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
 linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
 oe-kbuild-all@lists.linux.dev, pratik.manvar@ifm.com,
 s.hauer@pengutronix.de, shawnguo@kernel.org, thierry.reding@gmail.com,
 xiaoning.wang@nxp.com
References: <20240103103421.GA3758@francesco-nb>
 <20240103110200.1018-1-pratikmanvar09@gmail.com>
 <20240103122005.GA3347@francesco-nb>
From: Stefan Wahren <wahrenst@gmx.net>
In-Reply-To: <20240103122005.GA3347@francesco-nb>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:FpBdyYjUWIo=;jFb/N0V408yet10BGR49UXehfay
 FudKxEWyxwbw3NNEzeMb1N/TVWJUmQV4dZfffaXO76sdWA8FvJZSB+0d4L5TSRbEccHRpmyWo
 viIrbtGCxK3Sutk1uEdYWsoIqDNP+tfTNAuPvySvUn7nWuQpzgBdQNPXVfi9KnfaiUswvpNdJ
 zuzy/AeEi9gfWidRmizzULC/keCwxb2Bd+2DYWnwxv7q3xueD2D4OVV7lkC49HA3wiwMnPqhP
 BtkEsaXw6aJAgGYeQ2qS45B8OOi8p7f+uEb/5dmPPrNfWLvJd6tzyISnFVT4NjMxJq0rw/5Bp
 cneQYp73tFiX6WbDGWU2RLR7nmX3MDLUWTn3Xd7tCIILDWsMvFKIdy6E8LHv1FOsOqq+P+A1O
 U0Iitj5isxkf71y+T87PMfNgU/loe7Z8tmdXcUGqRLUevKW3oo8eZEm46TpgIMYbi/WJ4Y3dv
 OLQ6hiB7Vx8bfBQq+IjqhF+idw67whxd31jtj4EGtZa/PYcDDLi0jP9YIF18ZPq+Py5wqDyYW
 T6VZYoyj3KojJLRn0vJMXEkvdoXpEp80HklJ/eS79G1OQ5XyyIjUzDd+rPGo6HbTLXwy9Hl2k
 TW+jfBKiOJSmeuculO+DIREzlPAxKy5mZN+jkqJ3MQNcfSihqVQyYsTaZ46z7mu6bOtfZEUux
 0jLiO4epT4OTMtEgokXfRlXd15eAnlVQJ4sHXJwKV5AZqtH10HmwPUsol+0rm91MAYSD4f2Qe
 LVxgfWBMkWj+eLaEBHCoxO+s5wmbZ4WG/QN8KXBzDq3lTkc2nGueDKv3KT0MbedBMbepu26be
 Dr0KLkcpUlLVHs4Y8E2fLPhkM8KyNE5vCLGGJW5uyEw7km0pX/7XZCsz3l0xo7bqtutIcwD1u
 /GEGbmZN8TBGe5R3+68ENQkQgvTTPv6qfjttVVg5G2SnfrpwGJ8ewG2FAlsBG43/+X4zpHkaE
 MX9p91fmephZdWeHAL3vT/G+Q0A=

Hi,

Am 03.01.24 um 13:20 schrieb Francesco Dolcini:
> Hello Pratik,
>
> On Wed, Jan 03, 2024 at 04:32:00PM +0530, pratikmanvar09@gmail.com wrote=
:
>> From: Clark Wang <xiaoning.wang@nxp.com>
>>
>> This fixes the pwm output bug when decrease the duty cycle.
>> This is a limited workaround for the PWM IP issue TKT0577206.
>>
>> Root cause:
>> When the SAR FIFO is empty, the new write value will be directly applie=
d
>> to SAR even the current period is not over.
>> If the new SAR value is less than the old one, and the counter is
>> greater than the new SAR value, the current period will not filp the
>> level. This will result in a pulse with a duty cycle of 100%.
>>
>> Workaround:
>> Add an old value SAR write before updating the new duty cycle to SAR.
>> This will keep the new value is always in a not empty fifo, and can be
>> wait to update after a period finished.
>>
>> Limitation:
>> This workaround can only solve this issue when the PWM period is longer
>> than 2us(or <500KHz).
>>
>> Reviewed-by: Jun Li <jun.li@nxp.com>
>> Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
>> Link: https://github.com/nxp-imx/linux-imx/commit/16181cc4eee61d87cbaba=
0e5a479990507816317
>> Tested-by: Pratik Manvar <pratik.manvar@ifm.com>
>> Signed-off-by: Pratik Manvar <pratik.manvar@ifm.com>
> A very similar patch was already send in 2021 [1], did it had review
> comments not addressed? Please have a look.
>
> In general please refrain from sending a new patch version every other
> day, while every Linux kernel subsystem has different rules and a
> difference pace of development, in this specific case sending a v3 just
> adding your signed-off-by without allowing a little bit of time to wait
> for more feedback is just not sane.
>
> [1] https://lore.kernel.org/all/?q=3Ddfn%3Adrivers%2Fpwm%2Fpwm-imx27.c+A=
ND+b%3A%22Clark+Wang%22
thank you, this is very helpful. Unfortunately i don't have the
knowledge and resources to continue this work.

@Uwe It seems that you were able to reproduce this issue. Is it possible
to trigger this via sysfs and some kind of script?