Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp1075632rdb; Wed, 24 Jan 2024 04:19:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IHLrhwbuQABk+tlv7nzQnK2X8IETd+5s87ovaHM7Sb/F1qeszJNagiWM/bydDyMqMhxFNFe X-Received: by 2002:a05:6358:d5a0:b0:176:5a5e:4d85 with SMTP id ms32-20020a056358d5a000b001765a5e4d85mr4350463rwb.4.1706098757714; Wed, 24 Jan 2024 04:19:17 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706098757; cv=pass; d=google.com; s=arc-20160816; b=t7T/c5s7yq+QQnbL6+qDtSX3ldeiYD5Yd8Ppz3m/XPPdHulusLCd3MAytr+BgOaglS SLMQxmF+IRD+DyFzfyJ+TGN40MvppbZ4ARuN8eVMz7hw+X7j0a25xUtU6rdzRqCrVOHU DV3yrSrZdtPMBut0bvgcTLHNHNvlHBj7NozQGb9Qlp6mrW6fwVbeoBAa8H4MpPOIB40/ 7LFTjzvV78soY+3WPNhEHpzJWIdM0mrEBy4bzgo1zQCfjZGmDkW6pvi7hUVo/c3+TOav Ir0O9qZTFAKdZ4+ffn0Sqz3u9vZ8M4UOmKvxCC+569tDh6cIUmtccKlsvGGy5HrXUPzR GjKA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:in-reply-to:subject:cc:to:date:from :dkim-signature; bh=chxpj87ToMUzBh5CZsrUU1QtyBKI48C+GKuVZZkj7aw=; fh=WvTIauryFkEUmVHsmYOZcJ3FYqsy7mVZD+Crmke1SdM=; b=NG7dvsVUAqSe66oBZvwVBLaQedM938xAgL79SWpaDn5DUFD0Wdl1rfDqFC4dZFwwkT kmfZyixqHditdLnLgrhZR/zjxF+z5DM12shMpX83xlgYcKkq+LeZ5FjeiQIEMkx7slZr AocTej/QIlKSXfztn49/d/6LmKx9y8v8Tgn6poulhSWGkVZEEBqPUktbAzw3JNJn5T9q SjsXyL3wLtTnoPBHYabs5xkJ4Ud+qlw00knt2bces63Kw/jTKYLgtgrwQ47SGrgU/Fpn hjUNoc9vpOfDw//J4Vb9cQ+zVcbQ+RDy+pov+hFxrPgO0d8MHajPWF8M9Mpnx3n+bYec vXZw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=k5rW4pNt; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-36824-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-36824-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id q19-20020aa79833000000b006dd839fed5fsi1926773pfl.232.2024.01.24.04.19.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 04:19:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-36824-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=k5rW4pNt; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-36824-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-36824-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6D39C289897 for ; Wed, 24 Jan 2024 11:01:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AF5BD1AACF; Wed, 24 Jan 2024 11:01:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="k5rW4pNt" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2581F1AAB1; Wed, 24 Jan 2024 11:01:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706094074; cv=none; b=YQhPi3ECj130U99Cm0/eOJezkcyKOmV5opRxtv6sxrt96uosC4wXS+/TjG3FLjoWNvhxlvFfXrgrHnr5wq4SwWcqqJCcSqvk/pnqfkiuaCOP+eZLilMv/Cx8QsI4GjG5xLDte/vWOi9z/2CX2EUgjBKU07U+g9OFLO96A3a+gAc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706094074; c=relaxed/simple; bh=B2qi/Hw43qFMhMK3boYnGYHzXu79gEK/nCZdLkqlPWc=; h=From:Date:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=lQqb6qmDOL3vH6gA7NqO7yTZm0ylahpyfg0KfGd0selTbhAezxjFAifouZnQKAO/t73/Cma/F18PIL3rkFlXRVyNOO+vrWgrPzpKBsJRGZyWtz/ADV7+8bzLvQenz7HJi/peuOCrSsdIpp2F/TLZrfmPZ2eOOG+3yV7NrwB5kMc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=k5rW4pNt; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706094073; x=1737630073; h=from:date:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=B2qi/Hw43qFMhMK3boYnGYHzXu79gEK/nCZdLkqlPWc=; b=k5rW4pNtCJ3a6LkAc+ozKBACTxrUdfRAANWoGZ4+afzTMCUq85Ln7gQc nb/3Vd3pebbd8IC4fzTNwGsCZyEfVrfUrc3NQHIaUSLzZLM7NSgg1iZjj Uc0Ei3vyMUnC6LIGQgkE5VFyWRHSpQI1gsfgl5udLFcWb4fymHIQ/3zQs 6ITmUwABoT9PUVmwBVpKE/p082Gb1uXwcXibyNDJv+4P8k6DT7xGRoMPY e4qdnK1cdIiOJJGfrOtzc/pdsZbfLEqRnOD2r65VafbcASJ6UaKWaDGLM 01QnsLdMn8dN2hofSmak/JoAnE0oqI42LrKTpd3J4HcE+fYKRwkIO5B/E w==; X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="15334630" X-IronPort-AV: E=Sophos;i="6.05,216,1701158400"; d="scan'208";a="15334630" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2024 03:01:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,216,1701158400"; d="scan'208";a="1937235" Received: from ijarvine-desk1.ger.corp.intel.com (HELO localhost) ([10.246.48.46]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2024 03:01:09 -0800 From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Date: Wed, 24 Jan 2024 13:01:05 +0200 (EET) To: Li Zhijian cc: LKML , Hans de Goede , Vadim Pasternak , platform-driver-x86@vger.kernel.org Subject: Re: [PATCH 14/42] drivers/platform/mellanox: Convert snprintf to sysfs_emit In-Reply-To: <20240116045151.3940401-12-lizhijian@fujitsu.com> Message-ID: <1ddc2cc6-1f9c-09c0-acf6-93fa39a10540@linux.intel.com> References: <20240116041129.3937800-1-lizhijian@fujitsu.com> <20240116045151.3940401-1-lizhijian@fujitsu.com> <20240116045151.3940401-12-lizhijian@fujitsu.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 16 Jan 2024, Li Zhijian wrote: > Per filesystems/sysfs.rst, show() should only use sysfs_emit() > or sysfs_emit_at() when formatting the value to be returned to user space. > > coccinelle complains that there are still a couple of functions that use > snprintf(). Convert them to sysfs_emit(). > > > ./drivers/platform/mellanox/mlxbf-bootctl.c:466:8-16: WARNING: please use sysfs_emit > > ./drivers/platform/mellanox/mlxbf-bootctl.c:584:8-16: WARNING: please use sysfs_emit > > ./drivers/platform/mellanox/mlxbf-bootctl.c:635:8-16: WARNING: please use sysfs_emit > > ./drivers/platform/mellanox/mlxbf-bootctl.c:686:8-16: WARNING: please use sysfs_emit > > ./drivers/platform/mellanox/mlxbf-bootctl.c:737:8-16: WARNING: please use sysfs_emit > > ./drivers/platform/mellanox/mlxbf-bootctl.c:788:8-16: WARNING: please use sysfs_emit > > ./drivers/platform/mellanox/mlxbf-bootctl.c:839:8-16: WARNING: please use sysfs_emit > > No functional change intended > > CC: Hans de Goede > CC: ilpo.jarvinen@linux.intel.com > CC: Vadim Pasternak > CC: platform-driver-x86@vger.kernel.org > Signed-off-by: Li Zhijian Applied to pdx86 review-ilpo branch. -- i.