Received-SPF: pass (google.com: domain of linux-kernel+bounces-37087-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 24 Jan 2024 09:09:08 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Borislav Petkov <bp@alien8.de>
Cc: "Naik, Avadhut" <avadnaik@amd.com>, Tony Luck <tony.luck@intel.com>,
 Avadhut Naik <avadhut.naik@amd.com>, linux-trace-kernel@vger.kernel.org,
 linux-edac@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org,
 yazen.ghannam@amd.com
Subject: Re: [PATCH] tracing: Include PPIN in mce_record tracepoint
Message-ID: <20240124090908.1c4daea8@rorschach.local.home>
In-Reply-To: <20240124095708.GAZbDe9Hks0tL2Aj94@fat_crate.local>
References: <20240123235150.3744089-1-avadhut.naik@amd.com>
	<ZbBV4EGrZw6hJ5IE@agluck-desk3>
	<be870e14-eeb9-4dcf-ba43-a72ef66a3d87@amd.com>
	<20240123203853.66655e95@rorschach.local.home>
	<20240124095708.GAZbDe9Hks0tL2Aj94@fat_crate.local>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 24 Jan 2024 10:57:08 +0100
Borislav Petkov <bp@alien8.de> wrote:

> On Tue, Jan 23, 2024 at 08:38:53PM -0500, Steven Rostedt wrote:
> > Yes, rasdaemon uses libtraceevent (or a copy of it internally) that
> > reads the format file to find fields. You can safely add fields to the
> > middle of the event structure and the parsing will be just fine.  
> 
> Should we worry about tools who consume the event "blindly", without the
> lib?

I don't think that's a worry anymore. The offsets can change based on
kernel config. PowerTop needed to have the library ported to it because
it use to hardcode the offsets but then it broke when running the 32bit
version on a 64bit kernel.

> 
> I guess no until we break some use case and then we will have to revert.
> At least this is what we've done in the past...
> 

But that revert was reverted when we converted PowerTop to use libtraceevent.

-- Steve