Received-SPF: pass (google.com: domain of linux-kernel+bounces-37098-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 24 Jan 2024 06:17:27 -0800
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Prashant Malani <pmalani@chromium.org>,
	Abhishek Pandit-Subedi <abhishekpandit@google.com>,
	linux-usb@vger.kernel.org, jthies@google.com,
	Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Saranya Gopal <saranya.gopal@intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/3] usb: typec: ucsi: Limit read size on v1.2
Message-ID: <2024012405-stung-freckles-e196@gregkh>
References: <20240123223039.1471557-1-abhishekpandit@google.com>
 <20240123143026.v1.1.Iacf5570a66b82b73ef03daa6557e2fc0db10266a@changeid>
 <CACeCKaftJSGba3ebs58=cB5aRLuOnbvhQX2V6+5=t9GPC08_Uw@mail.gmail.com>
 <ZbEV/qp/EhUkHVhA@kuha.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ZbEV/qp/EhUkHVhA@kuha.fi.intel.com>

On Wed, Jan 24, 2024 at 03:51:58PM +0200, Heikki Krogerus wrote:
> On Wed, Jan 24, 2024 at 12:12:26AM -0800, Prashant Malani wrote:
> > Hi Abhishek,
> > 
> > On Tue, Jan 23, 2024 at 2:30 PM Abhishek Pandit-Subedi
> > <abhishekpandit@google.com> wrote:
> > >
> > > From: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
> > >
> > > Between UCSI 1.2 and UCSI 2.0, the size of the MESSAGE_IN region was
> > > increased from 16 to 256. In order to avoid overflowing reads for older
> > > systems, add a mechanism to use the read UCSI version to truncate read
> > > sizes on UCSI v1.2.
> > >
> > > Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
> > I have one nit (mentioned in side-band but reproducing here for consistency),
> > but will defer to the maintainer on that.
> > 
> > The above notwithstanding, FWIW:
> > Reviewed-by: Prashant Malani<pmalani@chromium.org>
> > 
> > > @@ -1556,6 +1569,15 @@ int ucsi_register(struct ucsi *ucsi)
> > >         if (!ucsi->version)
> > >                 return -ENODEV;
> > >
> > > +       /*
> > > +        * Version format is JJ.M.N (JJ = Major version, M = Minor version,
> > > +        * N = sub-minor version).
> > > +        */
> > > +       dev_info(ucsi->dev, "Registered UCSI interface with version %x.%x.%x",
> > > +                UCSI_BCD_GET_MAJOR(ucsi->version),
> > > +                UCSI_BCD_GET_MINOR(ucsi->version),
> > > +                UCSI_BCD_GET_SUBMINOR(ucsi->version));
> > 
> > nit: I think this doesn't need to be dev_info() and can be just
> > dev_dbg(), but will
> > defer to the maintainer.
> 
> I think that's okay.
> 
> Reviewewd-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

No, when drivers are working properly they are quiet, this needs to be
dev_dbg().

thanks,

greg k-h