Received-SPF: pass (google.com: domain of linux-kernel+bounces-37113-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: John Garry <john.g.garry@oracle.com>
To: hch@lst.de, djwong@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org,
        dchinner@redhat.com, jack@suse.cz, chandan.babu@oracle.com
Cc: martin.petersen@oracle.com, linux-kernel@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        tytso@mit.edu, jbongio@google.com, ojaswin@linux.ibm.com,
        John Garry <john.g.garry@oracle.com>
Subject: [PATCH RFC 5/6] fs: xfs: iomap atomic write support
Date: Wed, 24 Jan 2024 14:26:44 +0000
Message-Id: <20240124142645.9334-6-john.g.garry@oracle.com>
In-Reply-To: <20240124142645.9334-1-john.g.garry@oracle.com>
References: <20240124142645.9334-1-john.g.garry@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?YiKjV+DxWnm3HB26zQ/5g2y2p7qhufYsiDRX1QUjV8xVyADocDNqAanJ3JS0?=
 =?us-ascii?Q?3A6zVuENHvo/WNriKOUskXclZJR9im2wq9Iser0I/lcnIka1uO/0wTfIppKS?=
 =?us-ascii?Q?1QQJ82V8ss2e1CD8nyl8fZoQUR9eZBRN5lLB6jnWT1lVhYKe+iL954PBgLsm?=
 =?us-ascii?Q?c/w6+LYhYOXc4OAkJ/b5uuf2osaBmkZg+4mUIaVTeteHV12RenLOWW72C1tp?=
 =?us-ascii?Q?meBJDn5qiyxp2wil/FqxfIVpMH1fRiZCqK2dnFyIeapjeIoiVi67yUWB+JQU?=
 =?us-ascii?Q?cl2PbwdWnDK9ewzkCmT90mZFz/3aom5sHOeXolExPDm8JbAek/63glmfQDfC?=
 =?us-ascii?Q?QnEPdskhwPRL0JX8OCyglUki34EPa1EwFT6lxffI5Ds4Q3G32e+ymg6n9ZeJ?=
 =?us-ascii?Q?7I/FxUrRIv4YhCptOgPoT6YNxUsoEhqFBDYKowe2vNtknExwcfgwmnPEWnUl?=
 =?us-ascii?Q?my7O/mO3DLbT+FoDzo1xokaCZEU8JN8d+O0F8BTJbbKT8YkPpwg2SmWGIk/l?=
 =?us-ascii?Q?4R+zcP/Tob5fBvLmGYJRuyuq+BwsqZlwwViVCLirf0P6Uhym1to+yA+l6jn1?=
 =?us-ascii?Q?/x8T9whl3e1huj30F9iWu8xE60IRj2VzxWZrifQhUTHEVGR0s3qS8zM+Aoxb?=
 =?us-ascii?Q?BKMHsiHrFUyfKGxNfC6x7puD+TaKgXIIb/+5WDigV6wste4EfDNxQ28Yvp8x?=
 =?us-ascii?Q?PgukZ3EgzoDLtr30cmaNCoVgzr8Bu1FEhCoh7JwBBFE7pEr8OPUqd3tHFH8i?=
 =?us-ascii?Q?aywejjNHtJxVwlCFKpx2C71W4tb0Q5lTKwxCYr7qJ/1ndMTYGYw06Vje1rye?=
 =?us-ascii?Q?K4QxoXHVQK4KLtrA0N1/vWw/B39tgWspg+meMRhlAnLWA82LdWi7VkndLPAP?=
 =?us-ascii?Q?CLVBEns23xUWjo0D9IxlN3udEQrIhkeJ1YFkS1mEDT2SahOlgkVvtaV15CD/?=
 =?us-ascii?Q?btLILX9SntuZ4MKy4PL+RED7uEGFKql6WCnr8YobrVdoiqLzVAs7kAls5X1x?=
 =?us-ascii?Q?zLA4o9g8llZaMKAIB+DDwUeMo5e7+CejwU2z7znUHc6dND4lK3yb1XH73PsS?=
 =?us-ascii?Q?YL0gnHv4/d1HjZlhdyaMKRZzRhCk1/r30dOzMM12RD25szQ5hvl0h99r5gJa?=
 =?us-ascii?Q?BKirIpffQ8dOdHVEPgUES9YG5HS4/VH9k1v1dRSsfgqDQKZWPl47ePmom8VC?=
 =?us-ascii?Q?i8f1ENCo5VxKzp/LErAJb6bztwM5OLWUP2Jpg5iBnH+zbEhTnNj6r+UleUwh?=
 =?us-ascii?Q?TmwcDWiQPwPbg8P8xbRpVOb6YhHNQcqALoNCMbbDpxugZsU7aVj1iSvFlcHs?=
 =?us-ascii?Q?/mW29N6FTzossEcb4ef7x3iOg5G8FjcMfOrZm/pASPCWglRPX6J43YlYhQi7?=
 =?us-ascii?Q?L4Bi1qBqYpG68dbXygCCH92q4Mcfb7leXOs/651ZOtj+glyfAYLcNq6y7cfq?=
 =?us-ascii?Q?mxWThnepWM+WruGVVy3vAGeflpH3l3AYhXMUe3lNRftv1qQD15tPVmi1R6kU?=
 =?us-ascii?Q?AmU1BMlmxab14QaSgYpYTvomNQIBpwSETh5kQPBUuIh+6X5g5QuC73CPOEh3?=
 =?us-ascii?Q?QZhNlJSoReL63OlNtFxhCIzS7cX14yoZ3Cg3XDYEITV935TQbgT8OxblFnfa?=
 =?us-ascii?Q?Ww=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	FC87AnVVvg0QI3ci/T8MlFUni6Z33HPtaVgKgDeGq1vXfoaNNkZqwIFdQfCZCmaVX1D/l3SGHPDPmbglUd7JJHq+wgm8oqYk2lvDj8DnNa1hiARnFNvcoxmGNCFV4k6uV3tw/hbF1TkMU1KUcECuIQP6vzXeLtRcCmrqwYPUq5nBGA9kxk5BIAZnFcOfVb/71jyGSa/qAcAt5aza/zYa6+dJycEnERvVZVwfLwHEP+MntdtHK2J2SLvsYf5Qe0wIfR14RhZ2cmXd7WlHGUbUh6IugyeyhCY9PzGqpxLGrLpO4tE7pKzSTYhh8XnmBSQs6YkaKmT9azuoMLq6yzjw4XpMZxJqQAolEl2VSacrFjYeS37FobG4yljJNBgk4NP8ua3t8EwVT8eZ0sQ55Wmvd0uiTLOr+5w2CeUkvdsk+2Q6DoQKughELoXWzqD5ljUvyNDuiFXSTzgVldpopbSSyDMF18XKRjIgr8r6sKJ6ji8yDH9luSdDAXerv1sxprtYWkm15/6GXsTFtdNAfsMjMh/x18rHg+uqVPSG9jxD/hm2WVI9rpiZaVA1XSm1xv3TIQ36B0n/A/iA+kjS4pXHLGIlJENAh8gpdBQYWHu1CjE=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 94beaeed-c5a6-4a75-7654-08dc1ce88b6b
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2024 14:27:07.8208
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GSjNsDakt4NAdGvTwN2p53jDzpFGYupFhIRDodDBlymkE7z5wgMxDir82myIZmdjpskVjpH4um5qWkk1zDu+nQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5212
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-24_06,2024-01-24_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0
 mlxlogscore=999 mlxscore=0 phishscore=0 adultscore=0 spamscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2401240104
X-Proofpoint-ORIG-GUID: EFokGYJGqSYivndvNp0L5eCPc9XTTs6I
X-Proofpoint-GUID: EFokGYJGqSYivndvNp0L5eCPc9XTTs6I

Ensure that when creating a mapping that we adhere to all the atomic
write rules.

We check that the mapping covers the complete range of the write to ensure
that we'll be just creating a single mapping.

Currently minimum granularity is the FS block size, but it should be
possibly to support lower in future.

Signed-off-by: John Garry <john.g.garry@oracle.com>
---
I am setting this as an RFC as I am not sure on the change in
xfs_iomap_write_direct() - it gives the desired result AFAICS.

 fs/xfs/xfs_iomap.c | 41 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c
index 18c8f168b153..758dc1c90a42 100644
--- a/fs/xfs/xfs_iomap.c
+++ b/fs/xfs/xfs_iomap.c
@@ -289,6 +289,9 @@ xfs_iomap_write_direct(
 		}
 	}
 
+	if (xfs_inode_atomicwrites(ip))
+		bmapi_flags = XFS_BMAPI_ZERO;
+
 	error = xfs_trans_alloc_inode(ip, &M_RES(mp)->tr_write, dblocks,
 			rblocks, force, &tp);
 	if (error)
@@ -812,6 +815,44 @@ xfs_direct_write_iomap_begin(
 	if (error)
 		goto out_unlock;
 
+	if (flags & IOMAP_ATOMIC) {
+		xfs_filblks_t unit_min_fsb, unit_max_fsb;
+		unsigned int unit_min, unit_max;
+
+		xfs_get_atomic_write_attr(ip, &unit_min, &unit_max);
+		unit_min_fsb = XFS_B_TO_FSBT(mp, unit_min);
+		unit_max_fsb = XFS_B_TO_FSBT(mp, unit_max);
+
+		if (!imap_spans_range(&imap, offset_fsb, end_fsb)) {
+			error = -EINVAL;
+			goto out_unlock;
+		}
+
+		if ((offset & mp->m_blockmask) ||
+		    (length & mp->m_blockmask)) {
+			error = -EINVAL;
+			goto out_unlock;
+		}
+
+		if (imap.br_blockcount == unit_min_fsb ||
+		    imap.br_blockcount == unit_max_fsb) {
+			/* ok if exactly min or max */
+		} else if (imap.br_blockcount < unit_min_fsb ||
+			   imap.br_blockcount > unit_max_fsb) {
+			error = -EINVAL;
+			goto out_unlock;
+		} else if (!is_power_of_2(imap.br_blockcount)) {
+			error = -EINVAL;
+			goto out_unlock;
+		}
+
+		if (imap.br_startoff &&
+		    imap.br_startoff & (imap.br_blockcount - 1)) {
+			error = -EINVAL;
+			goto out_unlock;
+		}
+	}
+
 	if (imap_needs_cow(ip, flags, &imap, nimaps)) {
 		error = -EAGAIN;
 		if (flags & IOMAP_NOWAIT)
-- 
2.31.1