Received-SPF: pass (google.com: domain of linux-kernel+bounces-37152-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: John Garry <john.g.garry@oracle.com>
To: hch@lst.de, djwong@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org,
        dchinner@redhat.com, jack@suse.cz, chandan.babu@oracle.com
Cc: martin.petersen@oracle.com, linux-kernel@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        tytso@mit.edu, jbongio@google.com, ojaswin@linux.ibm.com,
        John Garry <john.g.garry@oracle.com>
Subject: [PATCH 4/6] fs: xfs: Support atomic write for statx
Date: Wed, 24 Jan 2024 14:26:43 +0000
Message-Id: <20240124142645.9334-5-john.g.garry@oracle.com>
In-Reply-To: <20240124142645.9334-1-john.g.garry@oracle.com>
References: <20240124142645.9334-1-john.g.garry@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?Db3mglmNsBzfRh5Xd9bM2TZ5p5gutRT9WtENBUoACiFPnJNG5SdGUSsWULa+?=
 =?us-ascii?Q?sIphUy0JXVCR49j+Ej20yfueQDxGejchP+cyQ+Jl8RP7VZdymQOUmRjIvxV1?=
 =?us-ascii?Q?lF4A+SxxFK/ZweOuRMMERTh0UpArtqJYPLYGAynOBiDz+1uUKesdZd+pa6hn?=
 =?us-ascii?Q?dD4OIbidOH+OFPz744vk6i+13QaNk8SfgVK8NYm82Bdw1pHw1ygYd/m21zkM?=
 =?us-ascii?Q?ejP8gmruAWhAjI/D9Cq6qcLfHiJCEpnka94cxFKo0Tna6z6j1blyPsI+n40M?=
 =?us-ascii?Q?upJYV6RNTk/JneR1S+EX+AyCNR6APXZKry/upsxtVMS4pvHC2V8uopkreqs+?=
 =?us-ascii?Q?3BF/ropPKjm5z4McwhLGyps7I33ETTE05AxWvizzSFY+TDVcf29Iq/owudZh?=
 =?us-ascii?Q?yNKZ/pQypUcHYDB+Qk8opDp5/4LP0fLZwmYHXIx31ycRpgYCvvjFw5UQeW4T?=
 =?us-ascii?Q?p/fb3cC4vsChtz0o6R3COSXJrxFz+eHV1ctEQ5VJyS8OWHUcIZFSu5z/mABM?=
 =?us-ascii?Q?qA6ht6Qs6Z7DYfsLHwsYNwz/hYueswfAEaIzq8w5ag1cg9MU2DIKj/Q3wCON?=
 =?us-ascii?Q?vmotB9+rGx6oMc0BXASNBy7S3e8OAiDy90UTVcs95bKFS8wv3y/D8exzC5mu?=
 =?us-ascii?Q?qZrVcLv5JD/Aq4iRQqrpwucjRdYS/W4Bpyqw5aaa/UbmIwwXR8GQQcec/OS9?=
 =?us-ascii?Q?F9ajmV19cpaSLkNg0X7oS4zn3SL3fotrQjPRgB4oR2p58mJ/fr8UHrP5Uset?=
 =?us-ascii?Q?1ZeDf+x2bKhz4mAgsEmJDudATAi+2fVnGa30uLmajx1t8p0HfQwPrpEGX9UU?=
 =?us-ascii?Q?FcQOp54k/NjHAXcVwv957XtfI6TUqBfDv5NQ6sHxFfuDvejA0oG5MSM/Trvz?=
 =?us-ascii?Q?akyzZBTeBIB6ARjW7W7wVr9U9Ahmb+/mtothf/QLf7WNnHwUTvt2yef4+Z3m?=
 =?us-ascii?Q?DsxwwONDtBHSsCoGETJR7xpnzL9Odr+RVBPnTFre6GqKLZ8Z0tPhIz0PAdKy?=
 =?us-ascii?Q?7xHaJw6OI7TN/FD+pza4rPxEYjR+AhwaWGzpT8QodYuyvSqGzG8F+pPw6XjK?=
 =?us-ascii?Q?zIkFEePUAUCeGujcfwqqiVS2JCWv6/YzZyzO+0hgOUquix1gI/FXjMBHuAwL?=
 =?us-ascii?Q?t7USY3Hk3zCiauDskklig/5Y+qrfSM8vZk/5qWXOzy+NKScBxnFM2ytalIp4?=
 =?us-ascii?Q?0LmYWD7o57B9SD2Ur3EI7UpPtC5YBgYVtvNIWjNVCmeRhNJK2p326g9jWlhp?=
 =?us-ascii?Q?tAr52NgvA1EQu7otl0h/YKe0pwedp+tYYdzl0YsA+mcWU+TgLFioNPobOFPs?=
 =?us-ascii?Q?S2FPpPq9zTLi4KkXKa70K/14I78+bxV7uvgO1+7SiAKxjxUF8VVpWL2A2W2x?=
 =?us-ascii?Q?3QmIutEgcX+BYlOm98V+f8ZOTy63Vxept9caZrUAaa5tgCi4AkArDdzQkKNr?=
 =?us-ascii?Q?nAo0cUZRi054CLMVA51sIzWtBwSutq85m/3d9LhRkAsVvCrCt5EAN+Q3ss09?=
 =?us-ascii?Q?oTJrn4GU2+zso3wRFWFjV/NLzp/mPuYpjIQPYc79IKuNBSvoEXgc8yRgYVnx?=
 =?us-ascii?Q?lYSvTzKK5hsqdQ7u5xeHPdFDV+4UdmNhEjT5S8sdU//Mlk06hIV/OrIM4xv+?=
 =?us-ascii?Q?Zw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	cKQ8eNxPFdGNojtFlIkpkO81PVDoKFx6aOTkJYEhP8qWh1BlQG8Y2Fhfth2hDOTkbuFH1pV3kA/yigasNhxjMyhxYrB9ztcclCvwCuT69yqFKb4/Hl7tBEgQNm89IaVB/E7o/LhQ2Fbt6PR26dlLra6HFJqHn9OtjDdDo9tvOuPvRhnpDlBjG2MtZpumF/HlZs9PNztLqmOTolVVZc6lGKTeayyYfdsNDUh0GoHIFUExa9GC4mqSSnNDzRBTD8fanmsaKk3gsVYPjkZTbvY0XUpdyUBTNJPhFI9vL9yl4UJYATCmiva8OqRA/k2/dtaayLXG5/VhxDz/mmT7ioFZFkMMKOzhZYLkn1Apnjjg1D2VnBNwQbexmGyPMmL4RYM/UOm0NgtrnOhneVDhA5B5e3rNM2/lW00sIB246+A16scPiA24GiaV06DC4bdUCF+ATsKDa/KGCScQyVzDk1nBlFWjNB6WAg1vh8vqRqfnUqjOL+bNLkMgVTpWoQyFfNK1D7TQy0EHMhCuU2kkC9mHa27nr6Ui/PxleV17A36oLH7fP9JJx47Kv2x54aIgVcwGLOSOhkvGyRqUl4a4U9KHfyKzKaoaBXoyqBhhoG4YoQ4=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 04e855d2-7705-4a97-37ce-08dc1ce88ad7
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2024 14:27:06.8222
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b5GtSfaAOxiZ7/pK2ts21e1W+cWKJXdXmlL2+EL/cSP3e2ZC3Xp64xX30bJyTuh21m18py19epRtAzoK8dxAcw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5212
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-24_06,2024-01-24_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0
 mlxlogscore=999 mlxscore=0 phishscore=0 adultscore=0 spamscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2401240104
X-Proofpoint-ORIG-GUID: MRuRMQem1csCBN-TI7MUrlZwme2dHj76
X-Proofpoint-GUID: MRuRMQem1csCBN-TI7MUrlZwme2dHj76

Support providing info on atomic write unit min and max for an inode.

For simplicity, currently we limit the min at the FS block size, but a
lower limit could be supported in future.

The atomic write unit min and max is limited by the guaranteed extent
alignment for the inode.

Signed-off-by: John Garry <john.g.garry@oracle.com>
---
 fs/xfs/xfs_iops.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
 fs/xfs/xfs_iops.h |  4 ++++
 2 files changed, 49 insertions(+)

diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
index a0d77f5f512e..0890d2f70f4d 100644
--- a/fs/xfs/xfs_iops.c
+++ b/fs/xfs/xfs_iops.c
@@ -546,6 +546,44 @@ xfs_stat_blksize(
 	return PAGE_SIZE;
 }
 
+void xfs_get_atomic_write_attr(
+	struct xfs_inode *ip,
+	unsigned int *unit_min,
+	unsigned int *unit_max)
+{
+	xfs_extlen_t		extsz = xfs_get_extsz(ip);
+	struct xfs_buftarg	*target = xfs_inode_buftarg(ip);
+	struct block_device	*bdev = target->bt_bdev;
+	unsigned int		awu_min, awu_max, align;
+	struct request_queue	*q = bdev->bd_queue;
+	struct xfs_mount	*mp = ip->i_mount;
+
+	/*
+	 * Convert to multiples of the BLOCKSIZE (as we support a minimum
+	 * atomic write unit of BLOCKSIZE).
+	 */
+	awu_min = queue_atomic_write_unit_min_bytes(q);
+	awu_max = queue_atomic_write_unit_max_bytes(q);
+
+	awu_min &= ~mp->m_blockmask;
+	awu_max &= ~mp->m_blockmask;
+
+	align = XFS_FSB_TO_B(mp, extsz);
+
+	if (!awu_max || !xfs_inode_atomicwrites(ip) || !align ||
+	    !is_power_of_2(align)) {
+		*unit_min = 0;
+		*unit_max = 0;
+	} else {
+		if (awu_min)
+			*unit_min = min(awu_min, align);
+		else
+			*unit_min = mp->m_sb.sb_blocksize;
+
+		*unit_max = min(awu_max, align);
+	}
+}
+
 STATIC int
 xfs_vn_getattr(
 	struct mnt_idmap	*idmap,
@@ -619,6 +657,13 @@ xfs_vn_getattr(
 			stat->dio_mem_align = bdev_dma_alignment(bdev) + 1;
 			stat->dio_offset_align = bdev_logical_block_size(bdev);
 		}
+		if (request_mask & STATX_WRITE_ATOMIC) {
+			unsigned int unit_min, unit_max;
+
+			xfs_get_atomic_write_attr(ip, &unit_min, &unit_max);
+			generic_fill_statx_atomic_writes(stat,
+				unit_min, unit_max);
+		}
 		fallthrough;
 	default:
 		stat->blksize = xfs_stat_blksize(ip);
diff --git a/fs/xfs/xfs_iops.h b/fs/xfs/xfs_iops.h
index 7f84a0843b24..76dd4c3687aa 100644
--- a/fs/xfs/xfs_iops.h
+++ b/fs/xfs/xfs_iops.h
@@ -19,4 +19,8 @@ int xfs_vn_setattr_size(struct mnt_idmap *idmap,
 int xfs_inode_init_security(struct inode *inode, struct inode *dir,
 		const struct qstr *qstr);
 
+void xfs_get_atomic_write_attr(struct xfs_inode *ip,
+		unsigned int *unit_min,
+		unsigned int *unit_max);
+
 #endif /* __XFS_IOPS_H__ */
-- 
2.31.1