Received-SPF: pass (google.com: domain of linux-kernel+bounces-37211-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 24 Jan 2024 14:59:28 +0000
From: Mark Brown <broonie@kernel.org>
To: Jonas Gorski <jonas.gorski@gmail.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Herve Codina <herve.codina@bootlin.com>,
	Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>,
	"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH] spi: Raise limit on number of chip selects
Message-ID: <38630519-733c-4598-97a7-19a5e6306513@sirena.org.uk>
References: <20240122-spi-multi-cs-max-v1-1-a7e98cd5f6c7@kernel.org>
 <20240123120430.75c7ace0@bootlin.com>
 <cefafa30-b78d-471b-83e0-b05060d806d4@sirena.org.uk>
 <93385fc2-7596-4f66-b0c1-07d7d5c9ed8d@csgroup.eu>
 <49b52941-6205-48bd-b2ae-e334018ac5cd@sirena.org.uk>
 <CAOiHx==FzSyyqP3NzLTeOSVxUQYy3ZhypZrDLsc-OjGCdSzvUA@mail.gmail.com>
 <801eecbe-4bf9-4bb8-9de0-1a7ca6673ddf@roeck-us.net>
 <CAOiHx=mM7kpzR-MOshsgXZM+CSB0nawfWxMhpt=tuhmJyMTCzQ@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="U3up3TFtYv/V8tb0"
Content-Disposition: inline
In-Reply-To: <CAOiHx=mM7kpzR-MOshsgXZM+CSB0nawfWxMhpt=tuhmJyMTCzQ@mail.gmail.com>


--U3up3TFtYv/V8tb0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jan 24, 2024 at 02:41:03PM +0100, Jonas Gorski wrote:

> For some reason we don't store neither the actual number of supported
> parallel chipselects in the controller, nor the amount of chipselects
> used by the spi device, so all loops always  need to iterate
> SPI_CS_CNT_MAX times and check for the chipselect numbers not being
> 0xff instead of limiting by the (possible to know) actual number of
> chip selects in use.

Yes, we really can do a lot better here if we keep a bit more data
around.

--U3up3TFtYv/V8tb0
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmWxJc8ACgkQJNaLcl1U
h9D6LAf/dKoXrvJDfpSrT4W9m+K05QQbrpK+vBrXnoQfnSRPB6PhUHDrgZEHfOHC
2gewO4lWzvu974wpl2oilNc6y68hYT7Vhxw/PuYg7ML+SO3pnhoTvEYqwaaz11+o
TTf+2VlXzjHRHtB4vKZDV3DtNhZZ/keiVIXeNmSkr6e3zBnQoAOZIfBe/+i6cDoS
aF03gP7NzVqJgQ142eWIQfp5BdHqw31p0nKeNrY/mzHCif2F7Qdv4o2Vrfmary90
/mcrWWxf05lsckAp2A4JHZeSWgQxw0LXt96q4CQfq71CHcn4E9xtYbXbW17JJZUt
Kw+M0M793MlQUjjgskoPo+jXC+M4gw==
=M4HS
-----END PGP SIGNATURE-----

--U3up3TFtYv/V8tb0--