Received-SPF: pass (google.com: domain of linux-kernel+bounces-37241-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 24 Jan 2024 08:22:41 -0700
From: Keith Busch <kbusch@kernel.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Christian Brauner <brauner@kernel.org>
Subject: Re: [PATCH v2] iov_iter: streamline iovec/bvec alignment iteration
Message-ID: <ZbErQX4Z1pD0aa_5@kbusch-mbp.dhcp.thefacebook.com>
References: <544b31f7-6d4b-42f5-a544-1420501f081f@kernel.dk>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <544b31f7-6d4b-42f5-a544-1420501f081f@kernel.dk>

On Tue, Jan 23, 2024 at 03:24:46PM -0700, Jens Axboe wrote:
> Rewrite the alignment checking iterators for iovec and bvec to be easier
> to read, and also significantly more compact in terms of generated code.
> This saves 270 bytes of text on x86-64 for me (with clang-18) and 224
> bytes on arm64 (with gcc-13).
> 
> In profiles, also saves a bit of time as well for the same workload:
> 
>      0.81%     -0.18%  [kernel.vmlinux]  [k] iov_iter_aligned_bvec
>      0.48%     -0.09%  [kernel.vmlinux]  [k] iov_iter_is_aligned
> 
> which is a nice side benefit as well.

Looks good

Reviewed-by: Keith Busch <kbusch@kernel.org>