Received-SPF: pass (google.com: domain of linux-kernel+bounces-37244-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <be69e0a6-fdc8-c24b-9beb-adaac4a97776@quicinc.com>
Date: Wed, 24 Jan 2024 20:55:26 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH] thermal/drivers/tsens: Add suspend to RAM support for
 tsens
Content-Language: en-US
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
        Amit Kucheria
	<amitk@kernel.org>,
        Thara Gopinath <thara.gopinath@gmail.com>,
        "Bjorn
 Andersson" <andersson@kernel.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Zhang Rui <rui.zhang@intel.com>, Lukasz Luba <lukasz.luba@arm.com>,
        <linux-pm@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
CC: <quic_manafm@quicinc.com>
References: <20240122100726.16993-1-quic_priyjain@quicinc.com>
 <548e2f24-a51e-4593-9463-09506488c70e@linaro.org>
 <f415a8cd-4cae-d7c3-60fc-674b3e660f6b@quicinc.com>
 <aeae2e69-8407-4d90-9d16-27798e2f3248@linaro.org>
From: Priyansh Jain <quic_priyjain@quicinc.com>
In-Reply-To: <aeae2e69-8407-4d90-9d16-27798e2f3248@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 1/24/2024 6:04 PM, Konrad Dybcio wrote:
> 
> 
> On 1/24/24 11:42, Priyansh Jain wrote:
>>
>>
>> On 1/22/2024 8:02 PM, Konrad Dybcio wrote:
>>> On 22.01.2024 11:07, Priyansh Jain wrote:
>>>> Add suspend callback support for tsens which disables tsens interrupts
>>>> in suspend to RAM callback.
>>>
>>> Would it not be preferrable to have the "critical overheat", wakeup-
>>> capable interrupts be enabled, even if the system is suspended?
>>>
>>
>>
>> As part of suspend to RAM, tsens hardware will be turned off and it 
>> cannot generate any interrupt.Also system doesn't want to abort 
>> suspend to RAM due to tsens interrupts since system is already going 
>> into lowest
>> power state. Hence disabling tsens interrupt during suspend to RAM 
>> callback.
> 
> Is that a hardware limitation, or a software design choice? I'm not
> sure I want my phone to have thermal notifications disabled when
> it's suspended.

> Konrad

As part of suspend to RAM , entire SOC will be off, this mode (suspend 
to RAM) is not intended for Mobile product. Tsens interrupts are not
disabled as part of suspend to idle(suspend mode for mobile).

Regards,
Priyansh