Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp1200440rdb; Wed, 24 Jan 2024 07:46:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IGG2UeryBFF6lYZkhUOd8Z+C0DQrmk2nSVKrtf4DMcpp23ddP0Gp5bhlZUO79H5ymlxf13y X-Received: by 2002:a05:6e02:13d0:b0:35d:58ce:2322 with SMTP id v16-20020a056e0213d000b0035d58ce2322mr1608337ilj.5.1706111195115; Wed, 24 Jan 2024 07:46:35 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706111195; cv=pass; d=google.com; s=arc-20160816; b=eOV7IGgklx9U/NfFiNwrdS+w9+AeK6uDm8fXKNVKDoz20TRC3oC9EvfFGQ0BBLmi9j ZeKeoSaWUC6R2yOExqftzZTDaV9EgTt4D13vAng9diS1vznF5I2WWYOu9Gy/n+lngWuv /yL5PhVMclB0XiWoeYQapNzxMPGG+2+/C4YbsBH6jWdLR3Sv5BmU0xBA6Qj+RXE2Wct8 IM55FKgRiOsDn29k8yW9/zhjwF0ceDmJQwaUzv+fXkz7o31VNlPhPsCAAdi/J/Xm8VCd 0S3V9768bjEt51dwIm6VS1ALwGaKi+3Io8M63nqVHSaGcgH6VC4hOFXlXE6ej5OcheVY LADg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=iHZx0EQQWLTnQ6gw0QMnvE6FHPtKQlTbYsgwXD+1HSk=; fh=qpbXnGz1O7RFUwOC08Xis9q55F7PMtVikDnZtr43OpU=; b=PDofVNgr7ETcVCFToH5lkboDzOiIuNm70iKXu9xnnw2z9oHe148wEN6D3S4+EU9mGY bavE1kgz/3AeHTVWioVunWYpYweQ5GRpF3GytxhWmqryFN8ybDXsrTTKdQv2rB63afAh 5m2Y3u7of6onoOuCD7dZ+Tah91d8aHIK5xuGFdilAlicbWERTcv44WttOlVbH6kAtdB/ AsMu+5U8v5lBgWGuy5sqiiQ9jV86HrJ+L0yYwu05m41umPFqeNHYD7X6IDMMKvCtYRat LIyjoMLTLqegZ4I06UyDNAG/cTfj9xE+NBil+tNuXcFAXvSAq2mkqHaRuZMtmrASWorY fRMg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BSbIBw3k; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-37232-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-37232-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id k29-20020a634b5d000000b005d4859419dfsi1759527pgl.267.2024.01.24.07.46.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 07:46:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-37232-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BSbIBw3k; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-37232-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-37232-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 68E19B2DC85 for ; Wed, 24 Jan 2024 15:15:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3CD0F7C09A; Wed, 24 Jan 2024 15:14:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BSbIBw3k" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49B537C084; Wed, 24 Jan 2024 15:14:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706109248; cv=none; b=k8a0RjLgtmxsSPp8dA1v/wBfHVQYsuHSMbptWXYtuuTybstNCoJ3of09BjGu7kqcyC+58KHTSGQDDsNJojE8sATHEMT3btMsNHgT1D6TxzDY8WE+RByZKIwDY+CRmgqcaDSwqu0h+O39JhwUTpPtWYOHe15yeMCbzCTSJZ7e2nI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706109248; c=relaxed/simple; bh=lvaCYClRxgNlHDnQz/s2U/iDr+6UL1dxY0a0fQAXT9Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ruty46cPGCqtzm7E1J+mfaAsJSjLUdVIDr0HF5ICcQUfrhSmcjR9JBeN/DATREaeKRK7tAQkaK7zh7Bd8wdFaui4YzlLEDswNFvohM4bbVsbkDsTGgzGEAq2WgixK12G3XGBiDh+MMrFKvrC/y1N32d0LqJyhj3RPO0d5VIGIvs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BSbIBw3k; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA801C433F1; Wed, 24 Jan 2024 15:14:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706109247; bh=lvaCYClRxgNlHDnQz/s2U/iDr+6UL1dxY0a0fQAXT9Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BSbIBw3kzo6Z8y3CldCjPlFmJVXs4DfMbWMk3BxWhtiC21cqBvVecnukro17HgBrs e36bl6Zfrb4/KDy2qO2+Jx66ggkv3gYrOPH41fzQy3mI6pB1wPvoUby1N8qtQ2R8p0 vnVIITD7LaLjGqEB0vYBBWgYM/yWh8SlBpNemWv0R5FgMtEZVyJy02ZlkVbCz3OciX nXiNbMAOchaWY3hZa2GKgHqhJ9cki/IAjjSHiZ3ikM5Z4DFDp/7Gi7X+wJQKx2r4iX COSSi8LHQIxBiP6s+3ug52+TnzlabTiuj7oArgdMpgKWgRtINniqN8+5UvzZhFKvA9 StXpbBIN+R/9Q== Date: Wed, 24 Jan 2024 09:14:05 -0600 From: Rob Herring To: =?iso-8859-1?Q?Th=E9o?= Lebrun Cc: Gregory CLEMENT , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , Linus Walleij , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Philipp Zabel , Vladimir Kondratiev , linux-mips@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni , Tawfik Bayouk , linux-gpio@vger.kernel.org Subject: Re: [PATCH v3 04/17] dt-bindings: soc: mobileye: add EyeQ5 OLB system controller Message-ID: <20240124151405.GA930997-robh@kernel.org> References: <20240123-mbly-clk-v3-0-392b010b8281@bootlin.com> <20240123-mbly-clk-v3-4-392b010b8281@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240123-mbly-clk-v3-4-392b010b8281@bootlin.com> On Tue, Jan 23, 2024 at 07:46:49PM +0100, Th?o Lebrun wrote: > Add documentation to describe the "Other Logic Block" syscon. > > Signed-off-by: Th?o Lebrun > --- > .../bindings/soc/mobileye/mobileye,eyeq5-olb.yaml | 77 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 78 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml b/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml > new file mode 100644 > index 000000000000..031ef6a532c1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml > @@ -0,0 +1,77 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/mobileye/mobileye,eyeq5-olb.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mobileye EyeQ5 SoC system controller > + > +maintainers: > + - Gr?gory Clement > + - Th?o Lebrun > + - Vladimir Kondratiev > + > +description: > + OLB ("Other Logic Block") is a hardware block grouping smaller blocks. Clocks, > + resets, pinctrl are being handled from here. > + > +properties: > + compatible: > + items: > + - const: mobileye,eyeq5-olb > + - const: syscon > + - const: simple-mfd > + > + reg: > + maxItems: 1 > + > + clock-controller: > + $ref: /schemas/clock/mobileye,eyeq5-clk.yaml# > + type: object > + > + reset-controller: > + $ref: /schemas/reset/mobileye,eyeq5-reset.yaml# > + type: object > + > + pinctrl-a: > + $ref: /schemas/pinctrl/mobileye,eyeq5-pinctrl.yaml# > + type: object > + > + pinctrl-b: > + $ref: /schemas/pinctrl/mobileye,eyeq5-pinctrl.yaml# > + type: object > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + system-controller@e00000 { > + compatible = "mobileye,eyeq5-olb", "syscon", "simple-mfd"; > + reg = <0xe00000 0x400>; > + > + clock-controller { > + compatible = "mobileye,eyeq5-clk"; > + #clock-cells = <1>; > + clocks = <&xtal>; > + clock-names = "ref"; > + }; > + > + reset-controller { > + compatible = "mobileye,eyeq5-reset"; > + #reset-cells = <2>; > + }; > + > + pinctrl-a { > + compatible = "mobileye,eyeq5-a-pinctrl"; > + #pinctrl-cells = <1>; Sure you need this? Generally only pinctrl-single uses this. > + }; > + > + pinctrl-b { > + compatible = "mobileye,eyeq5-b-pinctrl"; > + #pinctrl-cells = <1>; > + }; > + }; This can all be simplified to: system-controller@e00000 { compatible = "mobileye,eyeq5-olb", "syscon"; reg = <0xe00000 0x400>; #reset-cells = <2>; #clock-cells = <1>; clocks = <&xtal>; clock-names = "ref"; pins { ... }; }; There is no need for sub nodes unless you have reusable blocks or each block has its own resources in DT. Rob