Received-SPF: pass (google.com: domain of linux-kernel+bounces-37302-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 24 Jan 2024 16:10:24 +0000
From: Conor Dooley <conor@kernel.org>
To: Siddharth Vadapalli <s-vadapalli@ti.com>
Cc: bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com,
	robh@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, linux-pci@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, vigneshr@ti.com, afd@ti.com,
	srk@ti.com
Subject: Re: [PATCH v3] dt-bindings: PCI: ti,j721e-pci-host: Add support for
 J722S SoC
Message-ID: <20240124-unmatched-plating-019a3055cf5e@spud>
References: <20240124122936.816142-1-s-vadapalli@ti.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="XMTtUXZ1FD8n2B8o"
Content-Disposition: inline
In-Reply-To: <20240124122936.816142-1-s-vadapalli@ti.com>


--XMTtUXZ1FD8n2B8o
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 24, 2024 at 05:59:36PM +0530, Siddharth Vadapalli wrote:
> TI's J722S SoC has one instance of a Gen3 Single-Lane PCIe controller.
> The controller on J722S SoC is similar to the one present on TI's AM64
> SoC, with the difference being that the controller on AM64 SoC supports
> up to Gen2 link speed while the one on J722S SoC supports Gen3 link speed.
>=20
> Update the bindings with a new compatible for J722S SoC.
>=20
> Technical Reference Manual of J722S SoC: https://www.ti.com/lit/zip/spruj=
b3
>=20
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

> ---
>=20
> Hello,
>=20
> This patch is based on linux-next tagged next-20240124.
>=20
> v2:
> https://lore.kernel.org/r/20240122064457.664542-1-s-vadapalli@ti.com/
> Changes since v2:
> - Added fallback compatible for "ti,j722s-pcie-host" as
>   "ti,j721e-pcie-host" based on Conor's suggestion at:
>   https://lore.kernel.org/r/20240122-getting-drippy-bb22a0634092@spud/#t
>=20
> v1:
> https://lore.kernel.org/r/20240117102526.557006-1-s-vadapalli@ti.com/
> Changes since v1:
> - Dropped patches 1/3 and 2/3 of the v1 series as discussed in the v1
>   thread.
> - Updated patch 3/3 which is the v1 for this patch by dropping the checks
>   for the "num-lanes" property and "max-link-speed" property since the PCI
>   driver already validates the "num-lanes" property.
>=20
> Regards,
> Siddharth.
>=20
>  Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml=
 b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> index b7a534cef24d..ac69deeaf1ee 100644
> --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> @@ -23,6 +23,10 @@ properties:
>          items:
>            - const: ti,j7200-pcie-host
>            - const: ti,j721e-pcie-host
> +      - description: PCIe controller in J722S
> +        items:
> +          - const: ti,j722s-pcie-host
> +          - const: ti,j721e-pcie-host
> =20
>    reg:
>      maxItems: 4
> --=20
> 2.34.1
>=20

--XMTtUXZ1FD8n2B8o
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZbE2bwAKCRB4tDGHoIJi
0jHrAQCIBSaSCKrkq41PAo1JM5MQwnH1H5lerQzNSHd34orjQQD/QiTReBxf2B8K
0HBXqv1UMcgBysJE8No3ifA4Cdp2vA0=
=tVT8
-----END PGP SIGNATURE-----

--XMTtUXZ1FD8n2B8o--