Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp1217700rdb; Wed, 24 Jan 2024 08:12:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IGMmUpYx6HdAWKYphlnY+CLleFPV2Z0n1Njjro7y6TZnXdBcx8yRqplaztHYAmcrGTZTMCq X-Received: by 2002:a17:903:2349:b0:1d7:1342:64cd with SMTP id c9-20020a170903234900b001d7134264cdmr978933plh.10.1706112727170; Wed, 24 Jan 2024 08:12:07 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706112727; cv=pass; d=google.com; s=arc-20160816; b=Zwk8P9x0ocdaGgDxIx+GTOfNOr+zvPCZUMbDaoVIbCYOSZc/0T4CdpxlXEJNN5wc1V 4MXOZudrFAFA+TVktYpmMtd94MDPi8xPllXJKUG+8qtCpbiMSHJ61tm0yJ0NrlUNlmvr RDTdw6yno2+QoIFLy4wqaGPVSJyGARmMB/YlyyKPnm/KsFaDQEYafzTpB32XqX6pcmyA PEI8m7rNXSbHZ3mF7OKv7G8Ba1RJ0kogpX3NSFd/6baGPUbWSh4+c6uXfnuX91qd6R2x dLC6ZpZXuzz6oj90KElNgOxLg8SBH9Ff0p4MaJuYampd3BNP3dhRK8HjDY+Omg26nAJP 9TZQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date:dkim-signature:dkim-signature :dkim-signature:dkim-signature; bh=bAPaPbRzIYK27PGLjL/yZrS5FIUuz/u2iqA6zj1bu6E=; fh=xP1WbOonRN/KoodCSnbm2Fm4Snj4c0pNy31z1S8lMtE=; b=YhspZep12EzqYsJSh1dBWFDom2W5OABCugmq/d92YFSec7mU3b3xqe+P749AdNQDFz D7Fz/55X6jDYQbwQRkZlBc2q5Pb6JaRoAi9+lBSQJrPdW1A4PBtoEPxUrvc3kel/i8hk 1GkFWGKHjiiMy3236OjcBYIXge5gAuqqlLT7hsH12wWvEKOZwCjRY60/XtrRKp97uPzO H+KHI8JdJecfVPXtT5FWeBxnwyrXAO3o+eIf0S8HkZC3WH2wvYQK3sNEEhPGMTykNSwq 7zw84DN08vzD8M0GEc06osLylfVWfiqQGbxi+YFhmXdDzS5uyg++BZYkWwC4/PGBRLX0 vSvw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=QhPwtVPg; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=QhPwtVPg; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=upTWk8im; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-37270-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-37270-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id a10-20020a170902ee8a00b001d746a73eadsi6121270pld.646.2024.01.24.08.12.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 08:12:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-37270-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=QhPwtVPg; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=QhPwtVPg; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=upTWk8im; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-37270-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-37270-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 5804AB271CA for ; Wed, 24 Jan 2024 15:40:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A37957C0A3; Wed, 24 Jan 2024 15:40:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="QhPwtVPg"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="upTWk8im"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="QhPwtVPg"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="upTWk8im" Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 301721E503; Wed, 24 Jan 2024 15:40:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706110829; cv=none; b=fhJ9OKrNVUIadTmsJ+PDAybfPK2/ei+RCKUbLZKEAni4+sHLQE4v9244ojsagsIhu30h8QLWskY/FS0AahN2VdmSELxatBcgH1KFRHfr5bEPacxOUUZ1yQwz4bXcrR2vUmzI0Zuvra9CJP2zjh55tmxD9+R1TvIva9O/xpOtiNc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706110829; c=relaxed/simple; bh=pM7Og7SVpD0K9VmiAkA8Ep/mDsPV1pMCJYaK3vfTavI=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=Ltj3IdP38mB8DNGkgNbFPmJjKfTe1OD0aT4pOho0vkJ6L8iRJYzm1AQVuu7PZPj4D3zlpxgM1sdJLkyzg1GC4EpCB7M2CayxoDiG2mJ93XNyxMu7SEk80XCXLmWgre+XmzIl0SnX8x6BYvP8LDdbAKQVudLwuwtcYLaXTii2Paw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=QhPwtVPg; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=upTWk8im; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=QhPwtVPg; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=upTWk8im; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 439211F7E5; Wed, 24 Jan 2024 15:40:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706110826; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bAPaPbRzIYK27PGLjL/yZrS5FIUuz/u2iqA6zj1bu6E=; b=QhPwtVPgGGIPk/J/cMtGurskI5Z6kNYDwxW0RRHBvjEiNKO4apjjqFMBMQjH9XIGrNoXUs CbNK0cERzcOZuHbeWU87gBo6bDQmB856TWLNrRHgC4L0qMYOovQaEU68fM8vm7ewAp+VJo ue5YvOeaUlo5PIzGYNlMAp8TFUHobE0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706110826; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bAPaPbRzIYK27PGLjL/yZrS5FIUuz/u2iqA6zj1bu6E=; b=upTWk8imk9lVE8T/OQsF5cYdjBh3zPd6OcxP0RZ3rQeNT2zpgJqUK3PQKPwfoNQ4R0Bzm0 oXH/A87l5enZ+SCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706110826; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bAPaPbRzIYK27PGLjL/yZrS5FIUuz/u2iqA6zj1bu6E=; b=QhPwtVPgGGIPk/J/cMtGurskI5Z6kNYDwxW0RRHBvjEiNKO4apjjqFMBMQjH9XIGrNoXUs CbNK0cERzcOZuHbeWU87gBo6bDQmB856TWLNrRHgC4L0qMYOovQaEU68fM8vm7ewAp+VJo ue5YvOeaUlo5PIzGYNlMAp8TFUHobE0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706110826; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bAPaPbRzIYK27PGLjL/yZrS5FIUuz/u2iqA6zj1bu6E=; b=upTWk8imk9lVE8T/OQsF5cYdjBh3zPd6OcxP0RZ3rQeNT2zpgJqUK3PQKPwfoNQ4R0Bzm0 oXH/A87l5enZ+SCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1631F13786; Wed, 24 Jan 2024 15:40:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id /I8QBGovsWUBFAAAD6G6ig (envelope-from ); Wed, 24 Jan 2024 15:40:26 +0000 Date: Wed, 24 Jan 2024 16:40:25 +0100 Message-ID: <87bk9aloye.wl-tiwai@suse.de> From: Takashi Iwai To: Sean Young Cc: Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: usb-audio: add quirk for RODE NT-USB+ In-Reply-To: <20240124151524.23314-1-sean@mess.org> References: <20240124151524.23314-1-sean@mess.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Level: Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=QhPwtVPg; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=upTWk8im X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-5.51 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DWL_DNSWL_MED(-2.00)[suse.de:dkim]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; MID_CONTAINS_FROM(1.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-3.00)[100.00%] X-Spam-Score: -5.51 X-Rspamd-Queue-Id: 439211F7E5 X-Spam-Flag: NO On Wed, 24 Jan 2024 16:15:24 +0100, Sean Young wrote: > > The RODE NT-USB+ is marketed as a professional usb microphone, however the > usb audio interface is a mess: > > [ 1.130977] usb 1-5: new full-speed USB device number 2 using xhci_hcd > [ 1.503906] usb 1-5: config 1 has an invalid interface number: 5 but max is 4 > [ 1.503912] usb 1-5: config 1 has no interface number 4 > [ 1.519689] usb 1-5: New USB device found, idVendor=19f7, idProduct=0035, bcdDevice= 1.09 > [ 1.519695] usb 1-5: New USB device strings: Mfr=1, Product=2, SerialNumber=3 > [ 1.519697] usb 1-5: Product: R?DE NT-USB+ > [ 1.519699] usb 1-5: Manufacturer: R?DE > [ 1.519700] usb 1-5: SerialNumber: 1D773A1A > [ 8.327495] usb 1-5: 1:1: cannot get freq at ep 0x82 > [ 8.344500] usb 1-5: 1:2: cannot get freq at ep 0x82 > [ 8.365499] usb 1-5: 2:1: cannot get freq at ep 0x2 > > Add QUIRK_FLAG_GET_SAMPLE_RATE to work around the broken sample rate get. > I have asked Rode support to fix it, but they show no interest. > > Signed-off-by: Sean Young Applied now. Thanks. Takashi