Received-SPF: pass (google.com: domain of linux-kernel+bounces-37341-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <5598e8aa-14b2-4199-9620-3e4fe3dde459@amd.com>
Date: Wed, 24 Jan 2024 10:39:43 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC] Revert "drm/sched: Split free_job into own work item"
Content-Language: en-US
To: Vlastimil Babka <vbabka@suse.cz>, Luben Tuikov <ltuikov89@gmail.com>,
 Matthew Brost <matthew.brost@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
 Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>,
 David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
 =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
 "open list:DRM GPU SCHEDULER" <dri-devel@lists.freedesktop.org>,
 open list <linux-kernel@vger.kernel.org>
References: <20240123021155.2775-1-mario.limonciello@amd.com>
 <c2995f42-7b35-4d3f-8882-433354b2513a@suse.cz>
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <c2995f42-7b35-4d3f-8882-433354b2513a@suse.cz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bEhWek80WlE2Z2d5YmZlWFozdndvdUY1dFRCWkU2WkhEa0ZNVDFnM0lyN3dq?=
 =?utf-8?B?TE5SNUtWdUNjaERpYXRrd01yUWpGaEYrNVk0RWJTbDVibWhpaHkraytFNTZa?=
 =?utf-8?B?NVQ4RlhLUFVsNHhhNmc0M0JNcDBJOTJYUFBTQ3RLamNjd1hTSUVnS1ZvZGdq?=
 =?utf-8?B?Tk9pbkU4N1lwYmJEMW5Tc1U0Z0hRVEYrallCUHY3bm1yRCtzdXR3eHR3di8w?=
 =?utf-8?B?L1J2ZlZ2MUliWmtlUHZRdHcrakV5d2NTZHcyUHBHQm5kaTRvRC9FaFNnUUNj?=
 =?utf-8?B?YzlCWmJQcE13cmxDR1Q3NzRYdFl1K2F1eWs4a1RtVS9BVlVkNlNIV3NRSzY5?=
 =?utf-8?B?SXU5eXVmRkJFNk8yTVZ3OTRoT2FsVmc3bEh6bnBHUzZYQlRZaklOVEY2YWJ5?=
 =?utf-8?B?bUMvTytDYWluQ3RSM090ZkJkNTg4RUxYNWx2Um84b01hQ0hkeFdJdjM0VUFE?=
 =?utf-8?B?NEZsRjRuMTBDRkZkNUlPVmZRbERBbHZoV0pnL2RVWmU4MWpMSWpMV21EeFFN?=
 =?utf-8?B?RGVnRHo1UzFrbGVXaVZHT1ozSm1EeFdsZXNaRFFpaU1Db2wwWjY1ZFZ1bjJ0?=
 =?utf-8?B?OWc5RzdSaFhwT1R4U1pVdVZNaDhVTWlITng5T2FXK0R0VU96RWs4OTYxVTJU?=
 =?utf-8?B?NWZDSHZnTDBoeEUwVGdXSGRNWkQ2V05rTmtRZ0twdmE0WG9MOXZLNmR4ZlVS?=
 =?utf-8?B?aUFCQVRKYjgwRlJneEVtTGFIbEJiNmJRT2ZTc1REMkhORGdwcWpGNjNtZm9i?=
 =?utf-8?B?RmZSVFczeVNtdHBOWFZHSzEvNDFyN2I4VWJFa0xsWW8zWGRTeDliQk1yVTcx?=
 =?utf-8?B?VU9lU2dFU3p1b0RCNnoxTGw1TzVqdnFDNVZVd1I5SkJrQkNzZU9HbHVsdXcx?=
 =?utf-8?B?NlBqR2U5QTBNRjI2Uk4xclo5SG1HSThtMmk4cXorSHVlb2RSbEZsamU5ZE94?=
 =?utf-8?B?V2U5QTVHTmRIVGkraDhEa0c0Z3BURWU5UjE2S2gxbm9maVBQbHFJRjJmMEpG?=
 =?utf-8?B?V201bzJmeUJveEpWMU00aGt6bFl5cU5CcXpSUUQzcnVSV2drVFBiQzBLNnNr?=
 =?utf-8?B?U0xzanc4V3hoS0pqNjBidzR6UUkyQ3dCaUdoTTM1ekpDd2dKUXRwdjA1blR5?=
 =?utf-8?B?Nk4rUU5SUHFwdGVBMmpxS0gyY1NOcUhZVU1CNC9oQ2dzVExrWTM2amdKcTdv?=
 =?utf-8?B?Y0kycUNoYUJ0V2svelRlZlVKM2NDV0NLU2Izbno2am5TcmlwY3dYakxyeTdk?=
 =?utf-8?B?eWt3bFRRZjFzM05KRks4bzYxcWJNWnlXRzltd1BCM3hkV0ZEbnBUUlRHZnhm?=
 =?utf-8?B?MDJNWHdYQXBGcmdsT2VmZ0ZaWUhwRzNldk84RitvcWRMNzNManQyZFcxWU90?=
 =?utf-8?B?QStIZGpNTDM5MkhNSTZDeTh4SFhBZ1lJcHIyVGU5U1ZPR0VZVjJpeG41WHI2?=
 =?utf-8?B?RmFKODFEbzlaRUp0NEdIVzltdndXeThaWFUzSHJ4SDJ2aG5PNnhzWEROeGZi?=
 =?utf-8?B?TW1FekZRVFdyV2xDdXFrMHhSZ2FTRGlzM0YrNGFEeHF6dUIvY0IxMUMxeGxF?=
 =?utf-8?B?YXBnOURWeUx0N3lhUHlwb3llMjJCbWtFaTlsd0JObTVvZnVNbFB5U2lvaEQz?=
 =?utf-8?B?UkF0Y040Mnk4QXcreGN2K3dGMjlnSFdoVWpTZ0xoa2xNc0hUcjhlOGlkUTM0?=
 =?utf-8?B?T21pUjBpSEhyN3hCd1NwaEZLZlV0UzZiVkpXNGJObkRCbXMzTTdMMm0vdXpQ?=
 =?utf-8?B?VEhhck9vc0VMU3BXMDYyRG9PV0NSK0RkQmo1TlBBdHdHOWFERlJkT3JxdGho?=
 =?utf-8?B?Q1hjL0VhZEdiTzBsNERoTUxMS3M4Q081ZWg4MFFMalE5cVFaWUplQng3WWlP?=
 =?utf-8?B?WFlkaE05emNuRzVwRmtLV3FpR2d2TlEvWVBhU0Q1MWZlUFJEb1Y2OWpiYUxV?=
 =?utf-8?B?TG5wekcyeFA5OEx3bjJZQ3c5SWxLL01HaTlmNXNaMnFwcC95eWVEV0ZISUwx?=
 =?utf-8?B?c1VPZHhHNTVXL1B1K0txTEdzbzB0MlFrY1JOSGVnb0M2SzBlaC9VNkk5Tll2?=
 =?utf-8?B?VjVNTmw5cEkxb2lJbXZhVm0zYktzTFR4TnB6Q0lpVno2czNrVFpTTmR4L0tN?=
 =?utf-8?Q?0W/jJ3DMV5r/cQzVtXdVDMzBR?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c9604b5-c208-4a8a-36e1-08dc1cfb128c
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2024 16:39:45.4959
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: h6JOFxY8nBKwy3LSuVEdxV65Qk1X8k2PuiQEKHIb3Ge4ALmBRdmVVlTGKsrAoWbRm0A0u+oLqend8aK1uXxCnw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4859

On 1/24/2024 10:26, Vlastimil Babka wrote:
> On 1/23/24 03:11, Mario Limonciello wrote:
>> commit f7fe64ad0f22 ("drm/sched: Split free_job into own work item")
>> causes graphics hangs at GDM or right after logging in on a
>> Framework 13 AMD laptop (containing a Phoenix APU).
>>
>> This reverts commit f7fe64ad0f22ff034f8ebcfbd7299ee9cc9b57d7.
>>
>> Fixes: f7fe64ad0f22 ("drm/sched: Split free_job into own work item")
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> ---
>> This is a regression introduced in 6.8-rc1, bisected from 6.7.
>> This revert done on top of 6.8-rc1 fixes the issue.
> 
> Applying this revert on 6.8-rc1 fixed my issues reported here:
> https://lore.kernel.org/all/2faccc1a-7fdd-499b-aa0a-bd54f4068f3e@suse.cz/
> 
> Let me know if there's another fix instead of revert so I can test.
> 

There's not another fix at the moment, but Matthew has posted a patch to 
allow ftrace to capture more data with the gpu_scheduler trace events to 
this bug report:

https://gitlab.freedesktop.org/drm/amd/-/issues/3124

I already captured from a local machine and attached to that bug report.

> Thanks,
> Vlastimil
> 
>>
>> I'm happy to gather any data to use to properly debug if that is
>> preferable to a revert.
>> ---
>>   drivers/gpu/drm/scheduler/sched_main.c | 133 +++++++++----------------
>>   include/drm/gpu_scheduler.h            |   4 +-
>>   2 files changed, 48 insertions(+), 89 deletions(-)
>>
>