Received-SPF: pass (google.com: domain of linux-kernel+bounces-37311-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 24 Jan 2024 16:12:27 +0000
From: Conor Dooley <conor@kernel.org>
To: Fabian Pfitzner <f.pfitzner@pengutronix.de>
Cc: Michael Hennerich <michael.hennerich@analog.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Alexandru Tachici <alexandru.tachici@analog.com>,
	kernel@pengutronix.de, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: net: adin: add recovered clock output
Message-ID: <20240124-thespian-user-e03315490295@spud>
References: <20240122110311.2725036-1-f.pfitzner@pengutronix.de>
 <20240124102554.1327853-1-f.pfitzner@pengutronix.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="t3OrvrAsH2Aaal0o"
Content-Disposition: inline
In-Reply-To: <20240124102554.1327853-1-f.pfitzner@pengutronix.de>


--t3OrvrAsH2Aaal0o
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 24, 2024 at 11:25:54AM +0100, Fabian Pfitzner wrote:
> The ADIN1300 offers three distinct output clocks which can be accessed
> through the GP_CLK pin. The DT only offers two of the possible options
> and thus the 125MHz-recovered output clock is missing.
>=20
> As there is no other way to configure this pin than through the DT it
> should be possible to do so for all available outputs.
>=20
> Signed-off-by: Fabian Pfitzner <f.pfitzner@pengutronix.de>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

> ---
>  Documentation/devicetree/bindings/net/adi,adin.yaml | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>=20
> diff --git a/Documentation/devicetree/bindings/net/adi,adin.yaml b/Docume=
ntation/devicetree/bindings/net/adi,adin.yaml
> index 929cf8c0b0fd..04059393b756 100644
> --- a/Documentation/devicetree/bindings/net/adi,adin.yaml
> +++ b/Documentation/devicetree/bindings/net/adi,adin.yaml
> @@ -38,14 +38,17 @@ properties:
> =20
>    adi,phy-output-clock:
>      description: |
> -      Select clock output on GP_CLK pin. Two clocks are available:
> -      A 25MHz reference and a free-running 125MHz.
> +      Select clock output on GP_CLK pin. Three clocks are available:
> +        - 25MHz reference
> +        - free-running 125MHz
> +        - recovered 125MHz
>        The phy can alternatively automatically switch between the referen=
ce and
>        the 125MHz clocks based on its internal state.
>      $ref: /schemas/types.yaml#/definitions/string
>      enum:
>        - 25mhz-reference
>        - 125mhz-free-running
> +      - 125mhz-recovered
>        - adaptive-free-running
> =20
>    adi,phy-output-reference-clock:
>=20
> base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
> --=20
> 2.39.2
>=20

--t3OrvrAsH2Aaal0o
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZbE26wAKCRB4tDGHoIJi
0uasAP9k19fNc3ngPfP4KVkRXGmzsNoEaqPZih5IpbjEPe/ixgD9EmYsTcGn3IWJ
8hvoOz5lMTlqOuGoIlB61AKbTVVVXw0=
=mTuk
-----END PGP SIGNATURE-----

--t3OrvrAsH2Aaal0o--