Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp1242361rdb; Wed, 24 Jan 2024 08:56:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IH5YkUwmM71rE4miIE+KbL/Kw2ZCBjIGNj7GkLZBrVFHG2c+nd8Z7q92A18VotiMInowZ2o X-Received: by 2002:a17:90a:31c8:b0:28c:f504:12a with SMTP id j8-20020a17090a31c800b0028cf504012amr4742000pjf.24.1706115406866; Wed, 24 Jan 2024 08:56:46 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706115406; cv=pass; d=google.com; s=arc-20160816; b=0obwR2ON7ESUmiNYtte7gERGx533vIfvlj2GHwigPvuiRAo1VKvKbEAO+p6I2aCD84 7NriQqrceKQEgKAJrWJZtTHp1tnc1uogpHqcIqWVGVjVw7tz3vYmvc0G5mZdmWQWRAA6 V6lrq5gIeohBoNVNN+4JtaWI+YV8tCzlJlL9tbAGSQEdq+86RW5AEhJdfz5FwBh4ISwx JBv03VSjdcKnQxTffEG1lXmCbSMkNFU12R0yheNGPLlYQMw+zuNGDieOptudzq22kScq cMM4CofApEeDQ/evVnk3B0ekFns7+VPkocVUboOkTy3heE3rkqEI++xp+BjImd0+/ly9 ySYg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature :dkim-signature:dkim-signature:dkim-signature; bh=symhIeQH+xFWWu7ZkOKh67eF07PcSm6nFW937Q3F2fE=; fh=f5CVqDu9wkRXZ0WcyeCFMoPy2w0J44YWSF4bNrtMbSg=; b=Nl107nS51xPGXf71X8B3jjSanGX+sHxPS6fElARgoHbsZk8DwR/O/kDreXFAeQu4dA ifl3G39wuHorQyD6z//X0wiTQM8+dIVyo8hhpFheuRZcbwj3mchr1Krc4ABTuyv1hA1/ Oms4i0U7wevD+uZR7i4cZrPS3OHev2jbRBiqI9ilrQK3xMod8MaKdCdib75Pz5LEbdXy 5tXEZIyeuETiAmgVHuFD+ilxYQWxWT1DGFclSr5Rl8d3wKyOb9NCXwPiWOruA1jHsQHR owVPZQFJynsMtLqdQo803xUroB4owAWF4wLFSgBS16QPt9btuyONKSiMutB9NAun9UQW xX3Q== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=lQ9tgBBW; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=lQ9tgBBW; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.cz dkim=pass dkdomain=suse.cz dkim=pass dkdomain=suse.cz); spf=pass (google.com: domain of linux-kernel+bounces-37331-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-37331-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id w4-20020a17090abc0400b00290483f8c66si10119311pjr.174.2024.01.24.08.56.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 08:56:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-37331-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=lQ9tgBBW; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=lQ9tgBBW; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.cz dkim=pass dkdomain=suse.cz dkim=pass dkdomain=suse.cz); spf=pass (google.com: domain of linux-kernel+bounces-37331-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-37331-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id B93A7B2C431 for ; Wed, 24 Jan 2024 16:27:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0DBD87CF2F; Wed, 24 Jan 2024 16:27:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="lQ9tgBBW"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="oE8dTMc/"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="lQ9tgBBW"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="oE8dTMc/" Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BC687C09F for ; Wed, 24 Jan 2024 16:27:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706113624; cv=none; b=JABriikj2JpUpbD3TZMHJB4h/Zf5U4P/J5QIPnZoMx1SpFFHXBZa9Tr6wvfYh8r6KHtsQVLxX8bxc20hOlv0/MyizdNDuysHfVBSQYeRmzXKypE1TdfFv4bkyxQrMqtvvl/L9kXWrLmTtuPweYTuJcGwQaH2OtSzaJt1RWMzkJY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706113624; c=relaxed/simple; bh=waBFxmJupUTBTaPp1HXvC5yAn86vKXcb4A0xPu8gN84=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=a8tduf40m2PoFcSdRCOnhgnRrPLQcQzAP+zph9LDVgYhWfAQiA9KZKsZ5V9565IxUiZaG91oQazaVqVS8I9MGGfD/T9qYS9Q2cNCNKdEFNAclC09c9L/Hzd/eFNR34PY7mXaxx1PpSJBiHbkX/wx9GqaZswePekJ7ud7MAv8oqA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=lQ9tgBBW; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=oE8dTMc/; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=lQ9tgBBW; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=oE8dTMc/; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BE6B01F7FB; Wed, 24 Jan 2024 16:26:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1706113619; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=symhIeQH+xFWWu7ZkOKh67eF07PcSm6nFW937Q3F2fE=; b=lQ9tgBBWiCAYqZ9mf1n59omqAWxrXnqo/eL8Hw7Xya/3iKO6iKDWcOMoGSCGkoy6hGlWjE EWDSIEU8zsiL9ZQ6GOeTuLVJp96KhHPG5dsNk8KMPvlt3HZJQ8BY8wMhZ6rxSQnjuBNsYB Vl9cUcdmX0Uz9K8djynrRG7lp9SgYrQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1706113619; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=symhIeQH+xFWWu7ZkOKh67eF07PcSm6nFW937Q3F2fE=; b=oE8dTMc/hcssgtim+YYGpNPM7dkYgeDUHTeGwm6Iqi1wBQvReA/gdltDK5A8IIfSovxVRp QfA9m/vVVlUCXqBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1706113619; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=symhIeQH+xFWWu7ZkOKh67eF07PcSm6nFW937Q3F2fE=; b=lQ9tgBBWiCAYqZ9mf1n59omqAWxrXnqo/eL8Hw7Xya/3iKO6iKDWcOMoGSCGkoy6hGlWjE EWDSIEU8zsiL9ZQ6GOeTuLVJp96KhHPG5dsNk8KMPvlt3HZJQ8BY8wMhZ6rxSQnjuBNsYB Vl9cUcdmX0Uz9K8djynrRG7lp9SgYrQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1706113619; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=symhIeQH+xFWWu7ZkOKh67eF07PcSm6nFW937Q3F2fE=; b=oE8dTMc/hcssgtim+YYGpNPM7dkYgeDUHTeGwm6Iqi1wBQvReA/gdltDK5A8IIfSovxVRp QfA9m/vVVlUCXqBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A48911333E; Wed, 24 Jan 2024 16:26:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id UYzJJ1M6sWVnIwAAD6G6ig (envelope-from ); Wed, 24 Jan 2024 16:26:59 +0000 Message-ID: Date: Wed, 24 Jan 2024 17:26:59 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC] Revert "drm/sched: Split free_job into own work item" Content-Language: en-US To: Mario Limonciello , Luben Tuikov , Matthew Brost Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , =?UTF-8?Q?Christian_K=C3=B6nig?= , "open list:DRM GPU SCHEDULER" , open list References: <20240123021155.2775-1-mario.limonciello@amd.com> From: Vlastimil Babka In-Reply-To: <20240123021155.2775-1-mario.limonciello@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: smtp-out2.suse.de; none X-Spamd-Result: default: False [-0.09 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; BAYES_HAM(-0.00)[27.73%]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; TO_DN_ALL(0.00)[]; RCPT_COUNT_SEVEN(0.00)[11]; FREEMAIL_TO(0.00)[amd.com,gmail.com,intel.com]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[linux.intel.com,kernel.org,suse.de,gmail.com,ffwll.ch,amd.com,lists.freedesktop.org,vger.kernel.org]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Level: X-Spam-Flag: NO X-Spam-Score: -0.09 On 1/23/24 03:11, Mario Limonciello wrote: > commit f7fe64ad0f22 ("drm/sched: Split free_job into own work item") > causes graphics hangs at GDM or right after logging in on a > Framework 13 AMD laptop (containing a Phoenix APU). > > This reverts commit f7fe64ad0f22ff034f8ebcfbd7299ee9cc9b57d7. > > Fixes: f7fe64ad0f22 ("drm/sched: Split free_job into own work item") > Signed-off-by: Mario Limonciello > --- > This is a regression introduced in 6.8-rc1, bisected from 6.7. > This revert done on top of 6.8-rc1 fixes the issue. Applying this revert on 6.8-rc1 fixed my issues reported here: https://lore.kernel.org/all/2faccc1a-7fdd-499b-aa0a-bd54f4068f3e@suse.cz/ Let me know if there's another fix instead of revert so I can test. Thanks, Vlastimil > > I'm happy to gather any data to use to properly debug if that is > preferable to a revert. > --- > drivers/gpu/drm/scheduler/sched_main.c | 133 +++++++++---------------- > include/drm/gpu_scheduler.h | 4 +- > 2 files changed, 48 insertions(+), 89 deletions(-) >