Received-SPF: pass (google.com: domain of linux-kernel+bounces-37370-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <f081bad4-2828-4d2f-bbe6-165ad2ba1655@axis.com>
Date: Wed, 24 Jan 2024 17:57:12 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] Input: cap11xx - stop using chip ID when configuring it
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
References: <ZXlCRsnOu_L8xeTC@google.com> <ZalnEZ83M0jlQI2s@google.com>
Content-Language: en-US
From: Jiri Valek - 2N <jiriv@axis.com>
In-Reply-To: <ZalnEZ83M0jlQI2s@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?M1hSYnljbEY2cE4xc0RtL3dUT294Lzl5R1NxSzJzakV1Rk9CSkRlSk4rZlVi?=
 =?utf-8?B?U3ZocWtkTDB0ZUdMdkRpUllFc3o4TGEvUkloajR3M1pydC83ZXhKb29MclZ0?=
 =?utf-8?B?NWxNbHdRSWpxNDNTdjduOHo3Wjc4T1NqOHRRWnFpcjc3MlI2V3Y2TlRYMXA0?=
 =?utf-8?B?TWNia2lqZGwvdk9aMFlpdnA4K3JYNUZVVjF2NGltZGJybTVlS0dORXUwMXZC?=
 =?utf-8?B?eEdrUDM5K0UxOWxEaDIwMG9PMHh0endkS2VVUXViRlF4ZkgrbFlLU3FJQ0ZY?=
 =?utf-8?B?cUdLbjVSSlZNU2daTFZ2ODZVZ21DTmIraDFCWllydFpOMDQ2b0t6SSszcXlM?=
 =?utf-8?B?c1l4UEtpVy81bUdRcWpNVUZEM2krTDJuRHB5SkZCaEFocVRTbVhVRWdEclFm?=
 =?utf-8?B?aVRjNWVxL2hQdi9hUVE1NitSL2RNUndYN1VSeTB2OGFYZVg4Tk9GRjNoYVFk?=
 =?utf-8?B?NXpjT3pWYkVHVHBSa3RmQWYvZmVqVkdqdWlEamNFUWpSM2ZzTTlObmZUVWhl?=
 =?utf-8?B?TVh3MUF1MkJvdzRvWmxMZGthcW44dzlJSzBldVRiQUZqRFoxL2pPdGpJc0hz?=
 =?utf-8?B?bzNUOEFUZHVxdldqV1lhemZDbVJrWit1R3B5N2cwc0pPWE9CL1ZjRUtXN3lO?=
 =?utf-8?B?U1ZxRnhGUE9uSkNYcm5yQkVNY1diYmJZMWx2a1R2ZTgxYXVrdjNFZVJRMlUx?=
 =?utf-8?B?azUvOGNBbzdHdDArbXo5Unh4OHNSNWlMWDJOY2VDZGNONWNvbU91Y1dhZ2Za?=
 =?utf-8?B?L2pVMTM0cmN0S1N2N1hTcml3T1pLYjJycXVNZStYK0xHN0t3M0dsWnh2OVV1?=
 =?utf-8?B?SHpaUGxlT3ZKV2tGTTcycXN0U0xnT2hiK1h4akEvZ1VmNnViY093ajREZFFJ?=
 =?utf-8?B?U2lzRW9kbHpGVy9pY24rd3dZaGhPWVNBQ3Q0UXN5dWV3eXB0ZEFHVURwS2E0?=
 =?utf-8?B?MFZzamlmNU9wOTVXQkczNG1IUW80ZUkvUlFGbkVlenBpWms3YUpMbTJ0TEZ6?=
 =?utf-8?B?N01JbWVqTE4xZ2dBN2pyb29BVTdRTVNZNm00MVZwQTJ2elBLOUxXdXlzY3px?=
 =?utf-8?B?azBaQU4zaGZ4YlJWVEhYQm9yTlhDeHR5NU92U0FucnA0N1c2MnVyT25jajhw?=
 =?utf-8?B?SlRodW1Ga3JRNVF5L2MwZDN2UFB4a3c2dG1ZeHZaTWg3dWdaRk5zYVNYOUNv?=
 =?utf-8?B?NWlhOExHenlRT1Q1Sm5nN2FNb05PUWY4Rm1GWjlqdmt1OGd2LzRKcy9EMERh?=
 =?utf-8?B?eTFjZkxFN3ZnOW1LM1JVQUNjOHdnL1VjakVhcjAyRWgzZ2E5bFNLZ0xmSkpQ?=
 =?utf-8?B?MGo5NUNXV09ER1N2MXIzL09QczB6cHNYNUMyZ3NHVFNMT0cvZVhYYmZpNWwz?=
 =?utf-8?B?YmFLc1JxbldjdHZ0cUR3VENuVm9DMjY0d200REo1K09zcXFiTGN3Q3E1ZTB1?=
 =?utf-8?B?bG9xUkNFV3lTYjhGUmp2Mmd6aEZEUDJWMWJDU3JPaFlLZDFJTE8wbGlweDJO?=
 =?utf-8?B?OEQ0ZFliaWVMMUV6eVdsV2k3TnZ2aW91RzczdlJweERmaWtNcU9NZVcwMHNE?=
 =?utf-8?B?R2JYaEJzdDhubm5MazFuYzJjeEZYWUlGc0dxcitncURGOVo2blZkblhsY3Jo?=
 =?utf-8?B?aDJqUVVYRnRYSysvdUNTUW0rVlUxcnRxK2djbEFWSUNjeHdnQmQxS2loT2wv?=
 =?utf-8?B?SExyd3prUXMxRzhvd2ZoMG05NUJxREU3NlE5bzJrQUF4ZDdIQWV4MTBubTlQ?=
 =?utf-8?B?NWpab0ppeE1OODFGT1pZTmJwdThNaXp2OCtjUThBRmdpWTZGakpsTk1ackNp?=
 =?utf-8?B?VzU1MUQxSS9CcUw1Y0JvK005SjlkRFZaK29GNGgwdlI1Q0ZkUVBXSGQ5Wk9V?=
 =?utf-8?B?K0V6TVBSWFhQQ0kvU1dIUldaQ0Mwenh6aEJ3NDNTWmljd1I0R0xOMk5XVHlE?=
 =?utf-8?B?L1lGRHp1MXRXeis3Q2hCc3JxTlI5VC81NjZ4RytRejVBNnNKS0U3aEVnN2pP?=
 =?utf-8?B?dFJPU0M4WTZjYmxER0VGcFdZeHRka3BmbFZMYTRwWE9LVmQrRGZ4NGlMbFl5?=
 =?utf-8?B?UEp6UGEvY3ZtN1ZHQmlzeGkvTnROSE1vTytneER1a2I0ejE3ejMrVS9PSTNJ?=
 =?utf-8?Q?JLJZhWpBIArPizLdW8Nc6IsQK?=
X-OriginatorOrg: axis.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 71c1a249-2120-4a3e-9720-08dc1cfd83e2
X-MS-Exchange-CrossTenant-AuthSource: PAXPR02MB7263.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2024 16:57:14.6332
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oCYE8lPkGfWabf/UcU3HsfP+2MTLp6fgq0ci21v3jpt9P/vRcT/aOicTQ+CQM6zA
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR02MB9194

On 1/18/24 18:59, Dmitry Torokhov wrote:
> On Tue, Dec 12, 2023 at 09:33:58PM -0800, Dmitry Torokhov wrote:
>> struct cap11xx_hw_model is supposed to describe the chip capabilities,
>> however later code changes introduced checks against chip ID.
>>
>> Introduce new capabilities in cap11xx_hw_model and use them when applying
>> chip configuration, and remove the enum for chip ID. While at it, rename
>> no_gain to has_gain to match the rest of the new capabilities.
> 
> Jiri, if you could give this a spin on your device that would be great.
> 
> Thanks!
> 
Hi Dmitry,

thanks for changes. Looks good to me.
I verified the functionality on real HW with CAP1293.

Reviewed-by: Jiri Valek - 2N <jiriv@axis.com>