Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760905AbXLQNdQ (ORCPT ); Mon, 17 Dec 2007 08:33:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756008AbXLQNdB (ORCPT ); Mon, 17 Dec 2007 08:33:01 -0500 Received: from ug-out-1314.google.com ([66.249.92.170]:26099 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752567AbXLQNdA (ORCPT ); Mon, 17 Dec 2007 08:33:00 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; b=eCeOJYZWznJMq3Bfcb2qyqGEy5mdYhsAg1l7M6xRIgoJQ+H7jnhwOg5vo2fiK7JECEmnHaFK5Kj6x63npK1Fj2XrcH/IviHsa1oDJABla4F73vaOVvvE2UyWLPntilvMkKv0OtXQ29PEf09Ce8cx7cLuBxh//eKZa2ZdiIGfI6E= Message-ID: <47667A23.8000604@gmail.com> Date: Mon, 17 Dec 2007 14:31:15 +0100 From: Rene Herman User-Agent: Thunderbird 2.0.0.9 (X11/20071031) MIME-Version: 1.0 To: Pavel Machek CC: Ingo Molnar , "H. Peter Anvin" , Paul Rolland , Alan Cox , "David P. Reed" , Thomas Gleixner , linux-kernel@vger.kernel.org, Ingo Molnar , rol@witbe.net Subject: Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override. References: <476438B4.2020600@zytor.com> <476462BE.3030701@gmail.com> <4764687D.6080609@zytor.com> <476524DB.7020806@gmail.com> <20071216152250.GA21245@elte.hu> <4765D43E.1010800@gmail.com> <20071217105744.GA14315@elte.hu> <4766684D.40202@gmail.com> <20071217130933.GB27992@elte.hu> <47667812.8050708@gmail.com> <20071217133120.GA11321@elf.ucw.cz> In-Reply-To: <20071217133120.GA11321@elf.ucw.cz> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1654 Lines: 39 On 17-12-07 14:31, Pavel Machek wrote: > On Mon 2007-12-17 14:22:26, Rene Herman wrote: >> On 17-12-07 14:09, Ingo Molnar wrote: >> >>>>> -#ifndef CONFIG_UDELAY_IO_DELAY >>>>> -static int __init dmi_alternate_io_delay_port(const struct >>>>> dmi_system_id *id) >>>>> +static int __init dmi_io_delay_0xed_port(const struct dmi_system_id >>>>> *id) >>>>> { >>>>> - printk(KERN_NOTICE "%s: using alternate I/O delay port\n", id->ident); >>>>> - io_delay = alternate_io_delay; >>>>> + printk(KERN_NOTICE "%s: using 0xed I/O delay port\n", id->ident); >>>>> + io_delay_type = CONFIG_IO_DELAY_TYPE_0XED; >>>>> + >>>>> return 0; >>>>> } >>>> This isn't correct. DMI shouldn't override the CONFIG choice or someone >>>> with matching DMI will have a defective CONFIG option. That's why I put >>>> all of it inside #ifndef. >>> no, the DMI quirk is just that: a quirk that makes boxes work. The DMI >>> quirk takes precedence over just about any .config default, except an >>> explicit boot-commandline override. >> No, most definitely not. Having the user select udelay or none through the >> kernel config and then the kernel deciding "ah, you know what, I'll know >> better and use port access anyway" is _utterly_ broken behaviour. Software >> needs to listen to its master. > > That's what command line is for. Ingo is right here. No. The kernel shouldn't provide defective config options. Rene. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/