Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp1296531rdb; Wed, 24 Jan 2024 10:30:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IGxnEu/Mmdx1SjohjWVnygme7fbKY87M6wGayz3w41WjSjn20MiABbKhJgGsfQL9RXpjVpo X-Received: by 2002:ac2:4959:0:b0:510:1487:bcb with SMTP id o25-20020ac24959000000b0051014870bcbmr485323lfi.64.1706121009955; Wed, 24 Jan 2024 10:30:09 -0800 (PST) Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id s20-20020a170906169400b00a2a3d55cb43si123015ejd.521.2024.01.24.10.30.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 10:30:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-37513-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linux-foundation.org header.s=google header.b=K4mXIT0y; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-37513-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-37513-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id AF6871F24B38 for ; Wed, 24 Jan 2024 18:30:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 18BA212BE93; Wed, 24 Jan 2024 18:29:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="K4mXIT0y" Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DA5C12AADF for ; Wed, 24 Jan 2024 18:29:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706120998; cv=none; b=WcwY2R1rKwkN3zwWw+rnwj5UtGZQ9gTVPoYeWcow2FB9pqHl31gYNQtDIxAEt1qiypbhxq80BR9zEa4TE9nKT30vAP+n9w0IZsvBpMncrNVf/+NP4pu144hH0/eQjhhkt7sU9hrAX6pcqzUd1y7IOpYIWX40OVCqt3Ticd7GJrs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706120998; c=relaxed/simple; bh=SW6iKvLIfjtPb7161k0Be90L2EGbRQCt76qGG32t4Sc=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=hCGxmcg8cm3LIcIFYGZPWoPGOTi7AJdVwR5vT9fylLUpdod7hUcDL/kWHwtNKaMGKV5LlAdozL6Tp/herDYtj6C+3B2XO+80ETiWwQLk9DdxCVXBinhaWzGGR9OkWPgCXrwOg5SYVFJPhRwhcoY6/nuBi6CXWqZ5QOiJv+/WDqI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=K4mXIT0y; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-5100cb238bcso2607991e87.3 for ; Wed, 24 Jan 2024 10:29:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1706120994; x=1706725794; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0V0EohxWvuuUENl0m42DMDVa8sdRi34P5EyN97xnskE=; b=K4mXIT0yfeheSgC2LsLz2nHgNl6thRtk8zzRl3uwJozdi/FHPEAnDmrgy5q5NqAaMd mMED7fGAoTUmUbxgRZstGmrd8nk0duTbUE/qDyZK9uVGZHeCiiNr9t35GunDEfpIvrG3 D1pJqA0VSY/ee7n5PDo+So61y+Hb7M05u/syo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706120994; x=1706725794; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0V0EohxWvuuUENl0m42DMDVa8sdRi34P5EyN97xnskE=; b=S1t39vb0TcI1j5LDFTkRIUJQXvrcoNO8kAdFEPN2R7rPCo3ATNidoklFkt/ZLpQmab 6BvEIWy1QzuhhxnRAq2wQd+mJQjbTWqeeGznd7qm5fMOuZZhKlOt9HijeLNXk5qD9PI0 3ZawkOuDO1ldD0YvtSNW6LY2PTKWHd0pLxc/7Re5vtX6t/4LACH2S6q6ubcOTpu8aZ1A zceVzwVyKdUm/95CKlbagwuqmP3HUnrP9PCNyjETPF9xGvywQ9AVUD0GopNfaz24yRzh KbzG++0Aqa2uxAPWPwBxrnufCLIQBZnWf1OUWN+Pp6VePOC21DnHsIigL/wZ8nWfF1F4 F6Mg== X-Gm-Message-State: AOJu0YzxVSgCl6rCR2vHtxmYN/tNB42orjaZ2uh6sPluTjVfkwlqKNUB hYhssedDv5Jemp8iAQUACdZ7M66tL7NT2Eov/Cg58SKAdJMzSAriJxGsEzG4am/uGvWkSTxgIH+ PVYKoaw== X-Received: by 2002:ac2:5d31:0:b0:50e:6d96:4b32 with SMTP id i17-20020ac25d31000000b0050e6d964b32mr2972704lfb.71.1706120994529; Wed, 24 Jan 2024 10:29:54 -0800 (PST) Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com. [209.85.208.182]) by smtp.gmail.com with ESMTPSA id d34-20020a0565123d2200b00510125c8d7dsm195173lfv.140.2024.01.24.10.29.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jan 2024 10:29:53 -0800 (PST) Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2cd1232a2c7so78167871fa.0 for ; Wed, 24 Jan 2024 10:29:53 -0800 (PST) X-Received: by 2002:a2e:be05:0:b0:2cf:784:d3c4 with SMTP id z5-20020a2ebe05000000b002cf0784d3c4mr1264354ljq.35.1706120992964; Wed, 24 Jan 2024 10:29:52 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <202401240832.02940B1A@keescook> <202401240916.044E6A6A7A@keescook> In-Reply-To: From: Linus Torvalds Date: Wed, 24 Jan 2024 10:29:36 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [6.8-rc1 Regression] Unable to exec apparmor_parser from virt-aa-helper To: Kees Cook , Kentaro Takeda , Tetsuo Handa , John Johansen , Paul Moore Cc: Kevin Locke , Josh Triplett , Mateusz Guzik , Al Viro , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Wed, 24 Jan 2024 at 10:27, Linus Torvalds wrote: > > UNTESTED . and just to check who is awake, I used 'file->f_flags & __FMODE_EXEC' in tomoyo when 'file' doesn't exist as a variable. It should be 'f->f_flags & __FMODE_EXEC'. That way it at least compiles. Linus