Received-SPF: pass (google.com: domain of linux-kernel+bounces-37551-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <e96df7ac-f0b4-4300-8546-7c1df836dea2@intel.com>
Date: Wed, 24 Jan 2024 10:51:49 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] x86/resctrl: Fix unneeded variable warning reported by
 kernel test robot
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>
CC: Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>, <fenghua.yu@intel.com>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <dave.hansen@linux.intel.com>,
	<x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
	<rdunlap@infradead.org>, <tj@kernel.org>, <peterz@infradead.org>,
	<yanjiewtw@gmail.com>, <kim.phillips@amd.com>, <lukas.bulwahn@gmail.com>,
	<seanjc@google.com>, <jmattson@google.com>, <leitao@debian.org>,
	<jpoimboe@kernel.org>, <rick.p.edgecombe@intel.com>,
	<kirill.shutemov@linux.intel.com>, <jithu.joseph@intel.com>,
	<kai.huang@intel.com>, <kan.liang@linux.intel.com>,
	<daniel.sneddon@linux.intel.com>, <pbonzini@redhat.com>,
	<sandipan.das@amd.com>, <ilpo.jarvinen@linux.intel.com>,
	<peternewman@google.com>, <maciej.wieczor-retman@intel.com>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<eranian@google.com>
References: <202401241810.jbd8Ipa1-lkp@intel.com>
 <84128a3c83654493f637b8349153af10d69e2752.1706118776.git.babu.moger@amd.com>
 <39c4501e-4937-49de-b12b-742e6201df6f@intel.com>
 <20240124183153.GFZbFXmTKTLEpwZshW@fat_crate.local>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240124183153.GFZbFXmTKTLEpwZshW@fat_crate.local>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWF5dWF3bGxubDBneFVURnJmUkY3STkwU1Qxd2xGeXJpeWFIcWtyeDZMU1lq?=
 =?utf-8?B?MjlIanB5aGhQR0pRNVNHaEtLMW11TFIyMUJRR085RmtMVWtReXlXTDBaTlRY?=
 =?utf-8?B?OVhheTNnVkV0T2w1Q1hrUzkvUFZXM1gzNkZGRy94L3RCa2w5bVc2MXJHV3F3?=
 =?utf-8?B?TkFodnlnTnFMWWlTaHlMNjNXbWNaTDRBaUovRjRmMllMUTBsOUtJWkJraVpu?=
 =?utf-8?B?T1JLSUVkOHY0Q3BNeGk5ZkpQMWh1THdPeExjN2JGUHZKc0d0VWZuZGhQVjdt?=
 =?utf-8?B?aTFUZGdVVUdCRlhEMmVxTWtYY3lxVE5pVzFTbHo1SVh4eVorK29RUTVYWGt2?=
 =?utf-8?B?Y3RkdGxnR2hLUXU0NzRFWHo2Ri9iRWZaZ3FSeFo0V3pQUC9ZUHI5bmZJZkJI?=
 =?utf-8?B?bUozcWRYV2gzL1hRVy9SYjliaExxbStLdHNjVk9WbjY2UldnYnp0bkEzODBt?=
 =?utf-8?B?NGNILzhZSmRZK2xtQ1cvSmorcHY3QWRDcHlSekt0bDR4VEtJcmx0VnRFSU9X?=
 =?utf-8?B?RUlzMlZRNlIvajd3RjlDNGo1VGZMamVWNW1MQ1ZRczIvNDEvQmVvTk9yUkU3?=
 =?utf-8?B?ZXFZeng2aGVjK3pxTmZVUTE1cm9YaE9ISFhGSk5iZGk1SXdRQlVVMURpSkxt?=
 =?utf-8?B?QTBFcUtQbElKclpXUFBpVmZnV1RJMmgveTduQXJYallhU0dWbDl5LzJHUmwy?=
 =?utf-8?B?ZW5NU09qOVRCb3BFZGxmTjhGZGF2eU8wRDR1WE9RVnVBanpQbGU1VHBhanZJ?=
 =?utf-8?B?M09pMXhvb0c1anFuNHo0Slp1OVZ3UkdtbXJXTWJrQ0YyZURRU2EwMC9JNmhT?=
 =?utf-8?B?Zmg0aHprWHpFdVlwK2swTWRXYTdPQ0x6NXZsTnE3clI5MW94RW4zQ0N2bTBn?=
 =?utf-8?B?UmlVOUw3eDdsKzVDSFpVUlY0Zjl3dFVGQitudTljM00zb2oycFRFRGlQZSs5?=
 =?utf-8?B?SWF1dnZjaS9XSmhrMjdYdHJiTklyajRKR3daL3F4N0tTTk1lSlN0UlVzTENo?=
 =?utf-8?B?bldSLzgwN1NJZmpLUmlsWTd5RmRuS2Z5aVhYZUFwQ3RURmtWcE02TEhWTHBx?=
 =?utf-8?B?RlJqeVFPWGJMeXRDYm1ubWdoZmtoMVpOSXZDejhmM2JURkFDbDcwKzF2RDRx?=
 =?utf-8?B?YzdtS0VZby9kYTZwVis3Y0JMSDdxRUthVGZUOU5PVkNhK0tTeUlWZUhoaDhm?=
 =?utf-8?B?V3p5UVNPUkxrTnhTMWp1UGlhNFcwVnpCTWJ0eEZDbWE0NFdRREFaeFVYTi91?=
 =?utf-8?B?cTl1UDF1OEtPZGFhb1AveGtkdmFzeWd5SlVZNHJVWHNlYTdRS1VnbG15ZkpW?=
 =?utf-8?B?dWF6OXcwcWtlTjZHbnhBZStkNElUaktBaTNqZFVld2EwYVlOYzhYcU4vN1pr?=
 =?utf-8?B?bk5mRHJCZlJVMndvbzByeHgyUDRSQjhZcTB2eWkyaW1TVlVVU21PWnhEZTZ3?=
 =?utf-8?B?SzhjT3ZLTXRkYjArS1A1SFppODI1QnpoYnNPdE1KczhYZU5QZlFBUXRwdnJE?=
 =?utf-8?B?aE82Situcm9CQUk2dm5Fa3BVYXN3N09MTkZXVWhUc25ISFdnaWZHUXdUeFlE?=
 =?utf-8?B?RHU5bTN5Z2dIRHV6dG9aNytFdDQ4VnQzUGFEYTFHNEljQzZEOHVLeHdmZ2Zn?=
 =?utf-8?B?VmVhcEV3bTJITUxFVUNSdjl0SFlVYjNxZlpqdTdFV2ZQMDdIeHhXbjM1TUFX?=
 =?utf-8?B?TElVTmxUUktLUHR2OS9RR2RoVExnMXpHRTZuWk5UbGhObWV4eW53azlrNGZp?=
 =?utf-8?B?NXBGMkRON1kzVS9YT1pRQys4VGR5MEwzNDIwS0JyNFBnNlRFVENTV045alRK?=
 =?utf-8?B?eVJ0RXBBWklvL3dPVGlaNmlhT1d2R25LMEl4VGNUNlhXWE9LMFBLRWt4eGh4?=
 =?utf-8?B?Y3kraW56OGVhUmFlejUwSWNTSmNoNmhCRmpUVVJhazFaV3FFc0MxT0kxYjNH?=
 =?utf-8?B?UHQ0NmJxZTZKWDhiaGtWckFPWlErVmhDK3FpMVNmZ1VzUUZ4YWQ3RnVTT3Qz?=
 =?utf-8?B?U2VKT2lGMStLSzZGRXduNnZ2WWFUUGdaMUp0MGlFbDNMa1RZUUp0TWNFR0ZS?=
 =?utf-8?B?RENvd0t4WFZ5QWg0MmRxOXRzQ3lkWERQWFZBUEhqaWxSMkYreWNiaURUMTZo?=
 =?utf-8?B?L3ZpbWNPVmFOS3p1QmdvRE5Pa1JUdmZjUVF3UTdOT0RneVBTSFlVT0U0eE52?=
 =?utf-8?B?MHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d440179a-06d4-4ed2-f6e0-08dc1d0d8777
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2024 18:51:52.6133
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 33zj41ghIFrY2NtAehUP5h85H0y8j+4J4/Lcl2krSWqRf9nbXjU3t2GnSyhzyvd7ZmzYnjtKxUBqdT7qILo29g50Gp5cQYoTFvsjFDASWeY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7397
X-OriginatorOrg: intel.com

Hi Boris,

On 1/24/2024 10:31 AM, Borislav Petkov wrote:
> On Wed, Jan 24, 2024 at 10:25:17AM -0800, Reinette Chatre wrote:
>> This can be confusing since it implies that the patch you mention
>> introduces the issue but instead the variable has been unneeded since
>> the original:
>> 92bd5a139033 ("x86/resctrl: Add interface to write mbm_total_bytes_config")
> 
> What I said. :)

Right from the start, yes.

> 
>> To help clarify you can mention this order of events and also add an
>> appropriate "Fixes:" tag.
>>
>>> cocci warnings: (new ones prefixed by >>)
>>>>> arch/x86/kernel/cpu/resctrl/rdtgroup.c:1621:5-8: Unneeded variable: "ret". Return "  0" on line 1655
>>>
>>> Fix the warning by removing the variable "ret" and returning 0 directly.
>>
>> cocci warning was spot on*. This fix is not just a change to "make a
>> warning go away" but instead fixing an actual problem.
>> It can just be "Remove the unneeded variable and return 0 directly".
> 
> I'll fix all up before applying.

Thank you very much. For what it is worth, I do agree with the actual fix
and you can add:
Acked-by: Reinette Chatre <reinette.chatre@intel.com>

> 
>> * I'll add a private setup with the goal to catch these earlier.
> 
> Except that it doesn't fire with the patch that added the code. It looks
> like the cocci script needs adjustment...

Reinette