Received-SPF: pass (google.com: domain of linux-kernel+bounces-37553-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <5f5a2ecd-7878-46ba-9a85-a2a4ba060ad7@ti.com>
Date: Wed, 24 Jan 2024 12:52:09 -0600
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] ARM: configs: keystone: Remove this defconfig
Content-Language: en-US
To: Nishanth Menon <nm@ti.com>
CC: Russell King <linux@armlinux.org.uk>, Arnd Bergmann <arnd@arndb.de>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Santosh Shilimkar
	<ssantosh@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>
References: <20240124162857.111915-1-afd@ti.com>
 <20240124162857.111915-2-afd@ti.com>
 <20240124164116.k5ah56xvuclfkxdr@despise>
 <0ab47165-3ba3-4d34-aea0-9bc12fd5ff31@ti.com>
 <20240124180451.bptuhldi44leulr3@pectin>
From: Andrew Davis <afd@ti.com>
In-Reply-To: <20240124180451.bptuhldi44leulr3@pectin>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

On 1/24/24 12:04 PM, Nishanth Menon wrote:
> On 11:31-20240124, Andrew Davis wrote:
>> On 1/24/24 10:41 AM, Nishanth Menon wrote:
>>> On 10:28-20240124, Andrew Davis wrote:
>>>> TI Keystone devices can and should use the common multi-v7 defconfig.
>>>> Currently it is not clear which defconfig should be used and so config
>>>> options for Keystone boards are added to either both defconfigs, or only
>>>> one or the other. As nice as it is to have a config just for this platform
>>>> it is a maintenance burden. As it is not used by generic distros it is not
>>>> very useful to continue to maintain. Remove this defconfig.
>>>>
>>>> Signed-off-by: Andrew Davis <afd@ti.com>
>>>> ---
>>>>    arch/arm/configs/keystone_defconfig | 238 ----------------------------
>>>>    1 file changed, 238 deletions(-)
>>>>    delete mode 100644 arch/arm/configs/keystone_defconfig
>>>>
>>>
>>> There are a bunch of downstream folks who will have recipe fails etc if
>>> we do that. I am not sure we need to go down that route.
>>>
>>
>> That is the point of this patch, we want to stop any remaining downstream
>> folks from using this defconfig. It is not maintained nor updated like
>> the multi_v7_defconfig, any new or needed options will only be added to
>> multi-v7 defconfig.
>>
> 
> I am going to have to defer to ARM maintainers what they think..
> enabling LPAE etc in common multi_v7_config.
> 

We are not enabling LPAE in common multi_v7_config, that can't be
done as many plats do not support it. Keystone will use the new
multi_v7_lpae_defconfig which was just added:

e9faf9b0b07a ("ARM: add multi_v7_lpae_defconfig")

That is what prompted me to make this change, we now have a
commonish config that works for Keystone.

Andrew


> --
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D