Received-SPF: pass (google.com: domain of linux-kernel+bounces-37610-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-119-ga8b98d1bd8-fm-20240108.001-ga8b98d1b
Precedence: bulk
MIME-Version: 1.0
Message-Id: <1d13250c-e48b-4e31-b449-5b54837a0d40@app.fastmail.com>
In-Reply-To: <20240124182256.776c164b@xps-13>
References: <20240122153442.7250-1-arnd@kernel.org>
 <20240124182256.776c164b@xps-13>
Date: Wed, 24 Jan 2024 20:49:53 +0100
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Miquel Raynal" <miquel.raynal@bootlin.com>,
 "Arnd Bergmann" <arnd@kernel.org>
Cc: "Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
 regressions@lists.linux.dev,
 =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= <rafal@milecki.pl>,
 "Chen-Yu Tsai" <wenst@chromium.org>,
 "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, asahi@lists.linux.dev,
 "Sven Peter" <sven@svenpeter.dev>, "Michael Walle" <michael@walle.cc>,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvmem: include bit index in cell sysfs file name
Content-Type: text/plain

On Wed, Jan 24, 2024, at 18:22, Miquel Raynal wrote:
> arnd@kernel.org wrote on Mon, 22 Jan 2024 16:34:10 +0100:
>
>> From: Arnd Bergmann <arnd@arndb.de>
>> 
>> 
>> As far as I can tell, this is a problem for any device with multiple cells on
>> different bits of the same address. Avoid the issue by changing the file name
>> to include the first bit number.
>
> There is only one bit number right? We are talking about byte offsets
> so this value can only range from 0 to 7? If we understand each other
> correctly then why not, I'm fine with the extra ",0" thing.

On the Apple M1, the nvmem registers are 32 bit wide, so the
bit numbers can go up to 31. I can imagine some system using
64-bit registers, but it's unlikely to be higher than that.

      Arnd