Received-SPF: pass (google.com: domain of linux-kernel+bounces-37274-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Wed, 24 Jan 2024 17:42:14 +0200 (EET)
To: Dan Carpenter <dan.carpenter@linaro.org>
cc: Jingoo Han <jingoohan1@gmail.com>, 
    Gustavo Pimentel <gustavo.pimentel@synopsys.com>, 
    Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>, 
    Lorenzo Pieralisi <lpieralisi@kernel.org>, 
    =?ISO-8859-2?Q?Krzysztof_Wilczy=F1ski?= <kw@linux.com>, 
    Rob Herring <robh@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>, 
    linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, 
    kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v4 2/2] PCI: dwc: Cleanup in dw_pcie_ep_raise_msi_irq()
In-Reply-To: <64ef42f0-5618-40fd-b715-0d412121045c@moroto.mountain>
Message-ID: <d38e9f8f-ade9-8e77-2d19-756f76ecec76@linux.intel.com>
References: <64ef42f0-5618-40fd-b715-0d412121045c@moroto.mountain>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-442463817-1706110934=:1372"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-442463817-1706110934=:1372
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Wed, 24 Jan 2024, Dan Carpenter wrote:

> I recently changed the alignment code in dw_pcie_ep_raise_msix_irq().
> The code in dw_pcie_ep_raise_msi_irq() is similar so update it to match
> as well, just for consistency.  (No effect on runtime, just a cleanup).
>=20
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> v4: style improvements
> v3: use ALIGN_DOWN()
> v2: new patch
>=20
>  drivers/pci/controller/dwc/pcie-designware-ep.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pc=
i/controller/dwc/pcie-designware-ep.c
> index 51679c6702cf..d2de41f02a77 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-ep.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c
> @@ -482,9 +482,10 @@ int dw_pcie_ep_raise_msi_irq(struct dw_pcie_ep *ep, =
u8 func_no,
>  =09=09reg =3D ep_func->msi_cap + PCI_MSI_DATA_32;
>  =09=09msg_data =3D dw_pcie_ep_readw_dbi(ep, func_no, reg);
>  =09}
> -=09aligned_offset =3D msg_addr_lower & (epc->mem->window.page_size - 1);
> -=09msg_addr =3D ((u64)msg_addr_upper) << 32 |
> -=09=09=09(msg_addr_lower & ~aligned_offset);
> +=09msg_addr =3D ((u64)msg_addr_upper) << 32 | msg_addr_lower;
> +
> +=09aligned_offset =3D msg_addr & (epc->mem->window.page_size - 1);
> +=09msg_addr =3D ALIGN_DOWN(msg_addr, epc->mem->window.page_size);

After you've added the #include in 1/2, for both patches:

Reviewed-by: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>


--=20
 i.

--8323328-442463817-1706110934=:1372--