Received-SPF: pass (google.com: domain of linux-kernel+bounces-37693-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <7d6e3d39-ce53-40e4-bba5-242911a1522a@intel.com>
Date: Wed, 24 Jan 2024 13:31:01 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] x86/resctrl: Fix unneeded variable warning reported by
 kernel test robot
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>
CC: Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>, <fenghua.yu@intel.com>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <dave.hansen@linux.intel.com>,
	<x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
	<rdunlap@infradead.org>, <tj@kernel.org>, <peterz@infradead.org>,
	<yanjiewtw@gmail.com>, <kim.phillips@amd.com>, <lukas.bulwahn@gmail.com>,
	<seanjc@google.com>, <jmattson@google.com>, <leitao@debian.org>,
	<jpoimboe@kernel.org>, <rick.p.edgecombe@intel.com>,
	<kirill.shutemov@linux.intel.com>, <jithu.joseph@intel.com>,
	<kai.huang@intel.com>, <kan.liang@linux.intel.com>,
	<daniel.sneddon@linux.intel.com>, <pbonzini@redhat.com>,
	<sandipan.das@amd.com>, <ilpo.jarvinen@linux.intel.com>,
	<peternewman@google.com>, <maciej.wieczor-retman@intel.com>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<eranian@google.com>
References: <202401241810.jbd8Ipa1-lkp@intel.com>
 <84128a3c83654493f637b8349153af10d69e2752.1706118776.git.babu.moger@amd.com>
 <39c4501e-4937-49de-b12b-742e6201df6f@intel.com>
 <20240124183153.GFZbFXmTKTLEpwZshW@fat_crate.local>
 <e96df7ac-f0b4-4300-8546-7c1df836dea2@intel.com>
 <20240124191429.GGZbFhldYr3K85H9cg@fat_crate.local>
 <6635c607-cab2-45f4-a0fe-ff4f53b36849@intel.com>
 <20240124204525.GIZbF25bekUME2flt0@fat_crate.local>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240124204525.GIZbF25bekUME2flt0@fat_crate.local>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dTFxQ2RTcmlMa0ZLV3hRN2RWRzNLTjQyT1lnK0VtQlA4ZkNqdHhjUFh5UzlL?=
 =?utf-8?B?TnE3dTlvYlRYOTM3T0NTaGhSSURycnFkMm81dUlyWEJJcjVibFJxMXIremJy?=
 =?utf-8?B?NFUyV1FEOEViWCtleGtTdVhhbkVoRkdHMTh2TlZvcXFhaWNyc2Fra1EwZk1y?=
 =?utf-8?B?MXdNcmxlZk9rQk1UQ3lIL09pczl6enVmRklwR0FXN1pnMmIvNkJWaHhjZVpM?=
 =?utf-8?B?R2xObDZKL09BZmUzdW1nNTlGd0FBdzRJclYzc1dXaFNZZVRKbWFFalNmazFI?=
 =?utf-8?B?Kzh4eHBnQ2lDRU9obGsxc0NKZVVuakwzWHlKdUxOVWE5NXNaWDFPL2NTYjds?=
 =?utf-8?B?Z2I0SGRRY1pTcE5jc0tqRmI1djNDT05xbDZhc2FtdlJwdzBxb1dHaCtOb3M0?=
 =?utf-8?B?WDdaTXd4cExCY1BiVVI3QjB1OGUwZHFxajlzNFdZMnNlbGJqOUV0TEZ6NkV4?=
 =?utf-8?B?MFY2MC93Q3QxV095TXlZTTR4RHhMWm9tZ0VhekJtNnZRZURWMjgyOG81TldB?=
 =?utf-8?B?dktKc0tiYlNHSmI5T3phcXN1Q3hZOUZVMEZLQjlreUdrUjJ3STF3c05tdDlm?=
 =?utf-8?B?OFZsM2FBUFl1OWRpRys5N1EwUmVUaTllLzgzVlRVYXNBb2pSWCs2aEtycGl2?=
 =?utf-8?B?UzQ2aG4yc0IvUmlNNHJESE02b2E0eWdlbjIrTFA1TVZ5K05YUzRmdkFrUncy?=
 =?utf-8?B?aENOaUtqUGZvZHM4UzZBOGE2Z3pxSFVFL1NjYm1RaTA2aVFKWk5rUElrRFdo?=
 =?utf-8?B?QmJmYUhSTXlnbGFGN2lGdzJFcnNNVWJqMlJ2dWlmYUQ5R0xibGdtSkpXRnZW?=
 =?utf-8?B?L0tJUXdDaWpjUHFYZlFadHZDbkR6ZktNM3p2ODFmY2ZmdXZ1NnN4R1pnY2Zl?=
 =?utf-8?B?T2h0ZkgvclFRSE1JeW1WS1BvdFo5WnVRK1lIekRSWGw5aS9vaUJsOXBzQnhM?=
 =?utf-8?B?UkE2OXliNThmWTZseW84OXVNT0huZnpNOTNabU5WZnZKTUgrbDF0ZUd3d1lZ?=
 =?utf-8?B?cEZSeHdsenFqUXRQZDN3YjlQaG1KZVlGcXZSSGczNUNaSUM3ZGdnZXlrejRW?=
 =?utf-8?B?dVNFbjhBb096U0lva2ptblNOVGRVUGsyK1I5TUZNMFpHOGVkVThXSVdwd1NN?=
 =?utf-8?B?V2FPbUEvN1Bma2JBVlFEUDNGemEvOE5jMkZJR1hKbTZsUHVoZU5ucjZaQTA4?=
 =?utf-8?B?MXpxQWJvaHZKK01QUFNLVVdrcEhrNjJGNXJLTm54ZUVJMzNESThPeHJjbVBm?=
 =?utf-8?B?QlBiRUxYZURNU01QVWhkc3NyWFRTTFVXVWJQdnJuZUF5Z3RQK2p4ZFZGL3Av?=
 =?utf-8?B?L0RXb0pzRlliYzZRWWxhaXI2bldkQ1dEOFM0cWxvSklpdzVQbkg5VGlsZjRS?=
 =?utf-8?B?RDNtTDFuT21GUURpVUVHUGtxY2pYc0xGK1NMY2ZEZ2ZmQUx4LzZScGtTcG9X?=
 =?utf-8?B?elZFN0p5NTRkODkvcUFiNFNwTnh2eWJ0dUtQaStaZ3lXc2ZDWHhsL2FNKzBN?=
 =?utf-8?B?cnBYUzM2eFRYRGNUbWJ0NEpSMHpGUituYWJ0cXFLTDVtYllkY0lvTy9RVXp4?=
 =?utf-8?B?RGttUXBvbVV2QksxTjNwNEJnRjdNZjRCMXN6ZkNzaDUzeWs4cy95RHRsKzUv?=
 =?utf-8?B?R1BncU1lSVFtNGs2UHNXd0tVZ0tQOW1YRTB2NktwakJ1elZxU1pOTzlZTTIy?=
 =?utf-8?B?K1FPOUZNL3I3M1haY3JsUmh0SDhVK2ltbXpDS0dHbHBQeG9QMjZlbkx1MERJ?=
 =?utf-8?B?YTNGd2NaZ3phNmdjZ1FmN0RMZW5tNHhzQTZGV3BNRitmTWF3UEp6b2Z1dEFR?=
 =?utf-8?B?d0FSdzZGTlorVGVUUk5GSU1JajdEczR0NEIzTnUvbTdKaTZCa05VNVFNSGFK?=
 =?utf-8?B?QUpSUnhabSt6Z1pXNUdXeFJ3V2YrVVUwRzNPUlFLR3o5M3JBcE9EZ0VldWZx?=
 =?utf-8?B?OFo0V3crc3JjSDZQUFl2RWFYUXJxZlZzbHJVaG1tYWxRUDJGY1BIY0IrRU9V?=
 =?utf-8?B?aytQRC9Vbmw2cTVYQ0RNeDNKa1RNL1JWcm9BVGJoQTRtUUx6ckxxaDhzNGs1?=
 =?utf-8?B?TTJyUmJNS3hzMFI2MHJhb2IydVJ6RUpQVXFMTjRudUhpQXNuVUdUMnkwYUhv?=
 =?utf-8?B?R25GTEdtM3l3d1pLaUVWVitSMy9aZG1uUEJ2UVJncklaY2ZrODNuMGkybk5p?=
 =?utf-8?B?VVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3fed8084-6e3f-45b2-d0cf-08dc1d23c5a4
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2024 21:31:05.8552
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s0TUfOp2oTL3Vsd/U4T42QteIGItiL+Iuv2OhUherhEhJamJJKGLGB5YYgphy0U1kPJoKTMWgnasxg+1M/b/mLEDA+wja0oG28FzoRDggSU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4516
X-OriginatorOrg: intel.com

Hi Boris,

On 1/24/2024 12:45 PM, Borislav Petkov wrote:
> Hi,
> 
> On Wed, Jan 24, 2024 at 12:04:31PM -0800, Reinette Chatre wrote:
>>>   54e35eb8611c ("x86/resctrl: Read supported bandwidth sources from CPUID").
>>
>> I think a "commit" prefix is required here and below.
> 
> Yeah, but if you see a 12-char sha1 followed by a title in (" "), that
> is a commit and nothing else, right?
> 
> If I say "commit" too it is kinda redundant.

I do not know the motivation for that requirement. From what I can tell the
change [1] that added that check went in as first version without discussion.
[1] starts by saying that the format is "preferred" so I assume there is
some history that I am not familiar with.

Reinette

[1] https://lore.kernel.org/all/976c6cdd680db4b55ae31b5fc2d1779da5c0dc66.camel@perches.com/