Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp1390848rdb; Wed, 24 Jan 2024 13:55:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IHbqErbZUI6BVtiP5JTa5oBQIoXTV5hBODTYZaScfijNdIV/DeE0auSUyETlwAkFafrYwKa X-Received: by 2002:a81:a24c:0:b0:5ff:9555:79df with SMTP id z12-20020a81a24c000000b005ff955579dfmr1455237ywg.92.1706133341991; Wed, 24 Jan 2024 13:55:41 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706133341; cv=pass; d=google.com; s=arc-20160816; b=qIeBH4oZfYmXPmS7jzZOUfrD1txAXQQYFwFSSPV7KpUIKIMjdSaslw2W9wUzbP0/hy jjWinrj3SPIuwCK3CLaQP+QBBE/Psh9rAgnJdm07bTBNooDiwT7+kWFDYl/g7jurVlMw TqtYvI1EhsA4AYtObNAOeeszL+CoFGiR1tBIu9YyMXKlO0lazwr/ev/YOY1sHMQEIRLI dTAEMiWdOfCvImT/CUrfH883m/Qy/+7obhrJ5vWuDKrvwEsfsJACTjgm+sDsKKmTxUIO thEC7LKevGqUS8XLal//9Q8zCJZYcu/av4pt2lY3GAMYyLujbOb2cODf2GCnOlE8lfqM Dbfg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:references:in-reply-to:date:cc :to:from:subject:message-id; bh=s1HLusChsYpWmBVhgj7/54BzW/OoXzTjrKBZOX3pd5I=; fh=m6Rv84myqMl/bL2OKMYjifazvL8mIsjgckS+uIj/WJ0=; b=ul7t0UeVZ41S/gQZQ3CiJfVvWfErDboJYW6hbkIXXJ/GuZ3jsja7ZZ36jbl1is6pYr h78mjoHzw4AEfno6EFdjskEJxfyzEp70z7HW8fEr1IKjrn59zkmPBmPcUXLgJ1KCUVe5 qdKCrIvZZXlbTULmt8BghL5zPCeFWIRv0raw8gHVSASWk0LZjv2VkAfo19DKF2DE4Whb W1PX5pvS1cLY0VOecehgCbcFZz0u2wdrNVACzfTxoxR+dW31t5QB/dxzV6m1J3rrfVM/ m0xq7FOJ8ZnvvquijQ0NTu3mYmDUCwK262UXdJUAyE/d9DMVq9NizEt0yxwTYn9rIwDl eTcg== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=irl.hu dmarc=pass fromdomain=irl.hu); spf=pass (google.com: domain of linux-kernel+bounces-37715-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-37715-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=irl.hu Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id h22-20020ac85856000000b0042a5ad0c64fsi3044178qth.3.2024.01.24.13.55.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 13:55:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-37715-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=irl.hu dmarc=pass fromdomain=irl.hu); spf=pass (google.com: domain of linux-kernel+bounces-37715-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-37715-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=irl.hu Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id BCA101C2434B for ; Wed, 24 Jan 2024 21:55:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 33D5D13540C; Wed, 24 Jan 2024 21:55:18 +0000 (UTC) Received: from irl.hu (irl.hu [95.85.9.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85A281353FE; Wed, 24 Jan 2024 21:55:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.85.9.111 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706133317; cv=none; b=B/dYVmSicFVc+u6H+DGwiqAS8b7uEsTbpi/082OA4QE4X9MYSF6f/zH6nC7szl6KODHvzZxgCoMstxyKTtaNoPQyhPwCs6zRNBSelbbgayNtjWjapnIbhb3hfcUB06JJMMYdXuj5GUKiQxwCMWiHsT+kyNa/ID/VZNpIqiLb05M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706133317; c=relaxed/simple; bh=309aYL4WHgnoj7cp3YCClCX/HORT29FwxxqIu388QIM=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=MytwKrReNPe5jQJ3ZfQ0i783KajgsL5oTh2Foa3H3zk+BWf6A0GC6E54W2UMpFe/r44JxNQ4Zj8d7lI/hnSwGMoIQSJnX/M6pu0uBjodD0b03A4O5MSkgg0Szw/GzopnjCU+ScpxqPz/W9UKt1UO1pakD+i/BUL211RBFsRXVew= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=irl.hu; spf=pass smtp.mailfrom=irl.hu; arc=none smtp.client-ip=95.85.9.111 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=irl.hu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=irl.hu Received: from [192.168.2.4] (51b68f75.dsl.pool.telekom.hu [::ffff:81.182.143.117]) (AUTH: CRAM-MD5 soyer@irl.hu, ) by irl.hu with ESMTPSA id 0000000000070DBE.0000000065B1873B.0018A6D1; Wed, 24 Jan 2024 22:55:07 +0100 Message-ID: <4dbee9d8524da296b185ba0fe6827249c93eebd6.camel@irl.hu> Subject: Re: [PATCH 0/2] ALSA: hda: Move component binding support into separate library From: Gergo Koteles To: Richard Fitzgerald , tiwai@suse.com, shenghao-ding@ti.com Cc: perex@perex.cz, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, alsa-devel@alsa-project.org, patches@opensource.cirrus.com Date: Wed, 24 Jan 2024 22:55:07 +0100 In-Reply-To: <20240124112607.77614-1-rf@opensource.cirrus.com> References: <20240124112607.77614-1-rf@opensource.cirrus.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.3 (3.50.3-1.fc39) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Richard, On Wed, 2024-01-24 at 11:26 +0000, Richard Fitzgerald wrote: > The Cirrus Logic amplifiers are currently paired with Realtek HDA codecs. > But they could be used with other codecs. To prepare for this, these two > patches move the manager side of the component binding out of the Realtek > driver into a library module. >=20 > The first patch tweaks the CS35L41 code so that it is not hardcoded to > CS35L41, and changes the TAS2781 handling so that it re-uses that code > instead of having a near-identical copy of it. >=20 > Can someone please test that these two patches don't break TAS2781? > I have checked that they should work in theory but I don't have hardware > to test on. >=20 It works on a Lenovo Yoga 7 14ARB7 laptop. Tested-by: Gergo Koteles Regards, Gergo > Richard Fitzgerald (2): > ALSA: hda: realtek: Re-work CS35L41 fixups to re-use for other amps > ALSA: hda: realtek: Move hda_component implementation to module >=20 > MAINTAINERS | 1 + > sound/pci/hda/Kconfig | 4 + > sound/pci/hda/Makefile | 2 + > sound/pci/hda/hda_component.c | 169 ++++++++++++++++++++++++++ > sound/pci/hda/hda_component.h | 59 +++++++++ > sound/pci/hda/patch_realtek.c | 217 ++++------------------------------ > 6 files changed, 261 insertions(+), 191 deletions(-) > create mode 100644 sound/pci/hda/hda_component.c >=20