Received-SPF: pass (google.com: domain of linux-kernel+bounces-37729-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 24 Jan 2024 23:11:20 +0100
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: "Arnd Bergmann" <arnd@kernel.org>, "Srinivas Kandagatla"
 <srinivas.kandagatla@linaro.org>, regressions@lists.linux.dev,
 =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>, "Chen-Yu Tsai"
 <wenst@chromium.org>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
 asahi@lists.linux.dev, "Sven Peter" <sven@svenpeter.dev>, "Michael Walle"
 <michael@walle.cc>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvmem: include bit index in cell sysfs file name
Message-ID: <20240124231120.562f06f3@xps-13>
In-Reply-To: <1d13250c-e48b-4e31-b449-5b54837a0d40@app.fastmail.com>
References: <20240122153442.7250-1-arnd@kernel.org>
	<20240124182256.776c164b@xps-13>
	<1d13250c-e48b-4e31-b449-5b54837a0d40@app.fastmail.com>
Organization: Bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Arnd,

arnd@arndb.de wrote on Wed, 24 Jan 2024 20:49:53 +0100:

> On Wed, Jan 24, 2024, at 18:22, Miquel Raynal wrote:
> > arnd@kernel.org wrote on Mon, 22 Jan 2024 16:34:10 +0100:
> > =20
> >> From: Arnd Bergmann <arnd@arndb.de>
> >>=20
> >>=20
> >> As far as I can tell, this is a problem for any device with multiple c=
ells on
> >> different bits of the same address. Avoid the issue by changing the fi=
le name
> >> to include the first bit number. =20
> >
> > There is only one bit number right? We are talking about byte offsets
> > so this value can only range from 0 to 7? If we understand each other
> > correctly then why not, I'm fine with the extra ",0" thing. =20
>=20
> On the Apple M1, the nvmem registers are 32 bit wide, so the
> bit numbers can go up to 31. I can imagine some system using
> 64-bit registers, but it's unlikely to be higher than that.

In this case we will soon or later have a problem again. Can we include
the full offset of the bit and not just the first digit?

Thanks,
Miqu=C3=A8l