Received-SPF: pass (google.com: domain of linux-kernel+bounces-37732-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <a917a6f4-eb54-4ce9-b893-38b3d3178138@nxp.com>
Date: Thu, 25 Jan 2024 00:12:29 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/9] remoteproc: imx_rproc: Use devm_rproc_alloc() helper
Content-Language: en-US
To: Andrew Davis <afd@ti.com>, Bjorn Andersson <andersson@kernel.org>,
 Mathieu Poirier <mathieu.poirier@linaro.org>, Shawn Guo
 <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>,
 Pengutronix Kernel Team <kernel@pengutronix.de>,
 Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>,
 Konrad Dybcio <konrad.dybcio@linaro.org>,
 Patrice Chotard <patrice.chotard@foss.st.com>,
 Maxime Coquelin <mcoquelin.stm32@gmail.com>,
 Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
References: <20240123184632.725054-1-afd@ti.com>
 <20240123184632.725054-2-afd@ti.com>
From: Iuliana Prodan <iuliana.prodan@nxp.com>
In-Reply-To: <20240123184632.725054-2-afd@ti.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UGZ2ZE56RGFaVERzV0ZuN1k0V1hwbVZoTHRVejg0YUVvdnpENVZlem9Hd2Qv?=
 =?utf-8?B?SGlTbmxhajZ4SWRDaHVBZ0lqSkV6VlFPSDMwNDFLZGdIWE9aY2RsbktuS1dB?=
 =?utf-8?B?djZEb1poRndES1Fwb05rcGV6c2RySnp3M2lxdEVmMkF6RlBVdDVXcFZhclYz?=
 =?utf-8?B?MEc4dEkvWTVIcDRseG5mcjR6bE1uRHE4eU4zdHl5aFczNkpuKytEZktwM0cx?=
 =?utf-8?B?eWNEWm85TWI3Kzl1U1NZUU45TkhWWUhmaW9ySHVyWWNnT3ZRTlRON3NnQ2Jz?=
 =?utf-8?B?a3kxS0hJcWtxQS9rVk81dUlVa2ZETVFYeFgySklKYzhaZ3E3b29yeXo3YW1a?=
 =?utf-8?B?dFNDMnd6WW9mUHdSbWFOcGpQTUdRK2hGQ3FUaFpiSlJMdHZjR3RVaENXR1Bx?=
 =?utf-8?B?UEg2SUhDdHpRR0tscW03Q2hFaGdFOTBVNlVmWXpzQ2xoZnBQYnBDT25iWlNl?=
 =?utf-8?B?azd6UHk4aXhzRG0rZktKMWp4ZVFhOXdSeVE5YSswTHRyVkxaMU1za0l1VnF5?=
 =?utf-8?B?RXdEcFBlNk0yT05zYSs3MnVBbzBDMGx0OU13KytmVlgva3VrZldua3hsQWV0?=
 =?utf-8?B?N1o1bWpYZUFlQXNodnlJNUJkOVpDUmpXVUhUUUdYbnBpQmdDY3VjQklaM3k4?=
 =?utf-8?B?bjR1V0c2d1ExV0hlMUZkY2VYNGliV2J2WG5ONUc2U3pOUTFISG05NjdmVHRR?=
 =?utf-8?B?R3B2VmxSK0cyK3Q0ZjlYSXJ3K2s5RVdPU1h4UFozZ2FJU1lSa2tqZzdLOVYx?=
 =?utf-8?B?aXlyM0ExL3NuUnpkRFREM3pXMjVzb0dITW04Tk1GUDk4Wm1Hcmo2b0pQa0lt?=
 =?utf-8?B?MlJTa2RsM0JiRlBoMTZMZzFJYVRWYTVnczVkWlVXem1Ba0VHZDlNcDlrVGg1?=
 =?utf-8?B?WGZmRmJSWTZBVW9JS292dW1sZXk2Q0t0K0ZRQ0JCWmQwL2NaMUgwc05FeTdH?=
 =?utf-8?B?NzNBS1hVTVR2K083MldQZjJXa1ZlUmt5YmJmN21ETU1Ja0I0UDNQZERhZlFK?=
 =?utf-8?B?Z2s3azVhSmcvejhvM3hWbzNVMlJycENqZ1lmL0JnVkxqVldYQ1l2NkFoOEpL?=
 =?utf-8?B?bTVzMUFhM2dULzlwczZHR2hDWEx5K05UU0d5cFI0SDdwWXdUdHRUVFFCYlRv?=
 =?utf-8?B?VGhTRWpQKzNhcUJoV3UyTUd1RHA3M0VlVDhrb3J4ZnZMdEJ5Y2dyMUUyT3NT?=
 =?utf-8?B?cXFCZHlxUStrc3gyWm9jSEtGa3ZVckMyU0RCa2djUUhydTdVcFc1MXltQXpw?=
 =?utf-8?B?ZCtkWGJCNmtrMXU3ckZFTnJjUzY1b1FvTXRnTUJ5N2dWYVNWN3dVSGtETUp2?=
 =?utf-8?B?L21SeEhSMTdoL21HSlI4Y1cySGdCSEMzQVFLMC9JbDhiOXJLcC9aWFMwdkND?=
 =?utf-8?B?TU1qeDJmcFdkSXZaUWo5dEhvQ1pwTUhvTUtmYU1xMjdSNWpMZEJRTXRtMkpW?=
 =?utf-8?B?SHgramp4MXBiQkk5WFVIcUFFR1NXdmVLcmYwYTZmM1pxNkdGVHZIVzZPSXU3?=
 =?utf-8?B?QkRNdkNLeUZnekhaRDBXYmtWcGk1eGdudkx5dG1KREVNMk5YY0MvWkZOL2RK?=
 =?utf-8?B?cDgzbno0a0FOd0ZDZzRCN3ltb1V0ZlFRa1gyQnh2TFBObFNUWk1xQmxvM3U3?=
 =?utf-8?B?U2dPS052YjlxN3lTM2t6QnNzTnpZVVZtaWNhNE9XMnVrUXg2UktEVU9FQjd1?=
 =?utf-8?B?TTVhb1Z2TmlLbmFNcXZTZ3E1NzZ0ejlBZXVxc1hOMUtIZ2tVV0d5ZXNpVjdX?=
 =?utf-8?B?TU1UcTdqOU1ZRWYwTEswMUZMc0NUb2U1VGlZMmQ4aklXQTlKcnk1R0UrSmdz?=
 =?utf-8?B?S0hQbXhNUE85QmRrWFNKMlFhVktZMlVtWTM4R0NCa2c0cmhMdis1Q1BnWWNE?=
 =?utf-8?B?NHBCUTJadFFaOE1uUXNaRmF0NlNINHJsOW9jRmNPSHZPVWRBSnpuTjdham0w?=
 =?utf-8?B?aUdaeTgzdytZRnRyWjFBaWFUTW9MTzdTYTkrUUp3WW9XTEZ6enhCOStHb0Qw?=
 =?utf-8?B?L3VWdFFmSS9SNGQ1MjB0NUZaUE81Q2xPa2FFdFdDaWxJT2dZNlZ3d2FiVURP?=
 =?utf-8?B?dzVFV0xhdDB4U3kraW03aDQwdDMvTjlBdUhjUEhxaVR5VjI4dFNpZmg5bXEx?=
 =?utf-8?B?c3RoR3NSYlVNUDRzcjg1TWNySEtNSElua3ZtRkdmeUdoOEVpSTZaZmtzSzRK?=
 =?utf-8?B?aGc9PQ==?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f00f6ee7-8a00-43a0-5d3a-08dc1d298ee4
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8774.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2024 22:12:31.0433
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4iLmYmAbVeYtk2uFk2u/i3t6uXNjAwJk7WAyvbJ5WispPRKnB78TqUGZ8wKGaOHSi9kpYuTvup7RXVqOu0BewQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8631

On 1/23/2024 8:46 PM, Andrew Davis wrote:
> Use the device lifecycle managed allocation function. This helps prevent
> mistakes like freeing out of order in cleanup functions and forgetting to
> free on error paths.
>
> Signed-off-by: Andrew Davis <afd@ti.com>

Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>

Thanks,
Iulia

> ---
>   drivers/remoteproc/imx_rproc.c | 16 +++++-----------
>   1 file changed, 5 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index 8bb293b9f327c..55ecce3ab5f75 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -1104,16 +1104,14 @@ static int imx_rproc_probe(struct platform_device *pdev)
>   	int ret;
>   
>   	/* set some other name then imx */
> -	rproc = rproc_alloc(dev, "imx-rproc", &imx_rproc_ops,
> -			    NULL, sizeof(*priv));
> +	rproc = devm_rproc_alloc(dev, "imx-rproc", &imx_rproc_ops,
> +				 NULL, sizeof(*priv));
>   	if (!rproc)
>   		return -ENOMEM;
>   
>   	dcfg = of_device_get_match_data(dev);
> -	if (!dcfg) {
> -		ret = -EINVAL;
> -		goto err_put_rproc;
> -	}
> +	if (!dcfg)
> +		return -EINVAL;
>   
>   	priv = rproc->priv;
>   	priv->rproc = rproc;
> @@ -1124,8 +1122,7 @@ static int imx_rproc_probe(struct platform_device *pdev)
>   	priv->workqueue = create_workqueue(dev_name(dev));
>   	if (!priv->workqueue) {
>   		dev_err(dev, "cannot create workqueue\n");
> -		ret = -ENOMEM;
> -		goto err_put_rproc;
> +		return -ENOMEM;
>   	}
>   
>   	ret = imx_rproc_xtr_mbox_init(rproc);
> @@ -1167,8 +1164,6 @@ static int imx_rproc_probe(struct platform_device *pdev)
>   	imx_rproc_free_mbox(rproc);
>   err_put_wkq:
>   	destroy_workqueue(priv->workqueue);
> -err_put_rproc:
> -	rproc_free(rproc);
>   
>   	return ret;
>   }
> @@ -1183,7 +1178,6 @@ static void imx_rproc_remove(struct platform_device *pdev)
>   	imx_rproc_put_scu(rproc);
>   	imx_rproc_free_mbox(rproc);
>   	destroy_workqueue(priv->workqueue);
> -	rproc_free(rproc);
>   }
>   
>   static const struct of_device_id imx_rproc_of_match[] = {