Received-SPF: pass (google.com: domain of linux-kernel+bounces-37730-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <04ea2835-518a-4829-b70a-66043c3acf0e@nxp.com>
Date: Thu, 25 Jan 2024 00:11:47 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/9] remoteproc: imx_dsp_rproc: Use devm_rproc_alloc()
 helper
To: Andrew Davis <afd@ti.com>, Bjorn Andersson <andersson@kernel.org>,
 Mathieu Poirier <mathieu.poirier@linaro.org>, Shawn Guo
 <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>,
 Pengutronix Kernel Team <kernel@pengutronix.de>,
 Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>,
 Konrad Dybcio <konrad.dybcio@linaro.org>,
 Patrice Chotard <patrice.chotard@foss.st.com>,
 Maxime Coquelin <mcoquelin.stm32@gmail.com>,
 Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
References: <20240123184632.725054-1-afd@ti.com>
Content-Language: en-US
From: Iuliana Prodan <iuliana.prodan@nxp.com>
In-Reply-To: <20240123184632.725054-1-afd@ti.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?L21FQXhPbzMzeVhUTXJqelBFdTk1U0RkYzdFTXVzWlBmQ1kreHdocmFNQ3JZ?=
 =?utf-8?B?dVo4YkIzaGRXaGJGZ0FGaWdlS29ORm8zOS8wNWR3Z3BMa3NqSnF3Q3h4ZHJR?=
 =?utf-8?B?WlVJN0ZqeVF6c2hqYXFDU3I0RTVQSzh5aVN0UjFkQk9NQ1ZDWTR6M2tZMmJY?=
 =?utf-8?B?bDZDTS80eW4vVTZJSEg3ZFZQVmQ0QU9FSW1pNTN6QXoxQlRJMTlWdTUwdHRJ?=
 =?utf-8?B?OEY2RzFpZ0ZmSGdGQ092QnhQcmErWWlJcHEyL3VJTUxYcHN3eUpNdENMNGlk?=
 =?utf-8?B?M3pVRE8ybkZmRDM0TkVvTkRkV0lYRG9jWWFxZGFJdGlNSVFqYytkbWh1VmpK?=
 =?utf-8?B?YWo2V1JaUERZcno3TUJwcVozd3BlamM4bGE4OGFZQjFpdG5hcWdsUTF5YUdv?=
 =?utf-8?B?ZU5MeHFVeVpDTXpLMWdQK0VaMWh5cnF4c1B5YUNpeTZhREdSRlVqc051K0xO?=
 =?utf-8?B?MzRTbmdXZzE4aDdkUnh4cmRhMURSNjhEbWNHQllWeWxFQytSUEhVSUIwK1hG?=
 =?utf-8?B?clZYaTNMdTJUNmgzWmNEclEwZGFLeWlpa3JsbEpocW11QnFYZjFzYWxTT0ZC?=
 =?utf-8?B?dDZhT1U5R2V5b1RBa0tlVHdwOTBqUkRLMkxXOGw1TGJ5K3dhR08ya3RxWXYr?=
 =?utf-8?B?eFljd1VSNVpldVhXd3VrVXM4RFhTWDd2dmdNL25MV1hkTlRkNGlpUXMvQThY?=
 =?utf-8?B?a1dYQ2NFR3lVQnBNMEhPSVFNSjdDdkhhakxONTNpTmJyY2FYZndLS3VFVmZV?=
 =?utf-8?B?TzB5a1UzdXUzdTZOdWNBN21ZSjRxbVJxR25Sei85UnUrYUM3NlFsTVY2cGRG?=
 =?utf-8?B?TnVJbEJ3dkpUWXd2RTE2VUJPemR2Y0JUYmo2ZTdCbDNTTzJ3NkFCRE5vYkNU?=
 =?utf-8?B?Tzdxbm85Vy9pb0l2R3BOSld4RXc3bWtXNytLSnRYSk83SGxNbGRXSU9PVjVZ?=
 =?utf-8?B?Q3d1UkxQZ3VDTnlZSGJRdklWR3lWT3lUZW5lak84VHd1RlpwV2ZMZFFmdHFN?=
 =?utf-8?B?YXBrUVk1ZnBCZTcvUWhWOGhobHJScGlFWVA3WHhFM21ON0JkcDIwMlp0U1dE?=
 =?utf-8?B?QWo1SmppT21QQ09zS3BJZW1EeGs5ck40cTRFV1lMcm9OY3Z2c0JLa05kRW1F?=
 =?utf-8?B?cHJRWjdNdnZxY0Z6QVNuYW5TN0pEM2o1eUpFVG9GdlVicFVGdE1LQkhBUzZJ?=
 =?utf-8?B?SERXUEU2alg5NWZKRUU3ZkJKREVhbEJPRDNQM3MrQlJ5Ni9mZ0dVU2k0RzV3?=
 =?utf-8?B?MzNsejRneVU3cWR4UDViMzVQVGw3OStadTBkcjJBbTZCQ1o4KzZWQjEyOWt0?=
 =?utf-8?B?ak5MM2RsYXh2cXZnSVZtVVVjWWpxMlpIU3dveXFlRmwyR3Y3aHQ3MS9HbWZ5?=
 =?utf-8?B?TUxTN2JYY3FycEVjWm9WOEcwM0RGQzZ6U1FtdnAzUXREU3A0WXpzcm5hSVNZ?=
 =?utf-8?B?d0hwZU45RTE2NXR0TGNheFhJaVd3Y2VJSDZReWdIRGJqazJyOStGME5jWEpQ?=
 =?utf-8?B?RXF0Vm9CbGFBei9BZE0rSjRXYXNuQXVOR1Fkb2djc3NvSm4yTEVkZkR0R1c2?=
 =?utf-8?B?ZUlIM1ZMSVJRditCNHhRM0gweEVpeFE4YWZTQlZnOFBRMmVDb3pFRnZlczlL?=
 =?utf-8?B?TGY5eW1kNmoxa0U5QlZEY29WZG1TWXd0ZktuODZCNE5oZXBGRmJPbXMzejRK?=
 =?utf-8?B?MnZNY1R3cmtGNGNDak1iaEYySTc0OGYwck5nUlExanRQdWpxQk9yVVNKQmdN?=
 =?utf-8?B?dG1seTYxQ2VvN0VGb1h2VmVNRjRsMWRQZ3J2ZmMrZmFRU2Rpem9hMEVaRkov?=
 =?utf-8?B?SHA3NFYxVkhlSXJzTmUxcEpheG5SNTNVUkVlTExLK2pLNk9pS0lQa21DcHY4?=
 =?utf-8?B?c3UwOEd0TUQ0OW43RFFsU2ljLzJ3dmdnN0EzaVZEc0RiNkdpYzBWdWh6aTRI?=
 =?utf-8?B?M1ZzcnB6dG00Z3dLUEVWWXBvaGpnazFuejczUTBEYmN3akM0TVZiMVNUeGJJ?=
 =?utf-8?B?RVVLb0RoQXdHOVRoTUIyc3JiZVN4bGlBUWJFd2h6c1JnTzlaaGtZZ25OUzdY?=
 =?utf-8?B?SzNhZFpxcXR5ZW1nY2xzRFY4eTJjeWdPOTIrUHJHVjdzUmg3czVQR1NVcXdE?=
 =?utf-8?B?NEZaWENIZ1F5QzRuSWlyUVUyM2hFMTBXSVMyenI0R3c2QzNtUGt1RForRVNj?=
 =?utf-8?B?QlE9PQ==?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cfcac9d7-fbd1-48b3-7909-08dc1d2976c1
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8774.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2024 22:11:50.7653
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nPYkPXfJCj91ExEzXKwP02TKIWeufd7STbZPOKZxSsBd8mhE/b4PtBNMWYMEcMQ8FQqq9HHRM0LAjD3cwFv0rQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8631

On 1/23/2024 8:46 PM, Andrew Davis wrote:
> Use the device lifecycle managed allocation function. This helps prevent
> mistakes like freeing out of order in cleanup functions and forgetting to
> free on error paths.
>
> Signed-off-by: Andrew Davis <afd@ti.com>

Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>

Thanks,
Iulia

> ---
>   drivers/remoteproc/imx_dsp_rproc.c | 11 ++++-------
>   1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c
> index a1c62d15f16c6..56a799cb8b363 100644
> --- a/drivers/remoteproc/imx_dsp_rproc.c
> +++ b/drivers/remoteproc/imx_dsp_rproc.c
> @@ -1104,8 +1104,8 @@ static int imx_dsp_rproc_probe(struct platform_device *pdev)
>   		return ret;
>   	}
>   
> -	rproc = rproc_alloc(dev, "imx-dsp-rproc", &imx_dsp_rproc_ops, fw_name,
> -			    sizeof(*priv));
> +	rproc = devm_rproc_alloc(dev, "imx-dsp-rproc", &imx_dsp_rproc_ops,
> +				 fw_name, sizeof(*priv));
>   	if (!rproc)
>   		return -ENOMEM;
>   
> @@ -1125,14 +1125,14 @@ static int imx_dsp_rproc_probe(struct platform_device *pdev)
>   	ret = imx_dsp_rproc_detect_mode(priv);
>   	if (ret) {
>   		dev_err(dev, "failed on imx_dsp_rproc_detect_mode\n");
> -		goto err_put_rproc;
> +		return ret;
>   	}
>   
>   	/* There are multiple power domains required by DSP on some platform */
>   	ret = imx_dsp_attach_pm_domains(priv);
>   	if (ret) {
>   		dev_err(dev, "failed on imx_dsp_attach_pm_domains\n");
> -		goto err_put_rproc;
> +		return ret;
>   	}
>   	/* Get clocks */
>   	ret = imx_dsp_rproc_clk_get(priv);
> @@ -1155,8 +1155,6 @@ static int imx_dsp_rproc_probe(struct platform_device *pdev)
>   
>   err_detach_domains:
>   	imx_dsp_detach_pm_domains(priv);
> -err_put_rproc:
> -	rproc_free(rproc);
>   
>   	return ret;
>   }
> @@ -1169,7 +1167,6 @@ static void imx_dsp_rproc_remove(struct platform_device *pdev)
>   	pm_runtime_disable(&pdev->dev);
>   	rproc_del(rproc);
>   	imx_dsp_detach_pm_domains(priv);
> -	rproc_free(rproc);
>   }
>   
>   /* pm runtime functions */