Received-SPF: pass (google.com: domain of linux-kernel+bounces-37751-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Stefan Wahren <wahrenst@gmx.net>
To: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>
Cc: Lino Sanfilippo <LinoSanfilippo@gmx.de>,
	Florian Fainelli <f.fainelli@gmail.com>,
	netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Stefan Wahren <wahrenst@gmx.net>,
	Jacob Keller <jacob.e.keller@intel.com>
Subject: [PATCH V3 07/14 next] qca_spi: Introduce QCASPI_RX_MAX_FRAMES
Date: Wed, 24 Jan 2024 23:32:04 +0100
Message-Id: <20240124223211.4687-8-wahrenst@gmx.net>
In-Reply-To: <20240124223211.4687-1-wahrenst@gmx.net>
References: <20240124223211.4687-1-wahrenst@gmx.net>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:Qw5q0iuuywM=;6Y+cs0RRIy8Wmjncvhepicx5uS5
 d9HGWomSamtw3OjimSWLB2BafCkf8d9jQoAgq/q6vDfxGPg0vUTd3KWujYyKvLhxhSScH3vJH
 ntmkBDkht5jquApRvwbWGiYt2yPvgEQEFUQxP1wGcgk1svqtJpVPdIeVxKXu/sJq3plD7nE2k
 2F7C9+QZo4dBjoviLYz726hEUMcxLvl08ApZLve+8z4IciPDOrhMnIhR0kbyOUpCtri59yhWW
 +YBWKSLThybtVIonlRxJRdsIunnmTg2PV4brg0VmTRVYdhqIkVAoIvxpBEDYo0AyU6xPn1cFC
 WO5pt/E3fVH+ygTvyV/BWQ0eoKMeOFW79iJUPWdu1QFyUliHVc1HrOn93NfGCJuz4kOTTR8Bn
 XouqY6MEKczsAMetSAcYAMT5nu5crE3eqCf6YMhe4bMnhlaRzLaXYNziuz7VY6eKnmpKfSKkJ
 k3XZKaYbzo67+axt4c3OX9JZAmaEzB8TiHo+/gKYmhnzG2fY3x34FFTtEf+6c9s1MdV/l/NtL
 kXri5cdhut8wS/U9VESjqr1t1/BAZOvL5o3pTAr64EwB7sZRsAxWIy4aty1u90c7iCPwpgqep
 LTn2TFdp2jBu3D5cj1f/jki83hPengnKhGM/i5OZ+FR6Qri8jZsCZt7nbsBAjpRizI4Q3hW+I
 qnTujRoWOjzKyqo3L0VTkX+iZQ6KuAJcnT1DfH8LPqPa1dcSj5B/v0QRur9hJCpoT1fif18UB
 a4j94uk0ZD4eSBEtwDoP9pb1w+uOVO39F67HYDZuqRfCeI+FxWaUB1mlh+BW1w0lxgPw1WK9k
 wwhEPxQqhO2B3DJ8ta5wLKOJCWiAmLSsZyW74xEh/v4FwXfgTagTEPpMzKvJwNjkn2c9MrPG/
 +qQo1xO2f1vqR9L/uuyniY/5YgBxHyWwBVhLsemO50pDxPx6dTDJ1JshESmQvi82CjPBQxJtr
 jVVQDw==

Currently qca_spi reserves enough space for 4 complete Ethernet over SPI
frames in the receive buffer. Unfortunately this is hidden under a magic
number. So replace it with a more self explaining define.

Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
=2D--
 drivers/net/ethernet/qualcomm/qca_spi.c | 2 +-
 drivers/net/ethernet/qualcomm/qca_spi.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/etherne=
t/qualcomm/qca_spi.c
index 2ca25844d91c..80182f8a4a50 100644
=2D-- a/drivers/net/ethernet/qualcomm/qca_spi.c
+++ b/drivers/net/ethernet/qualcomm/qca_spi.c
@@ -814,7 +814,7 @@ qcaspi_netdev_init(struct net_device *dev)
 	qca->burst_len =3D qcaspi_burst_len;
 	qca->spi_thread =3D NULL;
 	qca->buffer_size =3D (dev->mtu + VLAN_ETH_HLEN + QCAFRM_HEADER_LEN +
-		QCAFRM_FOOTER_LEN + 4) * 4;
+		QCAFRM_FOOTER_LEN + 4) * QCASPI_RX_MAX_FRAMES;

 	memset(&qca->stats, 0, sizeof(struct qcaspi_stats));

diff --git a/drivers/net/ethernet/qualcomm/qca_spi.h b/drivers/net/etherne=
t/qualcomm/qca_spi.h
index dcecb072b8eb..f735ad77402f 100644
=2D-- a/drivers/net/ethernet/qualcomm/qca_spi.h
+++ b/drivers/net/ethernet/qualcomm/qca_spi.h
@@ -41,6 +41,7 @@

 #define QCASPI_TX_RING_MAX_LEN 10
 #define QCASPI_TX_RING_MIN_LEN 2
+#define QCASPI_RX_MAX_FRAMES 4

 /* sync related constants */
 #define QCASPI_SYNC_UNKNOWN 0
=2D-
2.34.1