Received-SPF: pass (google.com: domain of linux-kernel+bounces-37759-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: "Kasireddy, Vivek" <vivek.kasireddy@intel.com>
To: Andrew Davis <afd@ti.com>, Gerd Hoffmann <kraxel@redhat.com>, Sumit Semwal
	<sumit.semwal@linaro.org>, =?iso-8859-1?Q?Christian_K=F6nig?=
	<christian.koenig@amd.com>, Paul Cercueil <paul@crapouillou.net>
CC: "linaro-mm-sig@lists.linaro.org" <linaro-mm-sig@lists.linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: RE: [PATCH 3/3] udmabuf: Use module_misc_device() to register this
 device
Thread-Topic: [PATCH 3/3] udmabuf: Use module_misc_device() to register this
 device
Thread-Index: AQHaTklTbYB3YNw8AkevdQa0HClb0LDpjxhg
Date: Wed, 24 Jan 2024 22:37:36 +0000
Message-ID: <IA0PR11MB71855122BCF73421B7B531AEF87B2@IA0PR11MB7185.namprd11.prod.outlook.com>
References: <20240123221227.868341-1-afd@ti.com>
 <20240123221227.868341-3-afd@ti.com>
In-Reply-To: <20240123221227.868341-3-afd@ti.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?9MOIZudVVNHug0posfUbn9pzRx5tofKsdX2Ntr1AnepfxhYN2MTlsjh4o3?=
 =?iso-8859-1?Q?n42nZErG1+xMXB7e2mG8P0SW30TjcUQ2IzTKSQt2mV2mfqmPjmy8nESH36?=
 =?iso-8859-1?Q?Shdi3JAe5Tl9mm5NUYa9Hzci0xKFhJ78SpW6L7/1MrRn8CpZjaudTrgYB5?=
 =?iso-8859-1?Q?UO3OhJ6+Ddox3DBckaWqcWmNMPrhSSnbvkvf011aOee2bH8ZBXyX6RgtF4?=
 =?iso-8859-1?Q?LKLIKnLIcFCaXj40iP+MfbgXINTc4+FWXHVMhkG2rMEzoGPC7whJ+OR0x0?=
 =?iso-8859-1?Q?S5G7IsK5jiefevxRYIaoRWUHzo93TGrG/LKg/mPPm4V5Hc+in0SUnfzldD?=
 =?iso-8859-1?Q?X5KdKwny3N22SWmpOHRvDhuznKW6ZZQemce8sLLsEa1rL6LXvT+nFqpTWG?=
 =?iso-8859-1?Q?lHW1RNHnNnxALRdjVDTtiT1eHF2axxBRDlbb0LvPEqadTf+P1WHtQT/GMl?=
 =?iso-8859-1?Q?xrHQeUnhNfcln+Hvf/JSzd/UYULMtGuHbZsRNXAS8KrapDLvdu3593aMHs?=
 =?iso-8859-1?Q?KjbfKCKmM7+eqlYAvM2hU36XWxRjOROFmY5mMghcZz5KDk5/ZqswWauuUi?=
 =?iso-8859-1?Q?JnI2o+LPcwiMj1ZUQyj6TXv+ODLNYN6f5P7YjfV12V+BZFAIDWHOMQGbNS?=
 =?iso-8859-1?Q?k7LFXsy8t8FoGwtjzfk8ezASzQ1LmdeckCeamKScj3+vR4wamyhye3IuzQ?=
 =?iso-8859-1?Q?7KJQrM1lXtzKaWNq2aE78pkRmVbj+QZMj/U6pQert2CNLIJEhSjrn0z/a0?=
 =?iso-8859-1?Q?yPZvE3EyBDy1FM7I/dPESZ2MxfLY7/kjl4bkLTvDedQSh9DEsa8hFo2pvF?=
 =?iso-8859-1?Q?05GOXCGI1QnfLhca38fj+dw/EFDJWz0EKDi713bDbflcUox/CUBc+VCJ+A?=
 =?iso-8859-1?Q?s3Y+Tj5uOHZSJElUw/FV+zzLqRjjIZwa04moPxO2ioUMm0jM+unRCbvJVz?=
 =?iso-8859-1?Q?jd6Gy7luFfG0im87X/G0igEDmI2CJfb305xOvO4Db9R5eAe2WDFk22/KSL?=
 =?iso-8859-1?Q?oq9M/pt/8uETYinug6p2eRwOwIny9YnfaJdyTolPOPfJ6GA0kzVG30THrU?=
 =?iso-8859-1?Q?gvNQ/f2bue5f42+jrMcy5rdWJNiqjysk/aMbS21t0fgI0v76Shcg+c5vmG?=
 =?iso-8859-1?Q?TCatZc9zuI+BXr9OGiEh/vwhvhTVaQeyiRA0qoPGZgTOD8xIOb0cUFsKPz?=
 =?iso-8859-1?Q?M8RB8OFl/VN3iYTxScQtVn/dqpOE/GB/3haJJS/MvIQVfc5vA2PgHQOyVa?=
 =?iso-8859-1?Q?/RvKImnnjZUJ+uao/bGmV99qVQYcEnmyvfZLoGlWsWrvFJYeownIM5RrZa?=
 =?iso-8859-1?Q?x80yZ3bknZMLH/beHDo26KvmbzVjXNSOlDRBpUNsRTOBrp7uoJRfccxTvl?=
 =?iso-8859-1?Q?FmZjuvXu0JzBEYNmLL5DwqoXeiWp8eoqo9oFKa8z9AYPAnes+Gml02XHrI?=
 =?iso-8859-1?Q?xLslrnyA5NHVwms8U4IZTSTlsV/t7Sb9bBVrQe6x1Nza2l1AW2j1NOKc9H?=
 =?iso-8859-1?Q?/HlEQhbpOtzSwWzwpWpDQgFzT2QMjCryyQr526faqgqbJvDv6rRm+Yj8TP?=
 =?iso-8859-1?Q?ysoW9AtyMZmLmUb+O/SmU0D0hp30wWqRx0Z41IYrPEuGJj5VAyvEJeN0aK?=
 =?iso-8859-1?Q?BCd+WDo4NAXp1D78oDL+KXQxz31V9vSkW1?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: IA0PR11MB7185.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 72509d9c-2f6c-4431-d989-08dc1d2d1075
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2024 22:37:36.6153
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qrddnmXo4W1xU+84KQMKV1vfVlFpo1rpFClrJajWuZQGgpdRjXigRPFSFCzaE1DYm0+997Ff1w0NhfWQxMyU0FndX3pIdk6/Y0tciYgbGhE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4592
X-OriginatorOrg: intel.com

Acked-by: Vivek Kasireddy <vivek.kasireddy@intel.com>

>=20
> Now that we do not need to call dma_coerce_mask_and_coherent() on our
> miscdevice device, use the module_misc_device() helper for registering an=
d
> module init/exit.
>=20
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>  drivers/dma-buf/udmabuf.c | 30 +-----------------------------
>  1 file changed, 1 insertion(+), 29 deletions(-)
>=20
> diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c index
> ab6764322523c..3028ac3fd9f6a 100644
> --- a/drivers/dma-buf/udmabuf.c
> +++ b/drivers/dma-buf/udmabuf.c
> @@ -392,34 +392,6 @@ static struct miscdevice udmabuf_misc =3D {
>  	.name           =3D "udmabuf",
>  	.fops           =3D &udmabuf_fops,
>  };
> -
> -static int __init udmabuf_dev_init(void) -{
> -	int ret;
> -
> -	ret =3D misc_register(&udmabuf_misc);
> -	if (ret < 0) {
> -		pr_err("Could not initialize udmabuf device\n");
> -		return ret;
> -	}
> -
> -	ret =3D dma_coerce_mask_and_coherent(udmabuf_misc.this_device,
> -					   DMA_BIT_MASK(64));
> -	if (ret < 0) {
> -		pr_err("Could not setup DMA mask for udmabuf device\n");
> -		misc_deregister(&udmabuf_misc);
> -		return ret;
> -	}
> -
> -	return 0;
> -}
> -
> -static void __exit udmabuf_dev_exit(void) -{
> -	misc_deregister(&udmabuf_misc);
> -}
> -
> -module_init(udmabuf_dev_init)
> -module_exit(udmabuf_dev_exit)
> +module_misc_device(udmabuf_misc);
>=20
>  MODULE_AUTHOR("Gerd Hoffmann <kraxel@redhat.com>");
> --
> 2.39.2