Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp1414962rdb; Wed, 24 Jan 2024 14:58:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IE2zS1j1zm6bFvu4XdQ15tNgpbVi1D06ZTRw0eEC+63PvUtSbfZ/nH/jtNloZuR4YXV7X7b X-Received: by 2002:a05:6a20:1611:b0:19c:4f3e:ba59 with SMTP id l17-20020a056a20161100b0019c4f3eba59mr414682pzj.22.1706137119150; Wed, 24 Jan 2024 14:58:39 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706137119; cv=pass; d=google.com; s=arc-20160816; b=gwW3+bCDX0xYM1OUiFZfxhdjAkLCAeN7XbyXeXbJSXNJatFXsjWOfLi8dEM3Q8AsqY neJvLA11N1o12/4Tlj5B0zFgAvC253qTuuYGdGHnEHzvioV5N8pE/LA28nEM+fHAA7H1 4g3irIXc97O5W6EVukvukUkaKqFRfDm0dNulFpiQxzuj/wAdB6+FSzQxdvr2dcNiIOvD upjg0m/YAWKnUxDFOsekjSMGfAD5DPuRd3nzZ7qxWXyttxtfD/EXEZm0kI5JhS9sQKcV v8ymRM6YGOdcZ9P6VPlb3aZdlDf67FqmDiN+0DcB0fdIkjex5e/jC2DyW6XN3SarOCSh gMfg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=H2gnBlix09dA/0FaK3x5WB04GLsPbiuq/+N36a3GKLU=; fh=xvOL8OMYVAezpmH3esNrEghgh0NereVOlFypTKLX0R8=; b=pMarWDtknYqjOXqFgHCQzrslInAt9PbGkL80H4jiYR3frbfbLzTe7541fWbpZ7RH37 jKrxDK5s23xvhF5rEkGcb1V4m1onz+y3lNpA/d4sSbSeYSYTT5OUDhZCIIN1a2LCkBpE BnCc6Lr3/6NRozPzOjsZzR5vkq2g3kLWp2aBs4Biv96ypnpvER9pnGQBv0oMZ96WIRNx 3Qg/CuaH6X5TOi1stivQl1M1obWJG6qFi9c6HTVHSsp1wGsIuz8oA5ZPCinY+8A1v8o/ SKihJTySy6yKHrhvTHw4/HtvDGUAzGq98XF0Ye0Fp3ydISkqbHZLYS+Eg+Tjh6bTLxHi ZGUQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmx.net header.s=s31663417 header.b=iY6VFbsc; arc=pass (i=1 spf=pass spfdomain=gmx.net dkim=pass dkdomain=gmx.net dmarc=pass fromdomain=gmx.net); spf=pass (google.com: domain of linux-kernel+bounces-37753-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-37753-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=gmx.net Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id n1-20020a634d41000000b005cf0ac054d7si12194266pgl.290.2024.01.24.14.58.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 14:58:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-37753-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@gmx.net header.s=s31663417 header.b=iY6VFbsc; arc=pass (i=1 spf=pass spfdomain=gmx.net dkim=pass dkdomain=gmx.net dmarc=pass fromdomain=gmx.net); spf=pass (google.com: domain of linux-kernel+bounces-37753-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-37753-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=gmx.net Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 5ABE4B24F0D for ; Wed, 24 Jan 2024 22:36:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B0BB013BEAD; Wed, 24 Jan 2024 22:33:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b="iY6VFbsc" Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEBD31353F3; Wed, 24 Jan 2024 22:33:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135600; cv=none; b=Y/uMxi5zgvhw5aU1PTAsfSngjQT2TLv0YANKpIxGJ01/Vbcj2/MIkaNNn+FYqoNDxgxUisT8sjlMUcJU66B93U82toQLJDbFAXHP3vapkNy3ScXBPdikTXi+b0cdH2vfcqxz2IQ2npTvLKvnc9oXnRzuy+x5uaqVP9yU6eIEkJc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706135600; c=relaxed/simple; bh=ZkQWzZ1tqQ+RtdmjwZVBTOtlj+vwXzEAwzG2LCDJfng=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qQbaCHb5oQS+pjvQDsEn5hj/gpJIrCUJB9cZdbtACqybaSoOgcnKtWdF57Up50sqVj+NwcU0WgIihwwY7jWo2LeonM77UTtgFjrU6fu7+MaQy/PjoQKWsFT21yEgJu2+mY2h7o6FwLmxkeePl61ihNwE9xIibPDZbSKQHiLawt4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=wahrenst@gmx.net header.b=iY6VFbsc; arc=none smtp.client-ip=212.227.17.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1706135558; x=1706740358; i=wahrenst@gmx.net; bh=ZkQWzZ1tqQ+RtdmjwZVBTOtlj+vwXzEAwzG2LCDJfng=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=iY6VFbscuKy7fMaZbS4ls4F6iM/doo8A72dKzcm6G3ARJioGHEQ7U8ZFX3HXbxxu M7mPY+odDnD02ll1v3EYKdb4TjXTOlncWCp1LmuyEnsYFuivnK8bObNOtQCpx4Lpb 8fjpfG6TTIuuGwMIIMtIBETKJhBJAQOhA2OpYnBteC7ZuDrP1McIggWkRGdlUJ1Ea 2/gvUKTw/XLwNr766YjpR+zfuI+ayyV6FFloaPNmowqCNpZy7t9vJjT8s44KJp3oZ bCTf8Ly6B53gJia6Bumy6NFEytKNhgTxxbqNPN2aDtGi0VcGHVXwW5uId8/7UtMAk 3TBuCmyYEG1Y22W5CQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N4zAy-1r3RUQ0rno-010uXA; Wed, 24 Jan 2024 23:32:38 +0100 From: Stefan Wahren To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Lino Sanfilippo , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Jacob Keller Subject: [PATCH V3 03/14 next] qca_spi: Avoid skb_copy_expand in TX path Date: Wed, 24 Jan 2024 23:32:00 +0100 Message-Id: <20240124223211.4687-4-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240124223211.4687-1-wahrenst@gmx.net> References: <20240124223211.4687-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:l6d25/OxlNTDfb9rsSl/KAhlnToWqi0QjdZWqxfWfLo1e6aJTjI OtG3wQef5tap9sVXOCxPq7YmyXE8+DIglZw9Bp9hWEnlDc+oTSyARKyhEKyoBEVmLE2E+IZ hpl4AfMxF3eo55hEU7pvRiU/v2v6L+GkTR5jnaaLjqGswfI2VhRCf6pvWEdRGbiQTPnQ/f3 NSidEML+mYhdxGRd6Ta3g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:Xhtu9VDwTRk=;H8oiTroUBKrKH8kvEeuyfZNp7yV VRl7jmuLStV4Jz9TALf8/EqpClXB/mGEJwyHMqPLAVNWO5m9zCMsWX8DnjpBKhMOx5uO1vMbr TKHA0zVZpze/dq9xQM5aNIjvvAAbz3CYzbklBUqYwQ2QMaetJKcLBGCTm+esYM++UhX1rn6jP Cvd4KB3AkBxAPVjnnYqdTKo0gEw+rUmifnilCNFMWSDcVsu9QuV/IJohpEl/pKGNHdH5d69WW faFmxtoHvUls2ANGluQ9zm2Zb+LlrTfvVZUy1fqcOTY3h272xvMA4bZdNx0WibXQv+V9lIZn/ QHDabkIhXC5pt6zjr0siYuN/9cqTDvgVeuLb0xBZZixrIUg6fITwS9H2MzVp77gUq5iLbk/Ey +3/GYtDg3A56DhznQ+8uBn1ZQpSv4L9PNdkaexPFTtYIhoChWPOqooB2CkBClrmd5/sLYDFBj WX31W2/QWYXZUpokeKVmuq545a0RHjzSYTnAaG0SrhUdZ08QSQPww147Nwr2oVjlpM4QuwbuD DE0yvvymodkS+y8b77iqRmyAAsO2fkpkNrh+HlDDMSF00lEPRlpLIxskzHU57174QKrajuSbI dqyBnZzQJ7uCg1lZW39d0RmkQsi4i5xCygk5mXInJ8wgmyINJFiIoZFVFoFFRioGE+bCTYQ7R re7M6qbAd5k7FrczPgt8jK4g7MUqtH+4UUGVvPyuSAtogHiXVIh4Vo6an8+GDxfkAsRcGCUZG BBY0nLryo7mGV0NFY5m7pGGLvuwWcofCDovdl/7FVk9XE56HHtEgDpTS1DBGWfXXpUrlhZqOY qxJFtafZ9aZcLO5yDj6r+U4THriKzGBq9F/EgyGDdPZMdMe32/h9XzANMVmkIq2DuVqY9rkZ6 aYZj+bOmiFi5dBmrpe1p+75HEzLwUScFijlI2zeKiCMffVLDN6AwAOeDfqfEMSVkBwCEuROhz Wi4/Ig== The skb spare room needs to be expanded for SPI header, footer and possible padding within the TX path. So announce the necessary space in order to avoid expensive skb_copy_expand calls. Signed-off-by: Stefan Wahren Reviewed-by: Jacob Keller =2D-- drivers/net/ethernet/qualcomm/qca_spi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/etherne= t/qualcomm/qca_spi.c index 294d4ee3b38f..919a400412cb 100644 =2D-- a/drivers/net/ethernet/qualcomm/qca_spi.c +++ b/drivers/net/ethernet/qualcomm/qca_spi.c @@ -877,6 +877,8 @@ qcaspi_netdev_setup(struct net_device *dev) qcaspi_set_ethtool_ops(dev); dev->watchdog_timeo =3D QCASPI_TX_TIMEOUT; dev->priv_flags &=3D ~IFF_TX_SKB_SHARING; + dev->needed_tailroom =3D ALIGN(QCAFRM_FOOTER_LEN + QCAFRM_MIN_LEN, 4); + dev->needed_headroom =3D ALIGN(QCAFRM_HEADER_LEN, 4); dev->tx_queue_len =3D 100; /* MTU range: 46 - 1500 */ =2D- 2.34.1