Received-SPF: pass (google.com: domain of linux-kernel+bounces-37812-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 25 Jan 2024 00:04:56 +0000
From: Matthew Brost <matthew.brost@intel.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
CC: Jani Nikula <jani.nikula@linux.intel.com>, Joonas Lahtinen
	<joonas.lahtinen@linux.intel.com>, Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>, David Airlie
	<airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	<intel-gfx@lists.freedesktop.org>, <kernel-janitors@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915/guc: Remove usage of the deprecated
 ida_simple_xx() API
Message-ID: <ZbGlqD6zyyp4DsmH@DUT025-TGLU.fm.intel.com>
References: <7108c1871c6cb08d403c4fa6534bc7e6de4cb23d.1705245316.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <7108c1871c6cb08d403c4fa6534bc7e6de4cb23d.1705245316.git.christophe.jaillet@wanadoo.fr>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xXxPdjGh/TcigKPw/fB8w+2xqnvm3EmbwUFSybdltINdD/pGaVjeZcgKBl1q?=
 =?us-ascii?Q?A1iqHAehBtbhTo3hOj488bvkBUQyib9hhlPURNe2f+sNkup+Yiluz0e76roz?=
 =?us-ascii?Q?R+UJyAWHHuJ8TLRcxJGLU2TekAS57RKUf4c3jLZXnNc1ewkB1lBe22Rmg+N7?=
 =?us-ascii?Q?psaVXZmz0bKLKpltfABBTMrb+LGe0i1b4LwxTbM3ZT2VRtUnqLHvvLFBT0zU?=
 =?us-ascii?Q?TfZm2KCiEeJjjwzM++XhzZoV28pKCnWIpKSgwH4RRJqlNv7ZlNm23WOzRwGt?=
 =?us-ascii?Q?426XbGTFzDloq0DPYnAUp0vCIsT73LaXWA1j93yAfFJCmbBt1ejcJGFG0pRH?=
 =?us-ascii?Q?rsox4agQZOH+FUKZy7IW90li/nvxYEnUSM4URxnMUvplaRrgwYneQBKJlAKt?=
 =?us-ascii?Q?qdD6kyus6JxVmFPQ29lyec+NLccDXeeuLvruoTbC+VeB1sK7yP4STMdYHLg+?=
 =?us-ascii?Q?pttu/5kmpnJ9mpPEDvOc5A6WMnaBFGkNeF0xyMogAX8E+ygQ6GiuqsDUGLVx?=
 =?us-ascii?Q?DYHJRL19FTPZDFDZNlafainvYTWTMIYyDwtBDYR1L5iVKL12p669pO5FXHuC?=
 =?us-ascii?Q?faVcCliskxeEm/Gh+bRTxhwDWvyRXxUMNzZDHjA6ftVSNjHyRxqioz20OMwa?=
 =?us-ascii?Q?HQrQ2Uc1ADUL4zJhVgH/GKKatQ7dLRkhWNB6YdOBVN0ErT2jufNzOokHhN75?=
 =?us-ascii?Q?f+9eabsDwzNrnskKCHjGIZSeCRkExfYxwdCUPYfztxZ0rpJ1zdwGTkLOGrK6?=
 =?us-ascii?Q?zQAS5z6XAdoaTwxa/pP+f4Tjyg3Qt1K8ISmx0flm/zRO2ryFZVZ9HXzmDuWA?=
 =?us-ascii?Q?iFHHQI4EzxbyseNfR1t8V7ap2RKzqDJgVFlEDePc/+LUup8ZOA6EYV0+zRWY?=
 =?us-ascii?Q?jAYOMlr56JNolm9dQnju9/hfx1VePGuvzE/VgCz2+yuJcC6edDpr5zsvGCBW?=
 =?us-ascii?Q?OObgThAvZEtScAAFgiYmjo55qI/EVadpFEJYPbY1IBxFWqkHI+tqZvu6XKww?=
 =?us-ascii?Q?ObDIu2XlI33efh3mto9ROwH2j22I47aBJqikiV0UKnZOF5X8/L3tHMDsLXQh?=
 =?us-ascii?Q?InsVttOIY8PTiJ2zowyaOZOhg2VRMoy5H4kMzhTQ7Z/W8/Ap5Nns5PiI+OBs?=
 =?us-ascii?Q?iNkT5KybRgMKHyEuzITZyLKRF+9iIutIrNwwLJMbcIsYsnunPkvXRI2lNJPc?=
 =?us-ascii?Q?g1AJMCFf+AESZO+uoT1A61Zqcu9JY7SjL3++N+6JUNwiVFwTG+XYsvpa1Ff9?=
 =?us-ascii?Q?VOTRqKUPKDv3RgNR1ebkx/Oi8fvHClbVik5/WPmKk0jbBPy6c2BO3c3X6mcm?=
 =?us-ascii?Q?/pXvCjljd4Kq4rukqfBee4pSgCli35qu5a1jkLtqYuGqyvQmiZfFt3dOON+E?=
 =?us-ascii?Q?a2js/wkOkgOmCuV3nTp8oTuIVq+TJspbX/VKfo5HymDh/hiWsYBzDnMXVhbS?=
 =?us-ascii?Q?imDy+sfTgA+E8wvQZbi8gsleGKNFvB+LA5OlFXPNLCGRKCGelGVxPJjBd8MB?=
 =?us-ascii?Q?AxBpFAbMDA89rJ1P6L8Kkv349cvhVXo5KwrC34ABdJBOwZPaASiRZUGpHXQl?=
 =?us-ascii?Q?wAzctrmayPh/u4k1EoDiZLGkqFDoNVMHX9GCz/3deH5Yy/Yck+mLID7gQzQX?=
 =?us-ascii?Q?HA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: abfc9c64-f38b-4b20-3e05-08dc1d395ea9
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6522.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2024 00:05:42.0127
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AYxfe6licZEuBjP+0v3GvXpW60KmDiNtSpSf4dT3J/EFNKb5Gf2IUEhOtS9aV9ybUoM3vHM5spip6v9RhrUV5w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6376
X-OriginatorOrg: intel.com

On Sun, Jan 14, 2024 at 04:15:34PM +0100, Christophe JAILLET wrote:
> ida_alloc() and ida_free() should be preferred to the deprecated
> ida_simple_get() and ida_simple_remove().
> 
> Note that the upper limit of ida_simple_get() is exclusive, but the one of
> ida_alloc_range() is inclusive. So a -1 has been added when needed.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> ---
>  drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> index a259f1118c5a..73ce21ddf682 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> @@ -2156,11 +2156,10 @@ static int new_guc_id(struct intel_guc *guc, struct intel_context *ce)
>  					      order_base_2(ce->parallel.number_children
>  							   + 1));
>  	else
> -		ret = ida_simple_get(&guc->submission_state.guc_ids,
> -				     NUMBER_MULTI_LRC_GUC_ID(guc),
> -				     guc->submission_state.num_guc_ids,
> -				     GFP_KERNEL | __GFP_RETRY_MAYFAIL |
> -				     __GFP_NOWARN);
> +		ret = ida_alloc_range(&guc->submission_state.guc_ids,
> +				      NUMBER_MULTI_LRC_GUC_ID(guc),
> +				      guc->submission_state.num_guc_ids - 1,
> +				      GFP_KERNEL | __GFP_RETRY_MAYFAIL | __GFP_NOWARN);
>  	if (unlikely(ret < 0))
>  		return ret;
>  
> @@ -2183,8 +2182,8 @@ static void __release_guc_id(struct intel_guc *guc, struct intel_context *ce)
>  							   + 1));
>  		} else {
>  			--guc->submission_state.guc_ids_in_use;
> -			ida_simple_remove(&guc->submission_state.guc_ids,
> -					  ce->guc_id.id);
> +			ida_free(&guc->submission_state.guc_ids,
> +				 ce->guc_id.id);
>  		}
>  		clr_ctx_id_mapping(guc, ce->guc_id.id);
>  		set_context_guc_id_invalid(ce);
> -- 
> 2.43.0
>