Received-SPF: pass (google.com: domain of linux-kernel+bounces-37813-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <a85f6896-cc7d-4cba-a5eb-96f20c901c57@intel.com>
Date: Wed, 24 Jan 2024 16:12:24 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] x86/resctrl: Fix unneeded variable warning reported by
 kernel test robot
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>
CC: Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>, <fenghua.yu@intel.com>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <dave.hansen@linux.intel.com>,
	<x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
	<rdunlap@infradead.org>, <tj@kernel.org>, <peterz@infradead.org>,
	<yanjiewtw@gmail.com>, <kim.phillips@amd.com>, <lukas.bulwahn@gmail.com>,
	<seanjc@google.com>, <jmattson@google.com>, <leitao@debian.org>,
	<jpoimboe@kernel.org>, <rick.p.edgecombe@intel.com>,
	<kirill.shutemov@linux.intel.com>, <jithu.joseph@intel.com>,
	<kai.huang@intel.com>, <kan.liang@linux.intel.com>,
	<daniel.sneddon@linux.intel.com>, <pbonzini@redhat.com>,
	<sandipan.das@amd.com>, <ilpo.jarvinen@linux.intel.com>,
	<peternewman@google.com>, <maciej.wieczor-retman@intel.com>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<eranian@google.com>
References: <84128a3c83654493f637b8349153af10d69e2752.1706118776.git.babu.moger@amd.com>
 <39c4501e-4937-49de-b12b-742e6201df6f@intel.com>
 <20240124183153.GFZbFXmTKTLEpwZshW@fat_crate.local>
 <e96df7ac-f0b4-4300-8546-7c1df836dea2@intel.com>
 <20240124191429.GGZbFhldYr3K85H9cg@fat_crate.local>
 <6635c607-cab2-45f4-a0fe-ff4f53b36849@intel.com>
 <20240124204525.GIZbF25bekUME2flt0@fat_crate.local>
 <7d6e3d39-ce53-40e4-bba5-242911a1522a@intel.com>
 <20240124224657.GKZbGTYTjN2m8VirbF@fat_crate.local>
 <abf569d6-9634-424f-97b3-a71716b3cde5@intel.com>
 <20240124233424.GLZbGegG_5eUaGBOlz@fat_crate.local>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240124233424.GLZbGegG_5eUaGBOlz@fat_crate.local>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGphbjlRT240Y1d5aW1ObytydGFEMmZ2Um81ekw4YXBTZCtmeTNScHAzdnBY?=
 =?utf-8?B?TlJPN1VDOWFMQTV2RnR1ZnB6Y3FzbklUTEJNdWhwTkxCVmNRcDF6ei9lekZL?=
 =?utf-8?B?VnJIWkR0ZTgrTVRBQnVBTkppQjdadWRBOU5tWFFJMFA3Ti9ZOEs2S0RzVDk4?=
 =?utf-8?B?QUNKNDRrb2FmY09YWnkvVEtzUWdXY3lwUUtnUWwxQTlad2ZVNDcyUUhuQkZZ?=
 =?utf-8?B?Wlc5cWV4Q0dzSGlZNzFnRWxoVWFPUTc2bHdRaG9NV2pCODVGWThFNE9YTDVO?=
 =?utf-8?B?YmMyRUI1OWp4NGxHbnp0WmZTRjBRYmFFNjFVd0hybVNENUtlTStFWCtFWVFx?=
 =?utf-8?B?dGx5THNZMkRxTk1LVG1ScUd2Qko4eEFYZzVzWXB1QUtTWWJRTXM5d3Rib3Ev?=
 =?utf-8?B?OFVML28rNlhNcnR2K2cxZ1hCQ3pveFJPL2hNbkVNenRsakJZU1JJQ1hTbWhM?=
 =?utf-8?B?UmVmWEMyOW1NOHRvdlRySmxiaHpkSU5BSlk5QXhsWDIzQ3VqeDlMV3Y2K3FN?=
 =?utf-8?B?dEFZS2dtS080dFdwUm9zVHZLdWtIZVNOaXVaeVdYekRJcE9sQWtoRkh5MXN4?=
 =?utf-8?B?ZDRVYXlyQjVOQTkzMk8ybjBYeGxEc2d5SUlTRDQrQ012ZytpV3dxS1VDNUtK?=
 =?utf-8?B?bmpvb2t6M3NsRDF1WGlaUHF0MDhaMHpQZ1NHRmlsdTJTZWQzNDJjc2FGRVFF?=
 =?utf-8?B?dHQrMEplMllDVEpsWXg0eE8vVVpzQnF5WTBmRlQzSVdVSW82bG83L0E3MW1V?=
 =?utf-8?B?cG9FVU5VaTNQNmpHMk45NkFmamN2czJqRG5EeXg5OStpYzdvNkV3blVMa2Jv?=
 =?utf-8?B?UVZqZ2djL1ppbTA0RFp1VzNNSmg5VlQzVS8xMkJDTTY5TGRNazlDZ0FMRVBN?=
 =?utf-8?B?K2hyRDhOdDZxdFdMaVEyb251bjJBWnIzbnhiYjZuNHp6SnUxalQ5Q29JU2x0?=
 =?utf-8?B?Tlp0T09ab2dLZW5OdHFJQjlWeWZML3NDeXNkVGtzekVEQkcyVjJvMHJqNUlz?=
 =?utf-8?B?dGVDeUZNNXBEMWxiWE5LZzltdXltSzhqVWFzMXFXcXUrejdyS1N2QXVieUZv?=
 =?utf-8?B?a3JVUHE3M3U3NXo3NEFFWmpXd21qa2RmWjZ5aUx0YXdaN1ArM1RsTStqY2tv?=
 =?utf-8?B?eFhQMEJDZnRxMnJDNzNncjk3M1FjelpDR0UvOHN5dFZVNmsyZXZJUm1NQW0w?=
 =?utf-8?B?UU1lRG1ob1FTZnNmNVQwdzRUeGI3NktCb3B6M2g0MTRKREMzelZFSStSekhW?=
 =?utf-8?B?MjRmajVqcEloTmhkcytJNFk4Uzl1Y1FnL2FKR0k2d1A5SEh1VWJ1TlNvSTFr?=
 =?utf-8?B?RG5XV3NHdW52d2cwZzNhbzBFSUZScmtjblhSNnRXMHhRalJWOGVOQlIzZnVF?=
 =?utf-8?B?TFNoUFRScWdUd0JHWS9ONWV0Z1JXQ293VnJkb01LdzVLRWlya2s2ZFJFWkZN?=
 =?utf-8?B?dytCWWxsaEowTkFpVTIwRFJ5ZkdROEpWOG9ia3N0R2FYRTRucUtRWDREMlBt?=
 =?utf-8?B?aXRqaTdCWHNzc0I5aERqa2dMS09SbXY0MnZTajBJcjROM0tIQUpjU3JKSGxs?=
 =?utf-8?B?TzVDNkFnY3V6NnlyWVRKdU9Lc0tReEx5MzVFTkxxMnlXaU15c2RnNGxDNjBZ?=
 =?utf-8?B?NzZIR0FPNVF0WktZeVczR3ZtK3NyNGp6OG01b09HQStOenRtU2lGbnN5OXN2?=
 =?utf-8?B?c0wxdmFJUStWSWQ1S3lsY09tUHlwaDIrQUYxSXRYRGZ1MGdZSWhvckk3azZD?=
 =?utf-8?B?Q0Yybzg3UFUrYU9udmpIb2wzZHVSZXZKVTM1dGZIakxpSHBJR1p5QXFEU2FG?=
 =?utf-8?B?a0tEV2hzYWF1ZHJXRnUrakdFa2t2bm5XaUViV0loZUFTcHk2emZqZlFiT3pX?=
 =?utf-8?B?SGJxaUtwOURUMHllR0pFa1B5QjZOMFRUd0owZ25UU0VuQkwrUmt2UDkxUzcr?=
 =?utf-8?B?QmFYQkNKVThzN0RmellMNVlITlIxUmhWY3M5OVdtaXRXMmVRMDlWM1JzdFZI?=
 =?utf-8?B?RHZIMHZrTWQvdU5TNVpCNHVqMlRMSk9mblVvU2VmcFhTTmJmbXplVHdjZWxF?=
 =?utf-8?B?UC8zWFVpSWIyWTU3N3ErcmplcjVhaXU5MUpqSGpuNzVqVkRuWTI3bzFjdG5U?=
 =?utf-8?B?MldsQ0lGME1TZUtQWkJuV09qYjlqakZEVklTUXN6OE42SklTNjFnNVRQNTBB?=
 =?utf-8?B?T3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 068e3772-1245-438b-0155-08dc1d3a5076
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2024 00:12:27.7001
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7S5O2+I/ScOlAuRACXRMIk9/83oZ/f6xi8PMR+48X60U04wkBuZ40geHaM54i+f78pwHiaboO5CRekW+pQww8XpTsa42jHfseTtWJdgL7nQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7636
X-OriginatorOrg: intel.com

Hi Boris,

On 1/24/2024 3:34 PM, Borislav Petkov wrote:
> On Wed, Jan 24, 2024 at 03:03:15PM -0800, Reinette Chatre wrote:
>> Since you are the one that decides the rules for inclusion you can make this
>> check to be one where checkpatch.pl can be ignored. No objection from me if
>> you choose to do so (and I will note the precedent for future patches).
> 
> Nah, that's not nearly as important for you to change your workflow.
> 
> What I'd suggest, though, is to sanity-check what checkpatch suggests and
> ask yourself whether it always makes sense.

Will do. Thank you for considering and discussing this detail. The final
patch you just merged looks good to me. Thank you very much for fixing this.

Reinette