Received-SPF: pass (google.com: domain of linux-kernel+bounces-37826-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 25 Jan 2024 11:38:14 +1100
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Florian Eckert <fe@dev.tdt.de>
Cc: Jonathan Corbet <corbet@lwn.net>, Lee Jones <lee@kernel.org>, Linux
 Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux Next Mailing List
 <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the leds-lj tree
Message-ID: <20240125113814.532f1fb5@canb.auug.org.au>
In-Reply-To: <20240109222031.6ce4aecc@canb.auug.org.au>
References: <20240105173352.6ce1a546@canb.auug.org.au>
	<17b4305d9fe1fbed3e39597f0767f7bd@dev.tdt.de>
	<20240109222031.6ce4aecc@canb.auug.org.au>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/4uO6+UUiXI0D9d4GYIhnp8B";
 protocol="application/pgp-signature"; micalg=pgp-sha256

--Sig_/4uO6+UUiXI0D9d4GYIhnp8B
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi all,

On Tue, 9 Jan 2024 22:20:31 +1100 Stephen Rothwell <sfr@canb.auug.org.au> w=
rote:
>
> On Mon, 08 Jan 2024 08:47:07 +0100 Florian Eckert <fe@dev.tdt.de> wrote:
> >
> > thanks for your hint
> >=20
> > On 2024-01-05 07:33, Stephen Rothwell wrote: =20
> > > Hi all,
> > >=20
> > > After merging the leds-lj tree, today's linux-next build (htmldocs)
> > > produced this warning:
> > >=20
> > > Warning: /sys/class/leds/<led>/rx is defined 2 times: Documentation/A=
BI/testing/sysfs-class-led-trigger-tty:7 Documentation/ABI/testing/sysfs-cl=
ass-led-trigger-netdev:49
> > > Warning: /sys/class/leds/<led>/tx is defined 2 times: Documentation/A=
BI/testing/sysfs-class-led-trigger-tty:15 Documentation/ABI/testing/sysfs-c=
lass-led-trigger-netdev:34   =20
> >=20
> > The behavior of the tty trigger can be controlled via the Rx and Tx fil=
e.
> > If a value is set in Rx or Tx, the LED flashes when data is transmitted=
 in
> > this direction. The same behavior is used for the netdev trigger.
> > I have therefore used the same pattern for the new tty trigger as well.
> >=20
> > I didn't know that the names have to be unique!
> >=20
> > I'm a bit at a loss as to what to do now. Should I put a prefix "tty_"
> > in front of the names so that we have "tty_rx", "tty_tx"?
> >=20
> > If we do it this way, however, the general question arises as to whether
> > we do have to use a prefix everywhere! If new triggers are added, then =
the
> > names for a config file are already used up and anyone who then wants t=
o use
> > the same name for an other trigger with the same config file because it=
 describe
> > the same function must then work with a prefix! =20
>=20
> I think this is only a problem with the documentation system, not the
> actual sysfs file naming.  Maybe just adding a uniquifying bit to the
> "<led>" part will solve it.  Or maybe we need the tooling to be taught
> about placeholders in sysfs names (or maybe there is already a way).

I am still seeing these warnings.

--=20
Cheers,
Stephen Rothwell

--Sig_/4uO6+UUiXI0D9d4GYIhnp8B
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmWxrXYACgkQAVBC80lX
0GxV1Qf/bYGwt4bH5nc7W/ImRPtKuWZYgw1QJek/CY9UD4JGqOxrZqRTW4Kd/9gU
XpdsmaYOKXdOaTRvIszBMDsi2V/IBrcm0fssjicaO4N3l8iPyOJMhruTyqHzt5lH
yPm5LhxC/Pwr+IV18GONTqpR+vVKszVlqinS2CZCg34G9fUSE9SA1r8qOIg/r49I
xl2gRYcflDuEh2V+UuM0GXAZcdN/ZEviCQoAWS6IUOjgr9QBiOnYk7QEJSKs6KZ8
8bI0PQr6ijZouTAgxYfDj4vLBjmOHrzXbxjT+w51O0IlGsNYOolUyVcIjC4gN0Zw
U0x8Fw6TNCrZo8xd4Sbf6dyXKMMzHA==
=SSGo
-----END PGP SIGNATURE-----

--Sig_/4uO6+UUiXI0D9d4GYIhnp8B--