Received-SPF: pass (google.com: domain of linux-kernel+bounces-37854-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <726d018c-01d0-48b3-870b-c63fb06eb0d0@vivo.com>
Date: Thu, 25 Jan 2024 09:34:53 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] mm:vmscan: shrink skip folios in the exiting task
To: Matthew Wilcox <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org, opensource.kernel@vivo.com
References: <20240124124308.461-1-justinjiang@vivo.com>
 <ZbEOrim8tjMXB5os@casper.infradead.org>
From: zhiguojiang <justinjiang@vivo.com>
In-Reply-To: <ZbEOrim8tjMXB5os@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Qlc1QlM1MDBId01WZzZBWjlVZXU3dnFzZzRydFEwck14Zno1NHdsdHNhVHI1?=
 =?utf-8?B?QTV2V213VWlsT00xZ3F1SWx5YU5iTnVENEkyODI5YXhoYzdDUHM4cHpBUTNm?=
 =?utf-8?B?OUZvWlRJSkhKMy9QYTg0cTVnUnJMNzFORzN2L3NRMlp4VDFSR1pwU2NIMGVp?=
 =?utf-8?B?Z1lCMEFRNVdJWDlWQzVtRjZNTFdkUzlqdFRjL2hrbHZEeXBWNVUwL1ZQS1pR?=
 =?utf-8?B?Uy9tdkdZbG50Ym0yL2ZHZEw1NXdzckphNTVqUU4zWlg2R0lhaFI3VmFYTmZk?=
 =?utf-8?B?dW5zTUNBazhGeWtWc1dEeERyQXIvVHRwdEpvTitTajltcGtoUGhyVTEwaFM2?=
 =?utf-8?B?Vi81M1hLbDFnL0NWR2V5M0pWeW5jN3dxVW5HL3V2RW0xRXBpQ211WE1DVmlq?=
 =?utf-8?B?Mm1xZldJYXEzTXZ4c0J5a2lkTi95MjlNeitIUTk0QS9NMTNmWjl1NVhmL2h2?=
 =?utf-8?B?SFJhTEc1MjVnY1E1QzRoQXBFaTMzK1VTZlZiSEtwaHE1WDRUYXBTSzhMNjJH?=
 =?utf-8?B?SHNNWDBtT0txcFFiTW9kME5JaWJzcTRGdUxlZjllcU1KWnpodFhrSHlHeFVw?=
 =?utf-8?B?eTBvK3hCYWxIdDAzSjlmRDJuMmpZR0M5UDAwTVNETHVwZ2ovNHRHSVNPa1E1?=
 =?utf-8?B?R2QrS2E0YSsreVlrOXpFLy91WUpIUjFzS1YzaWg2ODNOWkl0WVlYbndOT1R4?=
 =?utf-8?B?QXVVNG5kU2JrR2c0cldOeisrcmtkZjZxNDVITzVpMTN6cG5tYUZ3YjJUYmRE?=
 =?utf-8?B?bnRERE9qb2FTeEtQS1pmcUwycWdmZUFWSUpRV3NsYkdSR2ZFQUlkWnlUY2g5?=
 =?utf-8?B?c05BSWNMcVBYeTloWTNkUVMydHRsS0NpODlhSmFCNzZ2RVFEVTc5ZTZESXh4?=
 =?utf-8?B?Rm1saFExSTc1MXBsQjFWaEtzZ1Z4ZVhMYWZsSmlVN2cyVXMzc0hXdDQrWkVo?=
 =?utf-8?B?UHBLSDcvc2VUb09lcEtzelJVR25aOXIzaUZSMEFOYzl3YkdFWXpDajRKR01O?=
 =?utf-8?B?NWRrQXEzVGxLbmgzblJMd2h2a2RaVTlOTEhTaDdqY0U5Vm9XUHVRcU9SYmFJ?=
 =?utf-8?B?RnZZNmpsczhPUkthNGQxRjkyb2s5UC9XWjNGWWI4eW9ZVmZhUTRwUGRaVHJV?=
 =?utf-8?B?K1FpTDBaM1RaYjA5bWFRYUV6NDVvR3FQQ0hUWUdxelUwNG50VlZqL1BsUzFK?=
 =?utf-8?B?RFdPb0E5UGF1Y2VQMERPSi9hc2k5QndXTlVRelFET2tRUEpUSnN1VnBnNWlj?=
 =?utf-8?B?VUMrZ2FHcnQxTWhXNWZ1UVF1Smh1RENFZlhJcndWU1NZOUNvZld3TXFta1hE?=
 =?utf-8?B?QVYwSXlsSVVDMkQ0MXVad0FnSHdZYVlhZVlZRGJKRjd5cUU0aXFzNWNzd3RL?=
 =?utf-8?B?UXNrMUhYZmRrOUdIeVJuQ0pmdU1BS3piZC9WOWlVRm1rOFZPZlIxVno3L2d6?=
 =?utf-8?B?NFpuYWtxNXgvM29EbmJqOHhGbWNFTlZ5OEtxa2d4L293RER6OHFXSHNSZW0y?=
 =?utf-8?B?NVEyNlN4eGc3SjYxdFNwWmsxNDMwSUNkbjgyaDVJMVFOYkMwUUw1UUhHeDZy?=
 =?utf-8?B?M3dYSGE3UEhCdFFsVFAvcXd0RzZPTVA2cDArQThvcDNXVU1LUEErdXVkRVB3?=
 =?utf-8?B?WDBucFZDQkc4cEtWTzBLbEFKSyt2QjZwZWJOakFUWkthZHVTWVRzdk82cHFy?=
 =?utf-8?B?OE1OTE9KSHhLckxoUCsyS24xaUZWb0VDY3Q3bVR5eUE4K0VKVnNCVkhqTmkz?=
 =?utf-8?B?dkdMa3E2a0hPdi9kbjNFV29ieEZkelRFQW5NQ2t2VFQwK3llOEw5ajdVMGor?=
 =?utf-8?B?RTNRT2FEMjFNUkhsTWswTE5QMXFyaDBIT0NrY3V3bVUxcTVjOTVEbVFtQ1JK?=
 =?utf-8?B?S1dDOE55ejU2TWx4ZVIyZ1NrcE9hY1BKdHN0eFBKeDBHODlDQkxxYjZMb0Yv?=
 =?utf-8?B?ajR6cnJTL0N6VlkrdzFwODREUExyRGZsZ3ZmTnc3UGNHZlVlN2Zwd1NCN1pw?=
 =?utf-8?B?bGhWb2w1NEl4c2N4UUFDbTZ6dEIvVDZBNkMraW14YXdnMmpuNkpvbUtGUE91?=
 =?utf-8?B?cS8yOEZzSFZ5RUlLNUgvcXVKNDFwVEt3T0FJWXFUNVIwQnFoSjVrOGFlYllD?=
 =?utf-8?Q?AIB99jdSzJ8U4py6ZLW5Jq9+j?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df6565f2-070d-494c-d207-08dc1d45d635
X-MS-Exchange-CrossTenant-AuthSource: JH0PR06MB6849.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2024 01:34:56.4540
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ce22R8CX0DnJDMlY+RDUtWZB3mLhYccVheWvGwclvJbObUwdkGSxAnj12mfErc2yrdBiv4NAFxnlUrNuzOx+5g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB4365


在 2024/1/24 21:20, Matthew Wilcox 写道:
> On Wed, Jan 24, 2024 at 08:43:07PM +0800, Zhiguo Jiang wrote:
>> If the shrinking folio is belong to the exiting task, this folio should
>> be freed in the task exit flow rather than being reclaimed in the shrink
>> flow, because the former takes less time.
>>
>> If the folio which is belong to the exiting task is reclaimed in the
>> shrink flow, such as the anon folio, the anon folio needs to be first
>> written to the swap partition by swap-in in shrink flow, and then the
>> corresponding swap folio needs to be released in the task exiting flow.
>> As is well known, releasing a swap folio will task more time than
>> releasing directly an anon folio.
>>
>> In the scenarios of the low memory system and mutil backed-applications,
>> the time-consuming problem caused by shrinking the exiting task's folios
>> will be more severe.
> What testing have you done of this patch?  How often does it happen?
> Are there particular workloads that benefit from this?  (I'm not sure
> what "mutil backed-applications" are?)
1 Yes, this patch has been tested.

2 When the exiting tasks and shrink_inactive_list occur at the same time,
    the folios which shrink_inactive_list reclaims may be the exiting 
tasks's folios
    in lruvecs. And when system is low memory, it more likely to occur, 
because
    more backend applidatuions will be killed.
    The shrink_inactive_list reclaims the exiting tasks's folios in 
lruvecs and
    transforms the exiting tasks's anon folios into swap memory, which leads
    to the increasing load of the current exiting tasks.

3 This patch can alleviate the load of the tasks exiting process. This patch
    can make that the exiting tasks release its anon folios faster 
instead of
    releasing its swap memory from its anon folios swap-in in 
shrink_inactive_list.

4 "mutil backed-applications" means that there are a large number of
     the backend applications in the system.

Thanks
>
> And I do mean specifically of this patch, because to my eyes it
> shouldn't even compile.
Has been tested.