Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp1484321rdb; Wed, 24 Jan 2024 17:59:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IF5BCorS89FCGwreseKRYo1PCNq4nqzfS139//xY2oL/uPx/uhHsiixDJSFg4u24zwwwDlk X-Received: by 2002:a17:902:fc8d:b0:1d7:953:bc0a with SMTP id mf13-20020a170902fc8d00b001d70953bc0amr387613plb.88.1706147958459; Wed, 24 Jan 2024 17:59:18 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706147958; cv=pass; d=google.com; s=arc-20160816; b=TtInyXDenKpDTDFnjgtbHl96T1jiBWwPvE1V3FPutsj1q7IfL8FyBUt40e082Y4Xk8 0asOljExxwfomsjuOKhMkLocXVq6NVouu8EKsQFCuldodwAMWkZU6f5/XENgBvrkASmm li75liAmTbt2mX417Rzk+Ol4FEMovH2yBcnMpI0MFvOt0K8glQbmRGKvT1kFryN4Fx/b P9aPDr6FvvN8uzudl65roYTChgiBriJAJSCLNr2RgYUqrY6091WGGGVfYM+liFeRPdqE iYG+OmSnrJKqcGZe1NjjLgLF/N6A05cKAX0qem2ugBkfkpoj97YAN0zCCwxKfPqNto3l h0iQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=2xMhnPSuhw1qGdGqIJUaDWTab52xNbIjXShP48EkESQ=; fh=zeF5ET1Givs9XfS+iKiOfxc2lfAQCEwC20RFEOshVKA=; b=kfLfV50gnn25bDn7GBOlMWQUBWSTIrR15iHZQSEb+//yKvOGoWyjtwKVlI0nX1Y1xx ahIN7BVwx5yL/fnlxg8zyqSsRMAb5mS0ctVFas/SRENC2Yx54xrIeo6y3YCoACC4I5LA yDRtTFRLkKokg0nM7RZ1usYhFqgA0/V6FMMzoXI7cw0dEUrwJROIupbbSidn+gfIHq5P 5ZoBjH+1TZx7xhf9MgP21P912RiqdU+yHWW6wOpKMD1bVsZGvXG3mMGTb3nd631HLbVN Wb4MQcrgsxMfjOrgbsXAT9txhClCNBmnZkNxXvCJWZvsddn5y7/bXAPvfj+vkHslFlz1 7YmA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=n80qv1tH; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-37880-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-37880-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id v24-20020a1709028d9800b001d75eef04f4si4969937plo.104.2024.01.24.17.59.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 17:59:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-37880-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=n80qv1tH; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-37880-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-37880-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 02EA8B23039 for ; Thu, 25 Jan 2024 01:57:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 075F85C9A; Thu, 25 Jan 2024 01:57:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="n80qv1tH" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AD9F1388; Thu, 25 Jan 2024 01:57:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706147862; cv=none; b=Eqnk9oy2TeHoKMAfAev2drarp+HESpdaiSVLoSxIiS3f2vZkNWaH3CTRYf3NlCAzKDc3AbMogvPIBLrrmX5YjdC+ahqZeVJwUenyh5OEgeKom6AMlDfKwk5t5uLnPP+Vi3M6oe/MLkvYI1WEgcLOalXqVKK4oQQjFcF3BRpSTn8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706147862; c=relaxed/simple; bh=QcD8kLygxlg10WUj2we5Ozo/oHkcB52bSflymWoKYJ8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QJYgIKXEE/eqYf+nvBF2PR77MJcOUl/B+IcGboPIy5HBwMomXlqQxl306VfpbRRPr1S6nQNXdkODqd4vAp3fgwaDyZYLYjXIpe3x0iifu/k8DQr0v1vBSKfP/vvr87JvKZFXb4mjCUpEPByiUxEKqqgDUm5z6gLz1e3+B0vwCoU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=n80qv1tH; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08EC2C433C7; Thu, 25 Jan 2024 01:57:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706147861; bh=QcD8kLygxlg10WUj2we5Ozo/oHkcB52bSflymWoKYJ8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=n80qv1tHH5sjBkMcqTJSvExzCWRw3lpNxO0AlgEh71Pdq8tRZJ3AJFJih0QlXAg/S t3hQdto0lRPcjxK02izYqgPyYAE/ADGcjbbcImUPc0v255zzhCAxn46Dq/0hNiqVGV aSGCkEB8ZEo+X+lwbVvwdOnImFxc8N6Sdp8YLFHp96o/5xOJWP77MT4g97H9yZu4tw L/MQR53ickFAccne686mAqR1P5XxYbsCOjVBVNnUEl9nH9Cn1XkOyFaJSpwsUEdGAg voxecvPyToCmUDGZrtL8Aud877q5/NuTuoftKWHdg/df66tCt2Dgu/e6LVLOd0p1xB hgSCBodagzyjg== Date: Wed, 24 Jan 2024 17:57:40 -0800 From: Jakub Kicinski To: Fabian Pfitzner Cc: Michael Hennerich , "David S. Miller" , Eric Dumazet , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexandru Tachici , kernel@pengutronix.de, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] dt-bindings: net: adin: add recovered clock output Message-ID: <20240124175740.397af763@kernel.org> In-Reply-To: <20240124102554.1327853-1-f.pfitzner@pengutronix.de> References: <20240122110311.2725036-1-f.pfitzner@pengutronix.de> <20240124102554.1327853-1-f.pfitzner@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 24 Jan 2024 11:25:54 +0100 Fabian Pfitzner wrote: > The ADIN1300 offers three distinct output clocks which can be accessed > through the GP_CLK pin. The DT only offers two of the possible options > and thus the 125MHz-recovered output clock is missing. > > As there is no other way to configure this pin than through the DT it > should be possible to do so for all available outputs. Hi Fabian! If you want to use PHY-recovered clock you should really use the DPLL subsystem. It will also allow you to configure other PHYs taking this signal as an input, to forward the clock phase. Read lock state. Etc. Even if the patches are good (which I'm not saying they are yet ;)) - you'll have to repost this as a new thread, unfortunately. I'm not sure why by the way this was posted made patchwork think that the patches are separate series: https://patchwork.kernel.org/project/netdevbpf/list/?series=819440 https://patchwork.kernel.org/project/netdevbpf/list/?series=818548 each of which is incomplete, since it only has one patch but subject says "1/2" and "2/2".